Over to sdy@ for M68 :)

Multiple tabs are being selected, but the visuals are very unclear. If select half the tabs via shift-click and try to drag them out of the tab strip, it will work.

I've attached snapshots for tab selection from macOS [views] and Linux. In both cases, the visual distinction between an unselected tab, and a selected [but not active] tab is quite unclear.

Deleted: Screen Shot 2018-05-14 at 6.18.48 PM.png 111 KB

	Screen Shot 2018-05-14 at 6.18.48 PM.png 111 KB View Download

Deleted: Screen Shot 2018-05-14 at 6.19.03 PM.png 42.6 KB

	Screen Shot 2018-05-14 at 6.19.03 PM.png 42.6 KB View Download

pkasting: Perhaps we should get a designer to tweak the contrast for all platforms? 

(Additional information: SHIFT-Click is working to select multiple tabs in a row e.g. Tab A+B+C+D, but CMD-CLick to select single tabs e.g Tab A+D is broken.)

@4: You're also using a custom theme; IMO this is better (but not great) in the default theme.

We've been a bit uncertain how to handle the visuals of "selected but not active" -- bettes@ proposed just drawing all such tabs like the active tab.  There's no obvious great answer that fully generalizes to all themes and states, though.

Attaching image of multiple selected tabs in default theme [views and cocoa]. The cocoa version appears clearer.

Deleted: Screen Shot 2018-05-15 at 11.30.35 AM.png 34.8 KB

	Screen Shot 2018-05-15 at 11.30.35 AM.png 34.8 KB View Download

Deleted: Screen Shot 2018-05-15 at 11.31.23 AM.png 18.7 KB

	Screen Shot 2018-05-15 at 11.31.23 AM.png 18.7 KB View Download

+ bettes for feedback.

Heh, I forgot that on Windows the unselected tabs become semitransparent to the frame, AND I have a non-default frame color.  So what I normally see looks better than what you're seeing.  My bad diagnosis :)

The Cocoa version you post basically uses the active coloring for selected tabs.  This sort of works because the tab borders give Z-ordering.  In refresh I'm not convinced this will be as good, without tab borders to Z-order anything.

I expected all the selected tabs to use the active coloring, as pkasting suggested. I'm less concerned about z-order in the event of selecting...assuming that the ordering is preserved once you've completed whatever sort of dragging action. 

https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g3232c09376_6_1194

The main reason Z-ordering matters is because the active tab can change, and without some kind of Z order, it's not clear which of the tabs in the selection corresponds with what's visible in the content area.  I don't know how much this matters.

pkasting:

You were the last person to futz with the opacity of selected [but not active] tabs 2.5 years ago:
https://codereview.chromium.org/1510763002

Do you remember why you made those changes, and how those particular values were chosen?

Options are:
1) Wait for GM2 refresh.
2) Change values back to what they were 2.5 years ago [slightly more differentiation]
3) Do nothing.

[I'm not inclined to make drastic changes without significantly more UX input].

I'm going to WontFix this, since (1) will address this.

FWIW, I think a lot of it was me playing with things until they seemed as good as I could get them across a variety of themes/frame colors.

Hello erikchen@: We closed this report because multiple-selection (SHIFT-Click) is working fine. The selection color has been also tweaked in one of latest updates. 

But I noticed still two edge cases:

1.) CMD-Click to select single tabs isn't working.

2.) The selection isn't unselected after detaching the tabs out of the window.

Both issues are working fine in Cocoa mode.

Can we reopen this report or should I file two new reports?

Thanks in advance :)
Mehmet

Thanks - please file two new bugs.

> Thanks - please file two new bugs.

Done:  Issue 856698  & issue 856702