New issue
Advanced search Search tips

Issue 836971 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ozone demo apps tear on eve in surfaceless mode

Project Member Reported by spang@chromium.org, Apr 25 2018

Issue description

There appears to be something wrong with the synchronization in ozone_demo as there's obvious tearing, especially in the skia version.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbbf0a551e8c9efa244c8171cc219859c303e539

commit bbbf0a551e8c9efa244c8171cc219859c303e539
Author: Michael Spang <spang@chromium.org>
Date: Wed Apr 25 22:06:29 2018

ozone: demo: Remove duplicate render frame in surfaceless mode

Since the surfaceless renderers inherit the surface renderers, we
actually initially post two tasks to render frame. This results in
tearing.

Remove the duplicate post. As a followup, this inheritance should
be removed since it is too error prone.

Bug:  836971 
Test: ozone_demo on eve
Change-Id: If79edf65f6aba2cc239f0e349860d6b56ba82450
Reviewed-on: https://chromium-review.googlesource.com/1028844
Reviewed-by: Albert Chaulk <achaulk@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553782}
[modify] https://crrev.com/bbbf0a551e8c9efa244c8171cc219859c303e539/ui/ozone/demo/skia/skia_surfaceless_gl_renderer.cc
[modify] https://crrev.com/bbbf0a551e8c9efa244c8171cc219859c303e539/ui/ozone/demo/surfaceless_gl_renderer.cc

Cc: penghuang@chromium.org rjkroege@chromium.org
 Issue 833453  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/756d113826bd190b6d8b75c2367aacc04756bf52

commit 756d113826bd190b6d8b75c2367aacc04756bf52
Author: Michael Spang <spang@chromium.org>
Date: Thu Apr 26 17:50:25 2018

ozone: demo: Don't inherit GlRenderer from SurfacelessGlRenderer

Using inheritance risks operations leaking into the other type of
surface, or being duplicated, as in  bug 836971 . There really isn't much
code to share, so untangle these classes by just copying the common
parts.

Bug:  836971 
Test: ozone_demo on eve
Change-Id: I952dd8e8e3284a1713ec39ec4371f230c3ddb8d7
Reviewed-on: https://chromium-review.googlesource.com/1028983
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554074}
[modify] https://crrev.com/756d113826bd190b6d8b75c2367aacc04756bf52/ui/ozone/demo/gl_renderer.h
[modify] https://crrev.com/756d113826bd190b6d8b75c2367aacc04756bf52/ui/ozone/demo/surfaceless_gl_renderer.cc
[modify] https://crrev.com/756d113826bd190b6d8b75c2367aacc04756bf52/ui/ozone/demo/surfaceless_gl_renderer.h

Comment 4 by spang@chromium.org, Apr 26 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment