[MacViewsBrowser] Toolbar buttons with keyboard focus don't show focus ring |
|||||
Issue descriptionChrome Version: 68.0.3406.0 OS: macOS 10.13 What steps will reproduce the problem? (1) Use the Tab key to change keyboard focus to buttons in the toolbar bar What is the expected result? Buttons with keyboard focus show a focus ring. What happens instead? Buttons with keyboard focus have a background highlight, as if moused over.
,
Apr 26 2018
,
Apr 30 2018
,
May 7 2018
Any progress here?
,
May 7 2018
Thank you lgrey@. Pls land the change to trunk when ready.
,
May 11 2018
Any progress on CL listed at #5?
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/863a60dad81526b65e56ea57406db32f87cd06ff commit 863a60dad81526b65e56ea57406db32f87cd06ff Author: Leonard Grey <lgrey@chromium.org> Date: Wed May 16 16:46:46 2018 MacViews: Use focus rings for many focused elements instead of ink drop This change adds a new platform style constant for whether focus rings should should be preferred over ink drops to indicate focus. Button subclasses can opt into this behavior by setting install_focus_ring_on_focus to true. This change includes this opt in for all top chrome buttons (as well as page actions). Bug: 836961 , 826294 Change-Id: I32239b88c4e3862d6f1029b375df7c678b5044a5 Reviewed-on: https://chromium-review.googlesource.com/1043011 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#559139} [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/frame/app_menu_button.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/page_action/page_action_icon_view.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/page_action/page_action_icon_view.h [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/ui/views/controls/button/button.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/ui/views/controls/button/button.h [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/ui/views/style/platform_style.cc [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/ui/views/style/platform_style.h [modify] https://crrev.com/863a60dad81526b65e56ea57406db32f87cd06ff/ui/views/style/platform_style_mac.mm
,
May 16 2018
Can this be marked as fixed if nothing else is pending?
,
May 17 2018
Tested the issue on latest chrome version 68.0.3433.0 using Mac 10.13.1 with steps mentioned below: 1) Launched chrome reported version and tried to changing the focus by using Tab key and observations are as follows => On keyboard, by using 'Cmd+l' to focus the omnibar, then clicked on tab key, the focus directly jumped on to the page => Installed screencastify extension, clicked on extension icon and clicked on Tab key, the focus moved to the buttons on the extension popup, observed focus changed like hovering with mouse @Reporter: Please find the attached screencast for your reference and let us know if we missed anything in verifying the fix, please help us in confirming the fix. Thanks!
,
May 17 2018
viswa.karala@ you would need Full Keyboard Access on (System Preferences > Keyboard > Shortcuts > on the bottom of the panel)
,
May 17 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by meh...@chromium.org
, Apr 25 2018