New issue
Advanced search Search tips

Issue 836955 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
M-X



Sign in to add a comment

[macviews] shift key doesn't slow down animations

Project Member Reported by thakis@chromium.org, Apr 25 2018

Issue description

What steps will reproduce the problem?
1. keep shift pressed while hitting e.g. the new tab button, or a tab's close button

What is the expected result?

new tab or close tab animation plays in slomo. (compare e.g. with shift-clicking the minimize button of any window, or with non-mac-views)

What happens instead of that?

It doesn't.


Not super important, but useful for debugging animations, and as a system integration polish thing.
 

Comment 1 by meh...@chromium.org, Apr 25 2018

Components: UI>Browser Internals>Views>Desktop
Labels: Proj-MacViews
Labels: M-69 MacViews-Browser Target-69
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
Over to sdy@ :)
Labels: -M-69 Group-MacOS_Platform_Integration_and_Participation
Labels: M-69
Labels: -M-69 -Target-69 M-X
I agree this would be cool, but Apple (half-) removed the slow-down effect in 10.13

https://apple.stackexchange.com/questions/303106/how-to-enable-slow-genie-effect-in-macos-10-13-high-sierra

Note we already have kSlowDurationScaleMultiplier in layer_animation_element.cc -- adding some mac-specific code to LayerAnimationElement::GetEffectiveDuration() that just checked for `shift` in +[NSEvent modifierFlags] - https://developer.apple.com/documentation/appkit/nsevent/1535211-modifierflags?language=objc - would be pretty straightforward...

but it would only affect layer-backed animations, not ones implemented with redraw via gfx::Animation (we should kill all those animations anyway)
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
***Mass UI Triage***

As per dev comments.

Sign in to add a comment