New issue
Advanced search Search tips

Issue 836953 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[macviews] tools menu looks all weird

Project Member Reported by thakis@chromium.org, Apr 25 2018

Issue description

See screenshot. This doesn't look or feel like anything else on macOS (too much spacing, weird font size (compare with e.g. tab labels, or right-click cnotext menu). Mouse over an item and keep arrow-down pressed -- it cycles focus through the menu (i.e. the last item is focused after the first icon) instead of stopping at the top of the list, the highlight color doesn't match the system highlight color (in blue; looks fine if the system is set to graphite – kudos for getting that right).

…oh, and the context menu over web contents and omnibox is in a different style.
 
Screen Shot 2018-04-25 at 4.13.42 PM.png
87.6 KB View Download

Comment 1 by meh...@chromium.org, Apr 25 2018

Components: UI>Browser Internals>Views>Desktop
Labels: Proj-MacViews
Status: Untriaged (was: Unconfirmed)
Status: WontFix (was: Untriaged)
Thanks for this.

The other MacViews menus in the browser also look this way, and at some point so will context menus for the webcontents; this is the "material" menu style from  issue 829347 . Filed webcontents menus still being Cocoa is  issue 837230 .

The arrow-down behavior is wrong though - I do need to fix that. Filed as  issue 837229 .

The highlight color not matching the system color is again deliberate, per  issue 829467  - it matches the grey highlights on all other controls in MacViews instead of matching the system menus.

I'm going to mark this bug WontFix and track the other work on the filed separate issues.

Sign in to add a comment