New issue
Advanced search Search tips

Issue 836949 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill] Synthetic fields.

Project Member Reported by parastoog@chromium.org, Apr 25 2018

Issue description

For some synthetic fields, if we change the visibility of a hidden select field corresponding to the synthetic field, and try to change the select field as a user, the change is reflected on the synthetic one. But the same is not true when the autofill tries to fill the form. 

www.newbalance.com
chapters.indigo.com
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ddbd0a3f170ec05598eec92b2dfdf105dac1c03

commit 0ddbd0a3f170ec05598eec92b2dfdf105dac1c03
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Fri Apr 27 19:27:55 2018

[Autofill] Reflected Synthetic Fields

Reflected synthetic fields:

Reflected synthetic fields are synthetic fields for which
if one changes the visibility of the corresponding hidden
select field in the source code, and select an option on
that, as a user would do, the change would be reflected
on the synthetic field.

Solution:

we can fill a reflected multiple field, by making an exception for
select fields. Previously, this exception was made for non-focusable
ones, meaning that a non-focusable select field would get autofilled,
even though it wasn’t visible. We need to broaden this exception to
include the fields with ‘role=presentation’. This will fix the problem.

Fixes:

chapters.indigo.com
www.newbalance.com


See: go/synthetic-fields for more on this issue.

Bug:  836949 
Change-Id: Iefad5de1432e5c2a8a64c0ec9bf79a6db9f557b1
Reviewed-on: https://chromium-review.googlesource.com/1028721
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554446}
[modify] https://crrev.com/0ddbd0a3f170ec05598eec92b2dfdf105dac1c03/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/0ddbd0a3f170ec05598eec92b2dfdf105dac1c03/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/0ddbd0a3f170ec05598eec92b2dfdf105dac1c03/components/autofill/core/browser/form_field.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 30 2018

Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87208d646089690c6ba7e31568f47f9b1970ffd4

commit 87208d646089690c6ba7e31568f47f9b1970ffd4
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Fri May 25 16:47:07 2018

[Autofill] UKM for potential Reflected Synthetic Fields.

Logs the skipping decision for hidden or representational fields.

Generally, we need to skip the hidden/representational fields, but to
support reflected synthetic fields, we don't skip them if they are of
'select' form control type.

Test added.

See go/1038546-ukm-review for UKM collection review.

Bug:  836949 
Change-Id: I68c284d39a25176a008f2ad5305f5844a7b4c697
Reviewed-on: https://chromium-review.googlesource.com/1038546
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561912}
[modify] https://crrev.com/87208d646089690c6ba7e31568f47f9b1970ffd4/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/87208d646089690c6ba7e31568f47f9b1970ffd4/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/87208d646089690c6ba7e31568f47f9b1970ffd4/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/87208d646089690c6ba7e31568f47f9b1970ffd4/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/87208d646089690c6ba7e31568f47f9b1970ffd4/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/87208d646089690c6ba7e31568f47f9b1970ffd4/tools/metrics/ukm/ukm.xml

Status: Fixed (was: Started)

Sign in to add a comment