New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836927 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Adding user action recording for P2P sharing.

Project Member Reported by romax@chromium.org, Apr 25 2018

Issue description

In order to collect user metric and see how often P2P sharing feature is used, we need to add user actions when sharing action is initiated.
 

Comment 1 by romax@chromium.org, Apr 25 2018

The CL has been landed but it was associated with another crbug, in order to merge it into M-67, I'm opening this crbug so that it can be labeled without affecting the main feature implementation tracker bug: 758690

Info from the implementation tracker:
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4056bd3f5e5cd9575d78b2aef44f24581df4e068

commit 4056bd3f5e5cd9575d78b2aef44f24581df4e068
Author: Yafei Duan <romax@chromium.org>
Date: Fri Apr 13 19:16:33 2018

[Offline Pages] Adding user action recording for P2P sharing.

Adding user action recording for P2P sharing:
- When user shares page loaded in current tab from overflow menu.
- When user shares pages from Download Home.
- When user clicks on the reload button in the snackbar shown when an
  untrusted page is loaded.

Bug: 758690
Change-Id: I1b5c4dae5d33fb84b363ca2b26b2c56eb58efcf0
Reviewed-on: https://chromium-review.googlesource.com/1009073
Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Joy Ming <jming@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550713}

Comment 2 by romax@chromium.org, Apr 25 2018

Labels: -Pri-3 Merge-Request-67 Pri-2
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 26 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Has this been tested in Canary?

Comment 5 by romax@chromium.org, May 1 2018

Cc: cma...@chromium.org
Yes I tested in Canary 68.0.3416.0 and it's collected correctly.

+cmasso as cc for visibility (sorry if i shouldn't do that)
Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Approved-67

Comment 7 by romax@chromium.org, May 4 2018

Status: Fixed (was: Started)
merged into M67 branch, closing the issue as fixed.

Comment 8 by romax@chromium.org, May 4 2018

See #53 in the main tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=758690#c53
Project Member

Comment 9 by sheriffbot@chromium.org, May 7 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-67

Sign in to add a comment