New issue
Advanced search Search tips

Issue 836918 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature


Sign in to add a comment

Implement scroll latching and metrics of ScrollingCoordinator with blink property trees

Project Member Reported by pdr@chromium.org, Apr 25 2018

Issue description

ScrollingCoordinator is the a grabbag of logic for sending scroll-related data from blink to cc. This needs to be rewritten to work with blink property trees where PaintArtifactCompositor is responsible for sending scroll-related data to cc.

Some examples of the data that we need to plumb through the new compositing codepath:
  Set cc::ScrollNode::overscroll_behavior with BlinkGenPropertyTrees
  Set cc::ScrollNode::snap_container_data with BlinkGenPropertyTrees
  Make scroll latching work with BlinkGenPropertyTrees
  Make scrollbar animations work with BlinkGenPropertyTrees
  Make position constraints work with BlinkGenPropertyTrees
  Make scroll metrics work with BlinkGenPropertyTrees
 

Comment 1 by bokan@chromium.org, Apr 26 2018

Status: Assigned (was: Untriaged)

Comment 2 by bokan@chromium.org, May 24 2018

Blockedon: 846414

Comment 3 by bokan@chromium.org, May 24 2018

Cc: -sahel@chromium.org
Owner: sahel@chromium.org
Summary: Implement scroll latching and metrics of ScrollingCoordinator with blink property trees (was: Implement non-hit-test parts of ScrollingCoordinator with blink property trees)
I've split everything but latching and metrics into issue 846414 - this bug will track the scroll latching and metrics parts.

pdr@, I took a quick glance inside ScrollingCoordinator and didn't see anything obviously related to latching or metrics. Do you remember where these came from?
Blockedon: 846771
Blockedon: 846787
Blockedon: 846790

Comment 7 by pdr@chromium.org, May 25 2018

I took a look at latching and don't see anything that we need to change.

The scroll metrics I was referring to are things like ScrollManager::RecordScrollRelatedMetrics. I am not sure if anything needs to be done there.

Comment 8 by sahel@chromium.org, May 25 2018

I will check the scroll related metrics with the flag on to make sure that everything is recorded properly.
Status: WontFix (was: Assigned)
Both scroll latching and scroll related metrics for touch/wheel scroll/fling on main/Impl work properly.

Sign in to add a comment