New issue
Advanced search Search tips

Issue 836915 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 840017



Sign in to add a comment

Make VisualViewportTest work with blink generated property trees

Project Member Reported by pdr@chromium.org, Apr 25 2018

Issue description

VisualViewportTest is currently coupled to the current compositing infrastructure and needs to be updated to work with blink generated property trees, where PaintArtifactCompositor makes compositing decisions.
 

Comment 1 by bokan@chromium.org, Apr 26 2018

Status: Assigned (was: Untriaged)

Comment 2 by bokan@chromium.org, May 24 2018

Components: Blink>Scroll
pdr@, looking at this closer, what do you expect is the problem with these tests? There's ~6-7 tests that are directly making assertions about viewport layers and their properties - these will have to be updated once we no longer create visual viewport layers. Are these tests what this bug refers to?

Otherwise, I expect the vast majority of the tests here wont need any changes. They load some html and then poke at the visual viewport and assert things about it. Unless I'm missing something, they shouldn't directly be building anything BGPT-related themselves. 

Comment 3 by pdr@chromium.org, May 24 2018

I don't know much about these tests, only that they need updating. If it's just 6-7 tests--that sounds great!

Comment 4 by bokan@chromium.org, Jun 19 2018

Blocking: -836910

Comment 5 by bokan@chromium.org, Jun 19 2018

Blocking: 840017

Comment 6 by bokan@chromium.org, Jun 19 2018

Blocking: -836890
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4940976efd556edfb4c1e1459d61c4a8be5ca842

commit 4940976efd556edfb4c1e1459d61c4a8be5ca842
Author: David Bokan <bokan@chromium.org>
Date: Wed Aug 22 14:44:58 2018

[blink-gen-property-trees] Update viewport tests

Update visual viewport unit tests for blink gen property trees. BGPT
still creates layers in the compositor so the changes are fairly
limited. In places where we check layer properties, this patch also adds
checks for the equivalent paint properties.

Bug:  836915 
Change-Id: I3d821cea1021b28d87ceff188931eaae3fa3b7c4
Reviewed-on: https://chromium-review.googlesource.com/1184963
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585014}
[modify] https://crrev.com/4940976efd556edfb4c1e1459d61c4a8be5ca842/third_party/blink/renderer/core/frame/visual_viewport_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment