Issue metadata
Sign in to add a comment
|
MacViews: Omnibox Popup prevents users from clicking on text entry field of Omnibox |
||||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3406.0 OS: MacOS 10.13.3 Flags: #top-chrome-md --> Refresh #secondary-ui-md --> Enable #show-all-dialogs-with-views-toolkit --> Enable #views-browser-windows --> Enable #omnibox-ui-hide-steady-state-url-scheme-and-subdomains --> Enable What steps will reproduce the problem? (1) go to some page, i.e. https://medium.com/topic/entrepreneurship (2) observe medium.com/topic/entrepreneurship in omnibox, as expected (3) click once in omnibox, URL is highlighted and suggestions box opens (4) try to edit URL by clicking once or twice in omnibox -- in text or at end of URL (5) nothing happens What is the expected result? Can edit URL What happens instead? Stay in highlight mode Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Apr 25 2018
Is the version of on-focus suggestions shown on your machine one that we are going to ship?
,
Apr 25 2018
Oh! I turned off zero-suggest and that solved it. We are not planning to ship that flag to 100% in the near future. Cool, thanks.
,
Apr 25 2018
We have no plans to ship most-visited zero suggest on desktop, which triggers on almost every page. But contextual zero suggest, which triggers on a very small % of pages, is already launched. So I think this means that if there's some polish issue we might be able to ignore it. But something this serious will need to be addressed somehow.
,
Apr 25 2018
Err.. the flag that I just turned off was #enable-zero-suggest-redirect-to-chrome. As the flag is worded that sounds like it's Cusco, so now I'm confused. +mpearson, can you help clear up our confusion?
,
Apr 25 2018
Okay, based on c#4, I tested this again. On Windows, it works with Contextual Zero Suggest. On Mac, with that set of flags, it DOES NOT work with Contextual Zero Suggest. But I also noticed that on Mac with that set of flags, when the Omnibox popup is open at all (try typing something else), you cannot click on the text field at all. So it seems like the real bug is -- With MacViews, the Omnibox popup prevents users from clicking in the text entry field. Looks like hit test masking does not work on Mac -- which is a familiar problem. It doesn't seem to work right on Windows either.
,
Apr 25 2018
Yes, that flag is Cusco. Cusco triggers more than non-Cusco contextual suggestions, probably n*x more, where n is a single digit number. It doesn't as yet trigger on https pages, which is likely why you don't see the issue on that particular page anymore. Is this simply a dup of bug 836829 ?
,
Apr 25 2018
> So it seems like the real bug is -- With MacViews, the Omnibox popup prevents users from clicking in the text entry field. Oh, ok, sounds like this is https://crbug.com/836829 then.
,
Apr 25 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tommycli@chromium.org
, Apr 25 2018Labels: OS-Chrome OS-Linux OS-Windows
Status: Assigned (was: Untriaged)
Summary: Steady State Elisions does not work with ZeroSuggest (was: Omnibox single/double click does nothing)