New issue
Advanced search Search tips

Issue 836904 link

Starred by 2 users
Status: Assigned
Owner:
bpastene@chromium.org
Cc:
chrome-trooper-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Some swarming test failure are picked up as timeout

Project Member Reported by liaoyuke@chromium.org, Apr 25 2018 
For example, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/25600, browser_tests is purple, and the text shows "some shards did not complete: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9", which indicates that there is a timeout. However, if look at each individual swarming task, they are all test failures instead of timeout: https://chromium-swarm.appspot.com/task?id=3d1523af19404c10&refresh=10&show_raw=1

Comment 1 by bpastene@chromium.org, Apr 26 2018 

Probably related to the error:
WARNING:root:No shard json files found in task_output_dir: '/b/s/w/ir/tmp/tmpEn4xD6'

The tasks exited before they could write their output.json, and our task-merging logic thinks that it didn't run at all. We shouldn't be conflating "no json results" with "not having run at all".

Comment 2 by bpastene@chromium.org, Apr 26 2018

Owner: bpastene@chromium.org
Status: Assigned (was: Untriaged)
I 'spose I can take a stab at this if my shift allows time for it. Prob involves a fix to https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/swarming/resources/standard_gtest_merge.py

Comment 3 by jbudorick@chromium.org, Apr 26 2018 

We should also try to ensure that base/test/launcher emits something -- maybe an empty JSON -- in this case.

Comment 4 by bpastene@chromium.org, Apr 26 2018 

Eh, if it's got no results to report, it probably shouldn't be reporting results. Besides, *something* in the task can always go wrong before the json file gets created.

True and proper fix lies in the recipe's result collection IMO.
►

Sign in to add a comment