New issue
Advanced search Search tips

Issue 836888 link

Starred by 1 user
Status: Fixed
Owner:
dbertoni@chromium.org
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Typos in Extensions "getting started" example

Project Member Reported by dbertoni@chromium.org, Apr 25 2018 
There are a few typos in the markup for this example:

The word "details" is misspelled.
There is a semi-colon missing after the definition of the variable "kButtonColors" variable in the "options.js" snippet.
The file name for one of the graphics is misspelled as "click_detials.png"

It may not be worth it to rename the file.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e45547a3e00734bd44bc1cb4c37a5450f1dacd81

commit e45547a3e00734bd44bc1cb4c37a5450f1dacd81
Author: David Bertoni <dbertoni@chromium.org>
Date: Thu Apr 26 17:58:37 2018

Initial fixes for typos in getting started example.

Bug:  836888 
Change-Id: Id1993fb57c3880c597bf3e7d74d48c545d5b7fd6
Reviewed-on: https://chromium-review.googlesource.com/1029176
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554077}
[rename] https://crrev.com/e45547a3e00734bd44bc1cb4c37a5450f1dacd81/chrome/common/extensions/docs/static/images/get_started/click_details.png
[modify] https://crrev.com/e45547a3e00734bd44bc1cb4c37a5450f1dacd81/chrome/common/extensions/docs/templates/articles/getstarted.html

Comment 2 by dbertoni@chromium.org, May 2 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment