New issue
Advanced search Search tips

Issue 836867 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 667551



Sign in to add a comment

DCHECK failure when getting pixel dump that covers an OOPIF

Project Member Reported by lukasza@chromium.org, Apr 25 2018

Issue description

REPRO STEPS:

1. Add a layout test that triggers a pixel dump of an OOPIF.
   For example - one can patch in https://crrev.com/c/1028368

2. Run the test as follows:

    third_party/blink/tools/run_web_tests.py -t rel http/tests/cross-site-frame.html --no-retry --additional-drt-flag=--site-per-process

EXPECTED BEHAVIOR: The test passes

ACTUAL BEHAVIOR: Renderer hits a DCHECK failure and crashes:

    STDERR: [117889:117889:0425/094810.108590:FATAL:blink_test_runner.cc(653)] Check failed: 0 != snapshot.info().width() (0 vs. 0)
    STDERR: #0 0x7f2d9fb108fc base::debug::StackTrace::StackTrace()
    STDERR: #1 0x7f2d9fa524fb logging::LogMessage::~LogMessage()
    STDERR: #2 0x000000426f08 content::BlinkTestRunner::OnPixelsDumpCompleted()
    STDERR: #3 0x7f2d972c34da test_runner::(anonymous namespace)::CaptureCallback::DidCompositeAndReadback()
 
Blocking: 667551

Comment 2 by vmp...@chromium.org, Apr 25 2018

Labels: -Pri-3 Pri-2
Status: Started (was: Untriaged)

Comment 3 by vmp...@chromium.org, Apr 25 2018

Status: WontFix (was: Started)
This issue happens because it's trying to use the old pixel dump path with OOPIF pixel dumps, which doesn't work. The work we've been doing is behind a flag. So, if you pass

--additional-drt-flag=--enable-display-compositor-pixel-dump

then the test doesn't crash. It still fails, but it fails due to small pixel differences.

Sign in to add a comment