New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 836861 link

Starred by 2 users
Status: Verified
Owner:
qnnguyen@chromium.org
Closed: Jul 3
Cc:
atwilson@chromium.org
xiy...@chromium.org
r...@chromium.org
█ xiaoyinh@chromium.org
jamescook@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

No "Apps" button to manually launch kiosk apps on views login screen

Project Member Reported by jamescook@chromium.org, Apr 25 2018 
Add --enable-consumer-kiosk to flags on device
Login as owner
chrome://extensions
Click "Manage Kiosk Apps"
Add this app:
gaiepdgedkfcaiofonjkcampihgkcdmm  # mini browser
Sign out

Historically a button labeled "Apps" appeared in the lower-left. It exists today in webui lock screen but not views lock screen.

Xiyuan said this feature is deprecated, at least for new devices. Does it need to be supported for existing devices?

atwilson, can you confirm whether we need this? rkc, is this a known issue?

Comment 1 by jamescook@chromium.org, Apr 25 2018

Cc: xiy...@chromium.org
+xiyuan, we may need this after all

Comment 2 by xiy...@chromium.org, Apr 25 2018

Cc: jdufault@chromium.org
Labels: -Pri-2 M-68 Pri-1
Summary: No "Apps" button to manually launch kiosk apps on views login screen (was: No button for consumer kiosk apps on views login screen)
Yes, just realized the "Apps" menu is used for all manual kiosk launches, not just the consumer kiosk. It has a real use case in schools, where the test app is set to manual launch. Without the "Apps" menu, students will not be able to launch it.

We should fix this before launching views-based login.

Comment 3 by r...@chromium.org, Apr 25 2018

Cc: -jdufault@chromium.org jamescook@chromium.org atwilson@chromium.org
Owner: jdufault@chromium.org
This is a regression. If we want to remove this button, it should be a conscious choice, not a result of switching over to the views login :)

Assigning to Jacob to fix/re-assign.

Comment 4 by jdufault@chromium.org, Apr 25 2018

Labels: ReleaseBlock-Beta

Comment 5 by jdufault@chromium.org, Apr 25 2018

Cc: jdufault@chromium.org
Owner: xiaoyinh@chromium.org

Comment 6 by xiaoyinh@chromium.org, May 2 2018 

I discussed with Xiyuan offline and the work of this bug includes the following:
1. Reimplement the app_menu.js in views for the views login shelf to use. [1]
2. Add views equivalent impl for the backend code KioskAppMenuHandler. [2]
3. Some mojo api to communication ash and chrome.


[1]:https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/apps_menu.js?rcl=087dc44b3a439ee3c3cf42d28e30ebc0ed6bf790&l=9
[2]: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h?rcl=f97b7856bdac03db8f5ba0ae442b4e90d3cf5107&l=26

Comment 7 by xiaoyinh@chromium.org, May 14 2018

Labels: -M-68 M-69

Comment 8 by jdufault@chromium.org, May 17 2018

Owner: qnnguyen@chromium.org

Comment 9 by jdufault@chromium.org, May 17 2018

Cc: xiaoyinh@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac3dec55afe1739e21ae9d794c12b255f8643573

commit ac3dec55afe1739e21ae9d794c12b255f8643573
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Jun 05 10:42:22 2018

Add an Apps button for listing kiosk apps in Login screen.

This CL uses a debug button to load up mock kiosk app info. The code for
loading the kiosk apps from local storage will come in a later CL.

Bug:  836861 
Change-Id: Ic652a80b522b066380f593147c3f497e14082be0
Reviewed-on: https://chromium-review.googlesource.com/1080077
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564436}
[modify] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/ash_strings.grd
[add] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/ash_strings_grd/IDS_ASH_SHELF_APPS_BUTTON.png.sha1
[modify] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/login/ui/lock_debug_view.h
[modify] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/public/interfaces/kiosk_app_info.mojom
[modify] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/resources/vector_icons/shelf_apps_button.icon
[modify] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/shelf/login_shelf_view.h
[modify] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/ac3dec55afe1739e21ae9d794c12b255f8643573/ash/shelf/shelf_widget.h
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99a3e243f58070496a371ef66899da124eefd45e

commit 99a3e243f58070496a371ef66899da124eefd45e
Author: Lambros Lambrou <lambroslambrou@chromium.org>
Date: Tue Jun 05 18:59:06 2018

Revert "Add an Apps button for listing kiosk apps in Login screen."

This reverts commit ac3dec55afe1739e21ae9d794c12b255f8643573.

Reason for revert: Broke https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29
See  bug 849786 .

Original change's description:
> Add an Apps button for listing kiosk apps in Login screen.
> 
> This CL uses a debug button to load up mock kiosk app info. The code for
> loading the kiosk apps from local storage will come in a later CL.
> 
> Bug:  836861 
> Change-Id: Ic652a80b522b066380f593147c3f497e14082be0
> Reviewed-on: https://chromium-review.googlesource.com/1080077
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564436}

TBR=xiyuan@chromium.org,dcheng@chromium.org,oshima@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org

Change-Id: I513e263b0572c66d7224ca37bff730c4e1608f41
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  836861 
Reviewed-on: https://chromium-review.googlesource.com/1087611
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564601}
[modify] https://crrev.com/99a3e243f58070496a371ef66899da124eefd45e/ash/ash_strings.grd
[delete] https://crrev.com/39a55eba09e62c4087c7235c1a2d3b6cc3a39dbe/ash/ash_strings_grd/IDS_ASH_SHELF_APPS_BUTTON.png.sha1
[modify] https://crrev.com/99a3e243f58070496a371ef66899da124eefd45e/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/99a3e243f58070496a371ef66899da124eefd45e/ash/login/ui/lock_debug_view.h
[modify] https://crrev.com/99a3e243f58070496a371ef66899da124eefd45e/ash/public/interfaces/BUILD.gn
[delete] https://crrev.com/39a55eba09e62c4087c7235c1a2d3b6cc3a39dbe/ash/public/interfaces/kiosk_app_info.mojom
[modify] https://crrev.com/99a3e243f58070496a371ef66899da124eefd45e/ash/resources/vector_icons/BUILD.gn
[delete] https://crrev.com/39a55eba09e62c4087c7235c1a2d3b6cc3a39dbe/ash/resources/vector_icons/shelf_apps_button.icon
[modify] https://crrev.com/99a3e243f58070496a371ef66899da124eefd45e/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/99a3e243f58070496a371ef66899da124eefd45e/ash/shelf/login_shelf_view.h
[modify] https://crrev.com/99a3e243f58070496a371ef66899da124eefd45e/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/99a3e243f58070496a371ef66899da124eefd45e/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/99a3e243f58070496a371ef66899da124eefd45e/ash/shelf/shelf_widget.h
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42082b546fa09c292414976a4d285dd6ea876d86

commit 42082b546fa09c292414976a4d285dd6ea876d86
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Jun 05 21:23:42 2018

Reland "Add an Apps button for listing kiosk apps in Login screen."

This reverts commit 99a3e243f58070496a371ef66899da124eefd45e.

Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1080077

TBR=dcheng@chromium.org

Bug:  836861 
Change-Id: Ic58e155d4dec32d81772f241c02fd8ad732ea234
Reviewed-on: https://chromium-review.googlesource.com/1087667
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564668}
[modify] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/ash_strings.grd
[add] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/ash_strings_grd/IDS_ASH_SHELF_APPS_BUTTON.png.sha1
[modify] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/login/ui/lock_debug_view.h
[modify] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/public/interfaces/kiosk_app_info.mojom
[modify] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/resources/vector_icons/shelf_apps_button.icon
[modify] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/shelf/login_shelf_view.h
[modify] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/42082b546fa09c292414976a4d285dd6ea876d86/ash/shelf/shelf_widget.h
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4

commit d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Jun 19 19:20:32 2018

Launch kiosk apps from Login screen "Apps" menu.

Bug:  836861 
Change-Id: Ib480dfa25b45a1cc6dd1424e8f84d0891eec1a0e
Reviewed-on: https://chromium-review.googlesource.com/1092095
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568560}
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/ash/login/login_screen_controller.cc
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/ash/login/login_screen_controller.h
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/ash/login/ui/login_keyboard_test_base.cc
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/chromeos/login/app_launch_controller.cc
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/chromeos/login/app_launch_controller.h
[add] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/chromeos/login/ui/kiosk_app_menu_updater.cc
[add] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/chromeos/login/ui/kiosk_app_menu_updater.h
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.h
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/d09dd1172c8cb1a5e73996f0da0be0f4a653a5c4/chrome/browser/ui/ash/login_screen_client.h
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3c54cfe39a2eac98f8223c57a45e52d804aa247

commit a3c54cfe39a2eac98f8223c57a45e52d804aa247
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Jul 03 17:56:50 2018

Implement ARC kiosk app launcher.

Also includes a run of "git cl format --js" on display_manager.js,
and a fix for splash screens not stretching to the full screen.

Bug:  836861 
Change-Id: Icfe750f9d743b9608e120fc02f8cf16228be5c8f
Reviewed-on: https://chromium-review.googlesource.com/1115977
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572288}
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/ash/login/login_screen_controller.cc
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/ash/login/login_screen_controller.h
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/ash/public/interfaces/kiosk_app_info.mojom
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/chrome/browser/chromeos/login/app_launch_controller.cc
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/chrome/browser/chromeos/login/arc_kiosk_controller.cc
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/chrome/browser/chromeos/login/ui/kiosk_app_menu_updater.cc
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/chrome/browser/chromeos/login/ui/kiosk_app_menu_updater.h
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.h
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/chrome/browser/ui/ash/login_screen_client.h
[modify] https://crrev.com/a3c54cfe39a2eac98f8223c57a45e52d804aa247/ui/login/display_manager.js

Comment 16 by qnnguyen@chromium.org, Jul 3

Status: Fixed (was: Assigned)
With this merge, we should now have a fully functional kiosk "Apps" button for manual launch.

Comment 17 by vaandres@chromium.org, Jul 11

Labels: cros-veri
Since consumer mode kiosk is now deprecated. Does this merge, fix the issue of "no apps launcher" for devices that are currently configured for consumer kiosk?

Comment 18 by vaandres@chromium.org, Jul 23

Status: Verified (was: Fixed)
►

Sign in to add a comment