Issue metadata
Sign in to add a comment
|
Position location bar correctly in regular width in fullscreen |
||||||||||||||||||||||
Issue descriptionCurrently on iPhone in landscape or on iPad, when scrolled away, the location bar is cut off at the top. It should be centered inside of the (smaller) toolbar. I think the size is correct but the position isn't, and possibly the height of the fullscreen toolbar is too small. We don't really have a spec for this, I think, so CC Martijn and Pete.
,
May 9 2018
,
May 9 2018
Assigning to Pete for specs for the location bar height and vertical position on landscape fullscreen.
,
May 18 2018
,
May 31 2018
## Specs for all size classes - Make sure you are using the omnibox_connection*.png assets found here: https://drive.google.com/open?id=1SCEI15MXVkeWtjrqz6LQRR3S0JhYz0bH - don't scale the icon - font-size: scale by 0.79 (roughly 15pt) - vertical position (assuming icon + label in same inherit width/height parent view): V:|-2-[groupedViews]-| and vertically centered in Any x Compact size class
,
Jun 18 2018
Could you please elaborate on the last point? I don't really understand: - vertical position (assuming icon + label in same inherit width/height parent view): V:|-2-[groupedViews]-| and vertically centered in Any x Compact size class And then please reassign to Gauthier, it seems like this needs to be fixed in toolbar
,
Jun 19 2018
Sorry. Just center the view (icon + label) horizontally and center it vertically in the space between the bottom edge of the status bar (if it exists) and the bottom edge of the toolbar background. https://screenshot.googleplex.com/M6qXorsfeup
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2f527095a8d88ce072dcb9a862a50677b7a37b9 commit f2f527095a8d88ce072dcb9a862a50677b7a37b9 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Jun 20 08:48:46 2018 Change vertical alignment of the collapsed toolbar This CL changes the vertical constraints of the collapsed toolbar to have the location bar displayed in the middle of the collapsed toolbar by changing the constraint to position its bottom anchor. Bug: 836817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I35ad32681a820b8480ecec76e825defc4c0aa2ef Reviewed-on: https://chromium-review.googlesource.com/1107061 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568768} [modify] https://crrev.com/f2f527095a8d88ce072dcb9a862a50677b7a37b9/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
,
Jun 20 2018
,
Jun 20 2018
The NextAction date has arrived: 2018-06-20
,
Jun 26 2018
Verified in 69.0.3473.0 Canary, iPhone X iOS 11.4, iPad Air iOS11.4 Looks good. https://drive.google.com/file/d/1yFnnFVzmTnVrbPq9L7SB1jut_z_oUWFW/view |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gambard@chromium.org
, Apr 25 2018