Omnibox has no Cancel button when rotating to landscape, defocusing, then rotating back |
||||
Issue descriptionSteps to repro: 0. Use UI Refresh flag. Use an iPhone. 1. Rotate to landscape 2. Focus omnibox 3. Scroll the popup so that the popup is still on screen, but the omnibox is not the first responder 4. Rotate to portrait Observe that the Cancel button is not displayed, so there seems to be no way to exit this state. Workaround: focus the omnibox and defocus it again, the cancel button will appear. Or just use any of the suggestions or focus and hit return on the keyboard.
,
Apr 26 2018
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9327148ca68b5094eee729424dcb03c83b6a2dad commit 9327148ca68b5094eee729424dcb03c83b6a2dad Author: Gauthier Ambard <gambard@chromium.org> Date: Thu May 17 15:01:54 2018 Show cancel button when the omnibox is focused This CL shows the cancel button when the omnibox is focused on portrait. The omnibox can be focused and not the first responder when the user taps the omnibox, display some suggestions, scroll the suggestions. The correct check to know if the omnibox is focused is if it is showing the popup or if it is first responder. Bug: 836814 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2d021154f033c81ddde731163c813eb850a973bd Reviewed-on: https://chromium-review.googlesource.com/1064113 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#559536} [modify] https://crrev.com/9327148ca68b5094eee729424dcb03c83b6a2dad/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
,
May 17 2018
,
May 22 2018
gambard@ We tried to verify the bug following the steps mentioned in comment#0, but we are not clear at step#3 could you please explain so that we can verify the bug. Thanks!
,
May 22 2018
Verified in: App Version: 68.0.3437.0 canary Devices: iPhone 6S Plus, iPhone 8 iOS Versions: 10.3.3, 11.2.6 Cancel button is displayed at omnibox when device is rotated to portrait Video: https://drive.google.com/open?id=17kiiDd0hSZQ6Uk_9AZADS6F2gUBo-47z
,
May 22 2018
The video you sent is the correct behavior for step 3, thanks. I should have been more explicit, sorry! |
||||
►
Sign in to add a comment |
||||
Comment 1 by gambard@chromium.org
, Apr 25 2018