Improvements on transparency for AEC3 under stationary noises at the farend side |
|||
Issue descriptionHigh stationary noises present in the farend signal makes the echo suppressor in AEC3 too aggressive. An improve in transparency in those scenarios is desired.
,
Apr 25 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/dc872b6be1827e5adc40a0318c17197e0fdbe06f commit dc872b6be1827e5adc40a0318c17197e0fdbe06f Author: Jesús de Vicente Peña <devicentepena@webrtc.org> Date: Wed Apr 25 16:19:43 2018 AEC3: Audibility: improvements on the initial noise estimation Bug: webrtc:9193 , chromium:836790 Change-Id: I589082a18a4a5d1ba5abc170b6cf49d1f545b6cc Reviewed-on: https://webrtc-review.googlesource.com/72480 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23027} [modify] https://crrev.com/dc872b6be1827e5adc40a0318c17197e0fdbe06f/modules/audio_processing/aec3/aec_state.cc [modify] https://crrev.com/dc872b6be1827e5adc40a0318c17197e0fdbe06f/modules/audio_processing/aec3/echo_audibility.cc [modify] https://crrev.com/dc872b6be1827e5adc40a0318c17197e0fdbe06f/modules/audio_processing/aec3/echo_audibility.h [modify] https://crrev.com/dc872b6be1827e5adc40a0318c17197e0fdbe06f/modules/audio_processing/aec3/render_buffer.h [modify] https://crrev.com/dc872b6be1827e5adc40a0318c17197e0fdbe06f/modules/audio_processing/aec3/stationarity_estimator.cc [modify] https://crrev.com/dc872b6be1827e5adc40a0318c17197e0fdbe06f/modules/audio_processing/aec3/stationarity_estimator.h
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1780022b576bc42676a8ab1a070ddf19b4189dac commit 1780022b576bc42676a8ab1a070ddf19b4189dac Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Apr 25 17:12:35 2018 Roll src/third_party/webrtc/ 09408115c..ff61273c0 (9 commits) https://webrtc.googlesource.com/src.git/+log/09408115cda7..ff61273c010c $ git log 09408115c..ff61273c0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:836790 ,chromium:None,chromium:836729,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icfa9b26e7de7db99d2c8f985b198097bb7805e49 Reviewed-on: https://chromium-review.googlesource.com/1028222 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553610} [modify] https://crrev.com/1780022b576bc42676a8ab1a070ddf19b4189dac/DEPS
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bed49f3ea231eb857732fd593f74ac97657017e commit 6bed49f3ea231eb857732fd593f74ac97657017e Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 26 18:49:13 2018 Roll src/third_party/webrtc/ ff61273c0..775d07e27 (6 commits) https://webrtc.googlesource.com/src.git/+log/ff61273c010c..775d07e27769 $ git log ff61273c0..775d07e27 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:835637,chromium:None,chromium:836790 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibba9cc2f30a1452da6abcf7b3dfe64a8a91376e8 Reviewed-on: https://chromium-review.googlesource.com/1030627 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554100} [modify] https://crrev.com/6bed49f3ea231eb857732fd593f74ac97657017e/DEPS
,
Apr 30 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/95581927115711dad49d5962387282f1394f6176 commit 95581927115711dad49d5962387282f1394f6176 Author: Jesús de Vicente Peña <devicentepena@webrtc.org> Date: Mon Apr 30 09:03:19 2018 AEC3: Removing the need of a buffer for the stationarity estimator of the render signal. Change-Id: I6983e1d8bdd048a5d92209e3023c687f82d383d5 Bug: webrtc:9193 , chromium:836790 Change-Id: I6983e1d8bdd048a5d92209e3023c687f82d383d5 Reviewed-on: https://webrtc-review.googlesource.com/72760 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23065} [modify] https://crrev.com/95581927115711dad49d5962387282f1394f6176/modules/audio_processing/aec3/echo_audibility.cc [modify] https://crrev.com/95581927115711dad49d5962387282f1394f6176/modules/audio_processing/aec3/echo_audibility.h [modify] https://crrev.com/95581927115711dad49d5962387282f1394f6176/modules/audio_processing/aec3/render_buffer.h [modify] https://crrev.com/95581927115711dad49d5962387282f1394f6176/modules/audio_processing/aec3/stationarity_estimator.cc [modify] https://crrev.com/95581927115711dad49d5962387282f1394f6176/modules/audio_processing/aec3/stationarity_estimator.h
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eb728dccb9bc243a21dbe6327c9ab93ba7804a9 commit 3eb728dccb9bc243a21dbe6327c9ab93ba7804a9 Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Apr 30 14:57:20 2018 Roll src/third_party/webrtc/ 28899d079..f22550175 (2 commits) https://webrtc.googlesource.com/src.git/+log/28899d0791c4..f22550175b96 $ git log 28899d079..f22550175 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:836790 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I26166138cbd471259278d52ced61cd964ba3075b Reviewed-on: https://chromium-review.googlesource.com/1034462 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554751} [modify] https://crrev.com/3eb728dccb9bc243a21dbe6327c9ab93ba7804a9/DEPS
,
Apr 30 2018
,
May 2 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/2f2633d90c3ec0f0b42f5270d9a65987ff93f962 commit 2f2633d90c3ec0f0b42f5270d9a65987ff93f962 Author: Jesús de Vicente Peña <devicentepena@webrtc.org> Date: Wed May 02 10:19:46 2018 AEC3: Audility: Avoid the initialization of the noise estimator in pure zeroes signals at the render. Bug: webrtc:9193 , chromium:836790 Change-Id: Ic162dd72947f1d075b55df6725a17b66c782930a Reviewed-on: https://webrtc-review.googlesource.com/73200 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23075} [modify] https://crrev.com/2f2633d90c3ec0f0b42f5270d9a65987ff93f962/modules/audio_processing/aec3/aec_state.cc [modify] https://crrev.com/2f2633d90c3ec0f0b42f5270d9a65987ff93f962/modules/audio_processing/aec3/echo_audibility.cc [modify] https://crrev.com/2f2633d90c3ec0f0b42f5270d9a65987ff93f962/modules/audio_processing/aec3/echo_audibility.h [modify] https://crrev.com/2f2633d90c3ec0f0b42f5270d9a65987ff93f962/modules/audio_processing/aec3/render_buffer.h
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/087dc44b3a439ee3c3cf42d28e30ebc0ed6bf790 commit 087dc44b3a439ee3c3cf42d28e30ebc0ed6bf790 Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 02 18:31:08 2018 Roll src/third_party/webrtc/ 878a3df8a..2a35c4377 (9 commits) https://webrtc.googlesource.com/src.git/+log/878a3df8a25d..2a35c43779f6 $ git log 878a3df8a..2a35c4377 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none,chromium:836790,chromium:none,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2d9ffa08d725ed51ad90bd7df30e4c98c9296796 Reviewed-on: https://chromium-review.googlesource.com/1039779 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555477} [modify] https://crrev.com/087dc44b3a439ee3c3cf42d28e30ebc0ed6bf790/DEPS
,
May 4 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/65ddf07219d3a40ed336e9521b54b1ed72f0ada9 commit 65ddf07219d3a40ed336e9521b54b1ed72f0ada9 Author: Jesús de Vicente Peña <devicentepena@webrtc.org> Date: Fri May 04 09:14:24 2018 AEC3: not applying noise gating when using the stationarity properties of the render signal Bug: webrtc:9193 , chromium:836790 Change-Id: I87ded1d33869037420c435155bd084f6fc3efdb0 Reviewed-on: https://webrtc-review.googlesource.com/73740 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23111} [modify] https://crrev.com/65ddf07219d3a40ed336e9521b54b1ed72f0ada9/modules/audio_processing/aec3/residual_echo_estimator.cc [modify] https://crrev.com/65ddf07219d3a40ed336e9521b54b1ed72f0ada9/modules/audio_processing/aec3/residual_echo_estimator.h
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db2fcf631b675eca1c62d6d102a8108a928c51c2 commit db2fcf631b675eca1c62d6d102a8108a928c51c2 Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 04 14:45:09 2018 Roll src/third_party/webrtc/ a1f566b28..9d96e9231 (14 commits) https://webrtc.googlesource.com/src.git/+log/a1f566b28a69..9d96e923169d $ git log a1f566b28..9d96e9231 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:839379,chromium:836790,chromium:839351,chromium:637666,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idaf4dcb114cbe96a981c6eba39aab8a3be42c19b Reviewed-on: https://chromium-review.googlesource.com/1044265 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556050} [modify] https://crrev.com/db2fcf631b675eca1c62d6d102a8108a928c51c2/DEPS
,
May 16 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/90e3fbdd37005ebaecf688cbcf7ad0054334254d commit 90e3fbdd37005ebaecf688cbcf7ad0054334254d Author: Per Åhgren <peah@webrtc.org> Date: Wed May 16 16:47:16 2018 Activating the AEC3 audibility improvements functionality This CL turns on the previously implemented AEC3 audibility improvements, which before has been off by default. Bug: webrtc:9193 , chromium:836790 Change-Id: Ibcd057ba5dd002718d62fd83db33d01d9563b8ea Reviewed-on: https://webrtc-review.googlesource.com/77123 Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23265} [modify] https://crrev.com/90e3fbdd37005ebaecf688cbcf7ad0054334254d/api/audio/echo_canceller3_config.h [modify] https://crrev.com/90e3fbdd37005ebaecf688cbcf7ad0054334254d/modules/audio_processing/aec3/aec_state.cc [modify] https://crrev.com/90e3fbdd37005ebaecf688cbcf7ad0054334254d/modules/audio_processing/aec3/aec_state.h
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a37b9be2202fae823677bd09849dd7a3be506b7d commit a37b9be2202fae823677bd09849dd7a3be506b7d Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 17 18:08:33 2018 Roll src/third_party/webrtc/ ef75ebef5..f8d8d6d00 (39 commits) https://webrtc.googlesource.com/src.git/+log/ef75ebef5520..f8d8d6d00c16 $ git log ef75ebef5..f8d8d6d00 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:840536 ,chromium:755660,chromium:755660,chromium:755660,chromium:None,chromium:None,chromium:None,chromium:None,chromium:836790,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iec936924677ed8093fba2631fdef8a0041ad403c Reviewed-on: https://chromium-review.googlesource.com/1064318 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559607} [modify] https://crrev.com/a37b9be2202fae823677bd09849dd7a3be506b7d/DEPS
,
May 28 2018
Is this finished?
,
Jun 14 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 25 2018