"Aww snap" page seen after background fetch completes |
||
Issue descriptionHere's the relevant part of the stack: 1:16:0425/132814.551841:FATAL:v8_initializer.cc(661)] #0 0x7f5beea2e9cd base::debug::StackTrace::StackTrace() #1 0x7f5bee75953c base::debug::StackTrace::StackTrace() #2 0x7f5bee7caeea logging::LogMessage::~LogMessage() #3 0x7f5bd8292361 blink::ReportFatalErrorInWorker() #4 0x7f5bdab3dae1 v8::Utils::ReportApiFailure() #5 0x7f5bdb00b639 v8::internal::HandleScope::Extend() #6 0x7f5bdab41f80 v8::HandleScope::CreateHandle() #7 0x7f5bd81e97e9 blink::ScopedPersistent<>::NewLocal() #8 0x7f5bd81e8c13 blink::ScriptState::GetContext() #9 0x7f5bd82e4b1c blink::ToV8<>() #10 0x7f5bd8befe8e blink::Request::RefreshBody() #11 0x7f5bd8bf06e6 blink::Request::Request() #12 0x7f5bd8bf0822 blink::Request::Request() #13 0x7f5bd8bf0551 blink::Request::Create() #14 0x7f5bd4d6aabc blink::BackgroundFetchSettledFetches::BackgroundFetchSettledFetches() #15 0x7f5bd517ce43 blink::BackgroundFetchSettledFetches::Create() #16 0x7f5bd5178020 blink::ServiceWorkerGlobalScopeProxy::DispatchBackgroundFetchedEvent() #17 0x7f5be9965822 content::ServiceWorkerContextClient::DispatchBackgroundFetchedEvent() #18 0x7f5be740798a content::mojom::ServiceWorkerEventDispatcherStubDispatch::AcceptWithResponder() #19 0x7f5be996e740 content::mojom::ServiceWorkerEventDispatcherStub<>::AcceptWithResponder() We shouldn't be calling blink::BackgroundFetchSettledFetches::Create() in this codepath yet. This code needs updating: https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc?rcl=f0e112939eebd94cc8af51216fa5ed367250239b&l=219 Discussed with Rayan, he'll send a patch shortly.
,
Apr 30 2018
This seems to be fixed now, closing
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fe5e343eb0a9f692d46dd48d22a5062854c9c99 commit 6fe5e343eb0a9f692d46dd48d22a5062854c9c99 Author: Rayan Kanso <rayankans@chromium.org> Date: Wed May 30 20:33:18 2018 [Background Fetch] Add ScriptState::Scope to event dispatchers Calling ToV8 is causing crashes due to missing ScriptState::Scope. Bug: 836787 Change-Id: I96cd831e13989b4b58d7bb10f97939a01af50976 Reviewed-on: https://chromium-review.googlesource.com/1078819 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#562981} [modify] https://crrev.com/6fe5e343eb0a9f692d46dd48d22a5062854c9c99/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4eeb912e2934fb1ea6285f2d725ce92a2e5609b5 commit 4eeb912e2934fb1ea6285f2d725ce92a2e5609b5 Author: Rayan Kanso <rayankans@chromium.org> Date: Thu May 31 18:17:44 2018 Update comments about the unused ScriptState::Scope variable. Bug: 836787 Change-Id: If926389721e29f806ae9c275c61fdaa7c87b287c Reviewed-on: https://chromium-review.googlesource.com/1080553 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#563322} [modify] https://crrev.com/4eeb912e2934fb1ea6285f2d725ce92a2e5609b5/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Apr 25 2018