Issue metadata
Sign in to add a comment
|
Bad aura scale factors |
||||||||||||||||||
Issue description
Chrome OS builds of chrome return bad scales from aura shell interface.
To repro:
1. build chrome and wayland_info_client with target_os = "chromeos" and use_xkbcommon = true
2. run chrome with: chrome --enable-wayland-server
3. while chrome is running, run info client 'wayland_info_client.
Here's the output in ToT chrome:
OUTPUT0:
connection: internal
device scale factor: 1.000
geometry:
x: 0
y: 0
physical width: 361 mm
physical height: 202 mm
subpixel: unknown
make: unknown
model: unknown
transform: normal
modes:
1366x768: 60.00 Hz current preferred
scales:
unknown (0):
unknown (0):
unknown (0):
1.000: current preferred
1.000: current preferred
1.000: current preferred
1.000: current preferred
1.000: current preferred
1.000: current preferred
Those scales are of course completely wrong. 0 is not a valid value and there shouldn't be more than one 1.0 value. Rounding error?
,
Apr 25 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e24cbe8a0ed6a7b9d96dc34560c8909ad75d2764 commit e24cbe8a0ed6a7b9d96dc34560c8909ad75d2764 Author: Malay Keshav <malaykeshav@chromium.org> Date: Wed Apr 25 16:03:35 2018 Replaces uint32_t with double when working with scales Zoom factors are double, but the code is using uint32_t to process them. This patch fixes it. Output on wayland info client: OUTPUT0: connection: internal device scale factor: 1.000 geometry: x: 2 y: 24 physical width: 443 mm physical height: 264 mm subpixel: unknown make: unknown model: unknown transform: normal modes: 1676x998: 60.00 Hz current preferred scales: 0.500: 0.750: 1.000: current preferred 1.250: 1.500: 1.750: 2.000: 2.250: 2.500: Bug: 836782 Change-Id: Id67582a637a67a608ae096a5fac992e8215aa47e Component: Wayland, aura shell, scales Reviewed-on: https://chromium-review.googlesource.com/1028217 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#553586} [modify] https://crrev.com/e24cbe8a0ed6a7b9d96dc34560c8909ad75d2764/components/exo/wayland/server.cc
,
Apr 25 2018
,
Apr 26 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de83a6598d75ecd8e205cd367cc706a54b8ceec7 commit de83a6598d75ecd8e205cd367cc706a54b8ceec7 Author: Malay Keshav <malaykeshav@chromium.org> Date: Thu Apr 26 17:21:36 2018 (merge) Replaces uint32_t with double when working with scales Merge to M67 Zoom factors are double, but the code is using uint32_t to process them. This patch fixes it. Output on wayland info client: OUTPUT0: connection: internal device scale factor: 1.000 geometry: x: 2 y: 24 physical width: 443 mm physical height: 264 mm subpixel: unknown make: unknown model: unknown transform: normal modes: 1676x998: 60.00 Hz current preferred scales: 0.500: 0.750: 1.000: current preferred 1.250: 1.500: 1.750: 2.000: 2.250: 2.500: Bug: 836782 Change-Id: Id67582a637a67a608ae096a5fac992e8215aa47e Component: Wayland, aura shell, scales Reviewed-on: https://chromium-review.googlesource.com/1028217 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#553586}(cherry picked from commit e24cbe8a0ed6a7b9d96dc34560c8909ad75d2764) Reviewed-on: https://chromium-review.googlesource.com/1030771 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#328} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/de83a6598d75ecd8e205cd367cc706a54b8ceec7/components/exo/wayland/server.cc
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8b31738765d8039105adf2b1c6f7c8e266e4033 commit f8b31738765d8039105adf2b1c6f7c8e266e4033 Author: Malay Keshav <malaykeshav@chromium.org> Date: Thu Apr 26 17:30:50 2018 Revert "(merge) Replaces uint32_t with double when working with scales" This reverts commit de83a6598d75ecd8e205cd367cc706a54b8ceec7. Reason for revert: A parent CL (36412d77e4e8a7d5b6d06d8f2861412c007c65ef) needs to be reverted and this cl is in conflict of that. Original change's description: > (merge) Replaces uint32_t with double when working with scales > > Merge to M67 > Zoom factors are double, but the code is using uint32_t to process them. > This patch fixes it. > > Output on wayland info client: > OUTPUT0: > > connection: internal > device scale factor: 1.000 > > geometry: > x: 2 > y: 24 > physical width: 443 mm > physical height: 264 mm > subpixel: unknown > make: unknown > model: unknown > transform: normal > > modes: > 1676x998: 60.00 Hz current preferred > > scales: > 0.500: > 0.750: > 1.000: current preferred > 1.250: > 1.500: > 1.750: > 2.000: > 2.250: > 2.500: > > Bug: 836782 > Change-Id: Id67582a637a67a608ae096a5fac992e8215aa47e > Component: Wayland, aura shell, scales > Reviewed-on: https://chromium-review.googlesource.com/1028217 > Reviewed-by: David Reveman <reveman@chromium.org> > Commit-Queue: Malay Keshav <malaykeshav@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#553586}(cherry picked from commit e24cbe8a0ed6a7b9d96dc34560c8909ad75d2764) > Reviewed-on: https://chromium-review.googlesource.com/1030771 > Reviewed-by: Malay Keshav <malaykeshav@chromium.org> > Cr-Commit-Position: refs/branch-heads/3396@{#328} > Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} TBR=malaykeshav@chromium.org Change-Id: I47d57e54969b83684277b1ae17e998cbacedfbc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836782 Reviewed-on: https://chromium-review.googlesource.com/1030576 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#330} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/f8b31738765d8039105adf2b1c6f7c8e266e4033/components/exo/wayland/server.cc
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe1b86dad196c89d2bed8ab6143c79dd8fd845ad commit fe1b86dad196c89d2bed8ab6143c79dd8fd845ad Author: Malay Keshav <malaykeshav@chromium.org> Date: Thu Apr 26 21:47:58 2018 Fix more rounding errors due to double-float typecasting This patch fixes some more rounding errors due to double comparison with a float. It also adds some more missing out scale factors that might be possible. Bug: 836782 Change-Id: Ib2ca622ac2c53aa354dd890ede45532380a733d1 Component: wayland, aura shell, scales, zoom Reviewed-on: https://chromium-review.googlesource.com/1031015 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#554154} [modify] https://crrev.com/fe1b86dad196c89d2bed8ab6143c79dd8fd845ad/components/exo/wayland/clients/info.cc [modify] https://crrev.com/fe1b86dad196c89d2bed8ab6143c79dd8fd845ad/components/exo/wayland/protocol/aura-shell.xml [modify] https://crrev.com/fe1b86dad196c89d2bed8ab6143c79dd8fd845ad/components/exo/wayland/public/aura-shell-client-protocol.h [modify] https://crrev.com/fe1b86dad196c89d2bed8ab6143c79dd8fd845ad/components/exo/wayland/public/aura-shell-server-protocol.h [modify] https://crrev.com/fe1b86dad196c89d2bed8ab6143c79dd8fd845ad/components/exo/wayland/server.cc
,
Apr 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f023073f0d6570ae15cf812e95bef80b588956d6 commit f023073f0d6570ae15cf812e95bef80b588956d6 Author: Malay Keshav <malaykeshav@chromium.org> Date: Sat Apr 28 01:35:10 2018 (merge M67) Fix more rounding errors due to double-float typecasting This patch fixes some more rounding errors due to double comparison with a float. It also adds some more missing out scale factors that might be possible. Bug: 836782 Change-Id: I4d1423975bbc68d89e92e3fcda57b2d85abf4b30 Component: wayland, aura shell, scales, zoom Reviewed-on: https://chromium-review.googlesource.com/1031015 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#554154} Reviewed-on: https://chromium-review.googlesource.com/1033953 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#366} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/f023073f0d6570ae15cf812e95bef80b588956d6/components/exo/wayland/clients/info.cc [modify] https://crrev.com/f023073f0d6570ae15cf812e95bef80b588956d6/components/exo/wayland/protocol/aura-shell.xml [modify] https://crrev.com/f023073f0d6570ae15cf812e95bef80b588956d6/components/exo/wayland/public/aura-shell-client-protocol.h [modify] https://crrev.com/f023073f0d6570ae15cf812e95bef80b588956d6/components/exo/wayland/public/aura-shell-server-protocol.h [modify] https://crrev.com/f023073f0d6570ae15cf812e95bef80b588956d6/components/exo/wayland/server.cc |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by reve...@chromium.org
, Apr 25 2018