Issue metadata
Sign in to add a comment
|
Failing to load websocket.sub.js in test external/wpt/websockets/...case-insensitive.any.js f on Win7 Tests (dbg) |
||||||||||||||||||||||||
Issue descriptionIt's failing on Win7 Tests (dbg) bots because CreateWebSocketWithRepeatedProtocolsCaseInsensitive() is not defined. But the other bots are green...? Example failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/68664 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/68665 The diff: --- e:\b\s\w\ioz8py4d\layout-test-results\external/wpt/websockets/Create-protocols-repeated-case-insensitive.any-expected.txt +++ e:\b\s\w\ioz8py4d\layout-test-results\external/wpt/websockets/Create-protocols-repeated-case-insensitive.any-actual.txt @@ -1,4 +1,4 @@ This is a testharness.js-based test. -FAIL W3C WebSocket API - Create WebSocket - Pass a valid URL and an array of protocol strings with repeated values but different case - SYNTAX_ERR is thrown assert_throws: function "function () { wsocket = CreateWebSocketWithRepeatedProtocolsCaseInsensitive() }" threw object "ReferenceError: CreateWebSocketWithRepeatedProtocolsCaseInsensitive is not defined" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12 +FAIL W3C WebSocket API - Create WebSocket - Pass a valid URL and an array of protocol strings with repeated values but different case - SYNTAX_ERR is thrown assert_throws: function "function () { wsocket = CreateWebSocketWithRepeatedProtocolsCaseInsensitive() }" did not throw Harness: the test ran to completion.
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afb3f3d42b4ddd3403b2c23a6328ab4513e2e622 commit afb3f3d42b4ddd3403b2c23a6328ab4513e2e622 Author: Henrik Boström <hbos@chromium.org> Date: Wed Apr 25 11:16:42 2018 Allow Create-protocols-repeated-case-insensitive.any.js to fail on Win7 See https://crbug.com/836763 TBR=qyearsley@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836763 Change-Id: I91e1edb6e7fac3aa3957b2ac0c20fc25d628be7d Reviewed-on: https://chromium-review.googlesource.com/1027850 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553512} [modify] https://crrev.com/afb3f3d42b4ddd3403b2c23a6328ab4513e2e622/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 25 2018
,
Apr 27 2018
CreateWebSocketWithRepeatedProtocolsCaseInsensitive() is defined in https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/websockets/websocket.sub.js although that doesn't really explain what's going on.
,
Apr 27 2018
This seems suspiciously similar to bug 837213 (because they both involve wptserve pipes). CC Robert since it's possible that they're related, so if you learn something about those failures, then maybe that's related to this. If it *is* a wptserve bug, I wonder if anybody else that runs web-platform-tests is affected, or if there is a bug upstream. (Unassigning since I'm not actually familiar with this and don't plan to investigate soon; my name is probably associated with it in blame because I ran the wpt import script earlier.)
,
Apr 27 2018
I believe this is issue 837213 , which should be resolved soon (just found the suspected culprit in the upstream and planning to revert). Sorry for the trouble.
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f648d48b5309253d4390a7e0b67f16f2a41ffaab commit f648d48b5309253d4390a7e0b67f16f2a41ffaab Author: Robert Ma <robertma@chromium.org> Date: Tue May 01 17:34:54 2018 Remove a few expectations as the bug has been fixed The 500 (IndexError) issue of wptserve has been fixed at r555035, so we can remove all the related temporary expectations. Also remove some redundant and incorrect baseline files which were created because of the flake caused by the wptserve bug. TBR=foolip Bug: 837213 , 836627 , 836763 Change-Id: Icbba544e32d2709c38083fc27528050e3107cf23 Reviewed-on: https://chromium-review.googlesource.com/1037204 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#555093} [modify] https://crrev.com/f648d48b5309253d4390a7e0b67f16f2a41ffaab/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/d52a786549ed36ca97892e14d3897970cd3e92bb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/external/wpt/content-security-policy/inside-worker/dedicated-script-expected.txt [delete] https://crrev.com/d52a786549ed36ca97892e14d3897970cd3e92bb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/content-security-policy/inside-worker/dedicated-script-expected.txt [delete] https://crrev.com/d52a786549ed36ca97892e14d3897970cd3e92bb/third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/content-security-policy/inside-worker/dedicated-script-expected.txt [delete] https://crrev.com/d52a786549ed36ca97892e14d3897970cd3e92bb/third_party/WebKit/LayoutTests/platform/mac/external/wpt/content-security-policy/inside-worker/dedicated-script-expected.txt |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by hbos@chromium.org
, Apr 25 2018Status: Assigned (was: Untriaged)