Issue metadata
Sign in to add a comment
|
Regression : Entered query overlaps with 'Google Search' placeholder text in omnibox.
Reported by
avsha...@etouch.net,
Apr 25 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 68.0.3406.0 (Official Build) 80672a4583963b6aa35cb10e9c629bb8638057c2-refs/heads/master@{#553301} 32/64-bit OS : Windows(7,8,8.1,10), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://version page. 2. Hit Ctrl + A to select text on the page and press Ctrl + C to copy it. 3. Paste copied text in omnibox and observe. Actual Result : Entered query overlaps with 'Google Search' placeholder text in omnibox. Expected Result : Query text and 'Google Search' placeholder text should not overlap with each other in omnibox. (Getting 'No enough builds..' error while performing bisect with per-revision script hence providing the bisect using old script) This is a regression issue, broken in M-68 and providing the bisect using old script: Good Build : 68.0.3398.0 (Revision : 551179) Bad Build : 68.0.3399.0 (Revision : 551554) Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/1f4382b7fc13da2ec7563f7cd5556802d8794355..256d8bced2090252eb5524fb302716c17c4b513b?pretty=fuller&n=10000 Suspecting : r551475 @Dave : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. Issue is not reproducible on Mac(10.12.6, 10.13.1, 10.13.5) OS.
,
May 1 2018
,
May 1 2018
CL at https://chromium-review.googlesource.com/c/chromium/src/+/1038618
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b116a6d0e5b256577c2cc298c6d8a1c254ac14a8 commit b116a6d0e5b256577c2cc298c6d8a1c254ac14a8 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed May 02 18:35:28 2018 [Omnibox] Fix ellipses and remove description when it doesn't fit This CL passes the correct available width to ComputeMatchMaxWidths so that the text get an ellipsis if needed. Also, the description view will not be shown if there is no space for it. Bug: 836740 , 838592 Change-Id: I096fddd1191dfb61f1cd008e4b81a79bd718d1f2 Reviewed-on: https://chromium-review.googlesource.com/1038618 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#555482} [modify] https://crrev.com/b116a6d0e5b256577c2cc298c6d8a1c254ac14a8/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
,
May 2 2018
,
May 3 2018
Update : Retested above issue in latest Canary build #68.0.3418.0 on Windows(7,8,8.1,10) and Linux(14.04 LTS) OS and the issue is fixed. No overlapping of text is observed in omnibox. Kindly review an attached screen-cast. Thank you..! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Apr 25 2018