Autofill data isn't cleared properly |
|||||
Issue descriptionChrome Version: 68.0.3405.0 OS: Linux What steps will reproduce the problem? (1) Have some autofill data saved on different forms (2) Go to chrome://settings/clearBrowserData (3) Clear Autofill form data for all time. What is the expected result? Everything is gone. What happens instead? Some autofill tables in 'Web Data" still contain PII. They are autofill_profile_names, autofill_profile_emails, autofill_profile_phones, maybe something else.
,
Apr 25 2018
Is this a regression, or was it missing before?
,
Apr 26 2018
Ok I know why this is happening. I don't think it's a regression. The functions to delete one or all profiles are working fine, the problem is with RemoveAutofillDataModifiedBetween https://cs.chromium.org/chromium/src/components/autofill/core/browser/webdata/autofill_table.cc?l=1556 It only deletes from the main autofill table. Will fix this.
,
Apr 26 2018
I sent the CL for review. I will also need to add a one time function to clean up the orphan rows...
,
Apr 27 2018
I'm setting Pri=1. Even if it's not a regression, it should be fixed before the next release.
,
Apr 27 2018
For reference, somebody posted this in the past day or so: https://github.com/dtwozero/vivaleak The claims is about Vivaldi, but AFAICT much of what is reported, especially the autofill issue, is a chromium issue (one case further down may be due a missing remove flag, which I am investigating)
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f86ebce5e49c5c5bf2fa6e4dd23ed0603c15be9 commit 3f86ebce5e49c5c5bf2fa6e4dd23ed0603c15be9 Author: sebsg <sebsg@chromium.org> Date: Fri Apr 27 17:06:52 2018 [AF] Clear profile pieces when deleting data in time range. Previously is only deleted form the main profile table. The sub tables need to be deleted too. Bug: 836737 Change-Id: I1e5fc74ace5b073cc66fcece422c2fd50d208743 Reviewed-on: https://chromium-review.googlesource.com/1031311 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#554410} [modify] https://crrev.com/3f86ebce5e49c5c5bf2fa6e4dd23ed0603c15be9/components/autofill/core/browser/webdata/autofill_table.cc [modify] https://crrev.com/3f86ebce5e49c5c5bf2fa6e4dd23ed0603c15be9/components/autofill/core/browser/webdata/autofill_table_unittest.cc
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be7af10823fa91f688bc537f8ddf5d2de38f31b4 commit be7af10823fa91f688bc537f8ddf5d2de38f31b4 Author: sebsg <sebsg@chromium.org> Date: Thu May 03 18:59:48 2018 [AF] Remove orphan rows in the secondary autofill tables. A function used to not remove from the secondary table when deleting. This CL adds a one-time per device clean-up of the rows in the secondary tables that were left behind. Bug: 836737 Change-Id: Icfe70b8ee98deb5a3de1fc1f3b08b197e9760132 Reviewed-on: https://chromium-review.googlesource.com/1038582 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#555836} [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/webdata/autofill_table.cc [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/webdata/autofill_table.h [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/webdata/autofill_table_unittest.cc [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/webdata/autofill_webdata.h [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/webdata/autofill_webdata_service.cc [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/browser/webdata/autofill_webdata_service.h [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/common/autofill_pref_names.cc [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/autofill/core/common/autofill_pref_names.h [modify] https://crrev.com/be7af10823fa91f688bc537f8ddf5d2de38f31b4/components/browser_sync/profile_sync_service_autofill_unittest.cc
,
May 3 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ma...@chromium.org
, Apr 25 2018Status: Assigned (was: Untriaged)