Issue metadata
Sign in to add a comment
|
"Issued at" date at certificate SCT detail view is displayed incorrect
Reported by
markusk...@gmail.com,
Apr 25 2018
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36 Steps to reproduce the problem: 1. Navigate to https://www.google.de/ 2. Press "F12", go to "Security", Reload page and click on "Main origin" to view detailed certificate information 3. Click on "Show full details" at Certificate Transparency section, see date at "Issued at", which shows 2387 What is the expected behavior? The year shown is incorrect, correct value should be date of issuing in year 2018. What went wrong? The "Issued at" date shows year 2387 instead of year 2018 Did this work before? N/A Chrome version: 66.0.3359.117 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Apr 26 2018
Able to reproduce this issue on reported version 66.0.3359.117 , on latest canary 68.0.3409.0 using Windows 10, Ubuntu 17.10 and Mac 10.13.3. Good Build: 66.0.3346.0 -- Tue, 10 Apr 2018 is seen Bad Build: 66.0.3347.0 -- Fri, 10 Apr 2387 is seen You are probably looking for a change made after 536401 (known good), but no later than 536402 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/da651de72deefafe29d81c522234a2557475cc2b..30f8822a37972aabd4b76d4559d1062d6799c9cb Reviewed-on: https://chromium-review.googlesource.com/912400 Suspecting same from changelog. @caseq: Please confirm the bug and help in re-assigning if this is not related to your change. Adding RB-Stable for M-66. Please remove if not the case. Thanks!
,
Apr 26 2018
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28e7ee60a6911a3acac8cc0ef9425a2b00dbfc03 commit 28e7ee60a6911a3acac8cc0ef9425a2b00dbfc03 Author: Andrey Kosyakov <caseq@chromium.org> Date: Fri Apr 27 23:18:26 2018 DevTools: fix SCT timestamp in SecurityDetails of frame resources Bug: 836732 Change-Id: Ia8b1fbfca1cb1a30289337571e8db6a3163751ac Reviewed-on: https://chromium-review.googlesource.com/1033721 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#554553} [modify] https://crrev.com/28e7ee60a6911a3acac8cc0ef9425a2b00dbfc03/content/browser/devtools/protocol/network_handler.cc
,
Apr 30 2018
Able to reproduce this issue on Windows 10, Ubuntu 17.10 and Mac OS 10.12.6 on the reported version 66.0.3359.117 and the issue is fixed on the latest Canary 68.0.3415.0 as per the original comment. Can observe the "Issued at" date as 2018 instead of 2387 at Devtools -> Security ->Main origin -> "Show full details" at Certificate Transparency section. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Apr 30 2018
,
Apr 30 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 30 2018
How is the change listed at #4 looking in canary? Is it safe to merge to M67?
,
Apr 30 2018
Should be pretty safe to merge, it's a one liner that only changes arithmetic, so further regressions are highly unlikely.
,
Apr 30 2018
Approving merge to M67 branch 3396 based on comments #5 and #9. Please merge ASAP so we can pick it up for this week Beta release. Thank you.
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/990a93f0fdbf1cc72f5610eaa3cfb2646cd5300e commit 990a93f0fdbf1cc72f5610eaa3cfb2646cd5300e Author: Andrey Kosyakov <caseq@chromium.org> Date: Mon Apr 30 18:24:53 2018 DevTools: fix SCT timestamp in SecurityDetails of frame resources Bug: 836732 Change-Id: Ia8b1fbfca1cb1a30289337571e8db6a3163751ac Reviewed-on: https://chromium-review.googlesource.com/1033721 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#554553}(cherry picked from commit 28e7ee60a6911a3acac8cc0ef9425a2b00dbfc03) Reviewed-on: https://chromium-review.googlesource.com/1035644 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#387} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/990a93f0fdbf1cc72f5610eaa3cfb2646cd5300e/content/browser/devtools/protocol/network_handler.cc
,
Apr 30 2018
Seems like it's fine to target M67, and I'll remove M66. Does that sound ok caseq?
,
Apr 30 2018
Absolutely!
,
May 2 2018
Able to reproduce this issue on Windows 10, Ubuntu 17.10 and Mac OS 10.12.6 on the reported version 66.0.3359.117 hence verifying the fix on latest beta 67.0.3396.30 Can observe the "Issued at" date as 2018 instead of 2387 at Devtools -> Security ->Main origin -> "Show full details" at Certificate Transparency section. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
May 2 2018
*** Bulk Edit *** M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
,
May 4 2018
,
May 23 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by viswa.karala@chromium.org
, Apr 25 2018