For now, the BrowserContainerVC isn't fullscreen. There is a fake status bar displayed on above it. This status bar is useless and should be removed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6460a84153d9cda0d1d64415841daf721976341d commit 6460a84153d9cda0d1d64415841daf721976341d Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Apr 25 11:19:32 2018 Cleanup BVC's HeaderDefinition This CL clean the HeaderDefinition class, removing unused properties. Bug: 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iddc78f1a52ca587617d1def9c03455c2a1052f5b Reviewed-on: https://chromium-review.googlesource.com/1026679 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#553514} [modify] https://crrev.com/6460a84153d9cda0d1d64415841daf721976341d/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4417f85f1bf6290474c4f1f4e432373534de3423 commit 4417f85f1bf6290474c4f1f4e432373534de3423 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Apr 26 14:24:32 2018 Add a flag to make BCVC fullscreen This CL adds a flag to make the BrowserContainerViewController fullscreen. When this flag is enabled, the frame of the BCVC is changed and the calculations relative to the headers are changed. Bug: 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib57918ff6d0c673292c2b397c21a396dda6f62d9 Reviewed-on: https://chromium-review.googlesource.com/1026732 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#554017} [modify] https://crrev.com/4417f85f1bf6290474c4f1f4e432373534de3423/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/4417f85f1bf6290474c4f1f4e432373534de3423/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/4417f85f1bf6290474c4f1f4e432373534de3423/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/4417f85f1bf6290474c4f1f4e432373534de3423/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/4417f85f1bf6290474c4f1f4e432373534de3423/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/4417f85f1bf6290474c4f1f4e432373534de3423/ios/chrome/browser/ui/ui_feature_flags.cc [modify] https://crrev.com/4417f85f1bf6290474c4f1f4e432373534de3423/ios/chrome/browser/ui/ui_feature_flags.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae568119ea410da79354bf17d59a24bdf271b29b commit ae568119ea410da79354bf17d59a24bdf271b29b Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 02 08:04:21 2018 Fix side swipe with BrowserContainer fullscreen This CL fixes the side swipe animation when the flag to make BrowserContainer fullscreen is enabled. Bug: 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3b5a70135e91dd630e9c9052957347f790cafe16 Reviewed-on: https://chromium-review.googlesource.com/1032435 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#555327} [modify] https://crrev.com/ae568119ea410da79354bf17d59a24bdf271b29b/ios/chrome/browser/ui/side_swipe/BUILD.gn [modify] https://crrev.com/ae568119ea410da79354bf17d59a24bdf271b29b/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d commit b7a0746e11f4b9d4aa6546dc14cb56b687fe968d Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 09 09:18:19 2018 Toolbar can have a non-zero height in fullscreen This CL allows the toolbar to have non-zero height in fullscreen. It can be used with the UI Refresh and the Browser Container being fullscreen. Bug: 807572 , 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If292c787596be8d543142cdf75c5b1d27eb66e4c Reviewed-on: https://chromium-review.googlesource.com/1030393 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557130} [modify] https://crrev.com/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater.h [modify] https://crrev.com/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater.mm [modify] https://crrev.com/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater_unittest.mm [modify] https://crrev.com/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d/ios/chrome/browser/ui/toolbar/toolbar_owner.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d2c71dc86154427039efa790e469ddde6bca4c5 commit 2d2c71dc86154427039efa790e469ddde6bca4c5 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 09 11:09:58 2018 Fix Open in New Tab animation for fullscreen BCVC This CL fixes the animation occuring when opening a new tab in background when the flag to enable BrowserContainer fullscreen. Bug: 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifa1abee606888938fe3b551903e16f92c7c60698 Reviewed-on: https://chromium-review.googlesource.com/1032772 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557145} [modify] https://crrev.com/2d2c71dc86154427039efa790e469ddde6bca4c5/ios/chrome/browser/snapshots/BUILD.gn [modify] https://crrev.com/2d2c71dc86154427039efa790e469ddde6bca4c5/ios/chrome/browser/snapshots/snapshot_generator.mm [modify] https://crrev.com/2d2c71dc86154427039efa790e469ddde6bca4c5/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1aa843abd7b9fd12d2ec9b48fe53699da2c085df commit 1aa843abd7b9fd12d2ec9b48fe53699da2c085df Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 16 06:37:00 2018 Fix overscroll for BCVC fullscreen This CL fixes the overscroll actions, mainly for the NTP when the BCVC is in fullscreen. Bug: 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib4475e32bb45d05682e9fd663de4e1dee193e812 Reviewed-on: https://chromium-review.googlesource.com/1059149 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#558996} [modify] https://crrev.com/1aa843abd7b9fd12d2ec9b48fe53699da2c085df/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/1aa843abd7b9fd12d2ec9b48fe53699da2c085df/ios/chrome/browser/ui/overscroll_actions/BUILD.gn [modify] https://crrev.com/1aa843abd7b9fd12d2ec9b48fe53699da2c085df/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d762728bab96990b6850e1edb2cab49c9cf97a0 commit 5d762728bab96990b6850e1edb2cab49c9cf97a0 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri May 18 08:20:07 2018 Fix Open New Incognito Tab animation This CL fixes the Open New Incognito Tab animation when the BrowserContainerViewController is in fullscreen. It is also fixing the animation for the iPhone X. Bug: 688259, 836730 , 819811, 843931 , 844013 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I298811b90b42122ff2f805f7888d2d5ff750c2b8 Reviewed-on: https://chromium-review.googlesource.com/1061528 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#559837} [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/snapshots/snapshot_generator.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ntp/incognito_view.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ui_feature_flags.cc [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ui_feature_flags.h [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/features.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/public/features.h [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/web_state/ui/crw_web_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2 commit f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue May 22 06:52:15 2018 Fix NTP for BCVC fullscreen This CL fixes the normal NTP when BCVC is fullscreen, mainly the interactions with the overscroll actions. Bug: 844013 , 836730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If14d459b1261668272e492a3d0c100264811d975 Reviewed-on: https://chromium-review.googlesource.com/1065815 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#560500} [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/ntp/new_tab_page_bar.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
The NextAction date has arrived: 2018-05-23
The NextAction date has arrived: 2018-06-06
Q3 -> Q4.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66de93d374577f065ab3d282b134542a886f3682 commit 66de93d374577f065ab3d282b134542a886f3682 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Aug 30 15:58:19 2018 [iOS] Move the fullscreen frame change to the fullscreen mediator This CL changes the way the frame of the WebView is changed, moving the implementation to the FullscreenMediator. Bug: 836730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Idc8b339ea61d4024268549789f18ec10c64f0d54 Reviewed-on: https://chromium-review.googlesource.com/1194226 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#587601} [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ui/fullscreen/BUILD.gn [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ui/fullscreen/fullscreen_content_adjustment_util.mm [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ui/fullscreen/fullscreen_mediator.h [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ui/fullscreen/fullscreen_mediator.mm [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.h [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.mm [add] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_resizer.h [add] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_resizer.mm [add] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_resizer_unittest.mm [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/web/features.mm [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/web/public/features.h [modify] https://crrev.com/66de93d374577f065ab3d282b134542a886f3682/ios/web/web_state/ui/crw_web_view_content_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab8fe8a52e6cf13e2eee4ab328be85577dd57935 commit ab8fe8a52e6cf13e2eee4ab328be85577dd57935 Author: Justin Cohen <justincohen@google.com> Date: Wed Oct 03 14:18:32 2018 [ios] Correct new tab animation with fullscreen features enabled. Also note that -correctMissingSafeArea in content suggestions VC can be bypassed when the BrowserContainerFullscreen feature is enabled. BUG: 849206 , 836730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id876a66b1509cdec64a645b59c296186c31fa8e1 Reviewed-on: https://chromium-review.googlesource.com/c/1255984 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596203} [modify] https://crrev.com/ab8fe8a52e6cf13e2eee4ab328be85577dd57935/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/ab8fe8a52e6cf13e2eee4ab328be85577dd57935/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
Verified on 71.0.3572.0 Canary, iPhone X iOS 11.4.1 Fullscreen's animation looks good. https://drive.google.com/file/d/1fJNu5d6PSNFv_DZYARQM5a1CmcR3SrMJ/view
Comment 1 by bugdroid1@chromium.org
, Apr 25 2018