New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836729 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AEC3: Attenuation of narrow banded peaks is too aggressive

Project Member Reported by gustaf@chromium.org, Apr 25 2018

Issue description

The code meant to attenuate narrow banded peaks in the echo signal sometimes affects the near-end signal which affects transparency.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/5bb98971ce890be83add3282c7c421ff4f613599

commit 5bb98971ce890be83add3282c7c421ff4f613599
Author: Gustaf Ullberg <gustaf@webrtc.org>
Date: Wed Apr 25 11:51:23 2018

Remove attenuation of narrow banded peaks

The code that attenuates narrow banded echo peaks in low frequencies
is removed as it affects transparency negatively.

Bug:  webrtc:9192 , chromium:836729 
Change-Id: Ib90ce6a3db0a75e8d69bdca432e1f8f8bfbbd988
Reviewed-on: https://webrtc-review.googlesource.com/72380
Reviewed-by: Per Ã…hgren <peah@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23022}
[modify] https://crrev.com/5bb98971ce890be83add3282c7c421ff4f613599/modules/audio_processing/aec3/suppression_gain.cc
[modify] https://crrev.com/5bb98971ce890be83add3282c7c421ff4f613599/modules/audio_processing/aec3/suppression_gain.h

Comment 2 by gustaf@chromium.org, Apr 25 2018

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1780022b576bc42676a8ab1a070ddf19b4189dac

commit 1780022b576bc42676a8ab1a070ddf19b4189dac
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Apr 25 17:12:35 2018

Roll src/third_party/webrtc/ 09408115c..ff61273c0 (9 commits)

https://webrtc.googlesource.com/src.git/+log/09408115cda7..ff61273c010c

$ git log 09408115c..ff61273c0 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG= chromium:836790 ,chromium:None,chromium:836729,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Icfa9b26e7de7db99d2c8f985b198097bb7805e49
Reviewed-on: https://chromium-review.googlesource.com/1028222
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553610}
[modify] https://crrev.com/1780022b576bc42676a8ab1a070ddf19b4189dac/DEPS

Owner: gustaf@chromium.org
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Comment 6 by gustaf@chromium.org, Jun 11 2018

Labels: M-67

Sign in to add a comment