New issue
Advanced search Search tips

Issue 836722 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in blink::RoundedIntPoint

Project Member Reported by ClusterFuzz, Apr 25 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5134438879723520

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::RoundedIntPoint
  blink::PointInFrameContentIfVisible
  blink::HitTestInDocument
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=552707:552711

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5134438879723520

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 25 2018

Components: Blink>DOM Platform
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 25 2018

Labels: Test-Predator-Auto-Owner
Owner: orphis@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/254b97d5a6edc67def94977f747c4472182a867b (Introduce a direct dependency Blink -> WebRTC).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by f...@opera.com, Apr 25 2018

Components: -Platform -Blink>DOM Blink>HitTesting
Labels: Test-Predator-Wrong
Owner: f...@opera.com
One fairly obvious issue in this function.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf79c8a6e53c84777048c11fd3e1548cee502840

commit bf79c8a6e53c84777048c11fd3e1548cee502840
Author: Fredrik Söderquist <fs@opera.com>
Date: Wed Apr 25 14:12:22 2018

Use round() [not roundf()] in RoundedIntPoint(const DoublePoint&)

This avoids the implicit conversion to float, which can lead to loss of
precision.

Bug:  836722 
Change-Id: I66ea0f42823347b17e41e5d823aaf766429eacbf
Reviewed-on: https://chromium-review.googlesource.com/1027710
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#553543}
[modify] https://crrev.com/bf79c8a6e53c84777048c11fd3e1548cee502840/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/bf79c8a6e53c84777048c11fd3e1548cee502840/third_party/blink/renderer/platform/geometry/double_point.h
[add] https://crrev.com/bf79c8a6e53c84777048c11fd3e1548cee502840/third_party/blink/renderer/platform/geometry/double_point_test.cc

Project Member

Comment 5 by ClusterFuzz, Apr 26 2018

ClusterFuzz has detected this issue as fixed in range 553539:553543.

Detailed report: https://clusterfuzz.com/testcase?key=5134438879723520

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::RoundedIntPoint
  blink::PointInFrameContentIfVisible
  blink::HitTestInDocument
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=552707:552711
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=553539:553543

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5134438879723520

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Apr 26 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5134438879723520 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment