Tracking bug for design/implementation changes needed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1c00d26423fee9363a7e6a685c2e438968328e1 commit a1c00d26423fee9363a7e6a685c2e438968328e1 Author: Jan Krcal <jkrcal@chromium.org> Date: Mon May 28 08:51:32 2018 [Autofill] Extend AutofillTable sync metadata for multiple model_types This CL prepares the Web Database for storing sync metadata for the AUTOFILL_PROFILE type as well. The CL does it in a general way, paving the way for further types (such as for payments). Bug: 836718 Change-Id: I422cb1759d96e233ae255c15dbc95ef0dd405223 Reviewed-on: https://chromium-review.googlesource.com/1063728 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#562210} [modify] https://crrev.com/a1c00d26423fee9363a7e6a685c2e438968328e1/components/autofill/core/browser/webdata/autofill_table.cc [modify] https://crrev.com/a1c00d26423fee9363a7e6a685c2e438968328e1/components/autofill/core/browser/webdata/autofill_table.h [modify] https://crrev.com/a1c00d26423fee9363a7e6a685c2e438968328e1/components/autofill/core/browser/webdata/autofill_table_unittest.cc [modify] https://crrev.com/a1c00d26423fee9363a7e6a685c2e438968328e1/components/sync/base/model_type.h [modify] https://crrev.com/a1c00d26423fee9363a7e6a685c2e438968328e1/components/sync/syncable/model_type.cc [modify] https://crrev.com/a1c00d26423fee9363a7e6a685c2e438968328e1/components/sync/syncable/model_type_unittest.cc [add] https://crrev.com/a1c00d26423fee9363a7e6a685c2e438968328e1/components/test/data/web_database/version_77.sql [modify] https://crrev.com/a1c00d26423fee9363a7e6a685c2e438968328e1/components/webdata/common/BUILD.gn [modify] https://crrev.com/a1c00d26423fee9363a7e6a685c2e438968328e1/components/webdata/common/web_database.cc [modify] https://crrev.com/a1c00d26423fee9363a7e6a685c2e438968328e1/components/webdata/common/web_database_migration_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cfab39f992981a7e56cb2578993e65c49f94407 commit 4cfab39f992981a7e56cb2578993e65c49f94407 Author: Jan Krcal <jkrcal@chromium.org> Date: Tue May 29 13:13:41 2018 [Autofill USS] Refactor the test to use mock processor This CL changes the test fixture of autocomplete_sync_bridge_unittest.cc to use mock processor instead of recording fake processor. The mock processor allows the same counting as the recording processor and is backed up by real processor that allows more realistic tests. Bug: 836718 Change-Id: I570d2091e6a93194ae37394bd00780ff466d2455 Reviewed-on: https://chromium-review.googlesource.com/1066061 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#562401} [modify] https://crrev.com/4cfab39f992981a7e56cb2578993e65c49f94407/components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc [modify] https://crrev.com/4cfab39f992981a7e56cb2578993e65c49f94407/components/sync/test/test_matchers.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d32ca179260c00859d1fe818bf1568230ca1363 commit 5d32ca179260c00859d1fe818bf1568230ca1363 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Jun 27 14:39:22 2018 [Autofill profile] Create the bridge for USS This CL creates the bridge for the autofill_profile sync type. It only implements reacting to local changes, applying sync changes will be implemented in a follow-up CL. The CL only converts relevant unit-tests from AutofillProfileSyncableServiceTest. Tests corresponding to ProfileSyncServiceAutofillTest will come in later CLs. Bug: 836718 Change-Id: Ic91fad53a0623be416ceb4c1f96451c732cf5ac3 Reviewed-on: https://chromium-review.googlesource.com/1113187 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570765} [modify] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/autofill_profile.h [add] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/autofill_profile_sync_util.cc [add] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/autofill_profile_sync_util.h [add] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/autofill_profile_sync_util_unittest.cc [modify] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/form_group.cc [modify] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/form_group.h [add] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/webdata/autofill_profile_sync_bridge.cc [add] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/webdata/autofill_profile_sync_bridge.h [add] https://crrev.com/5d32ca179260c00859d1fe818bf1568230ca1363/components/autofill/core/browser/webdata/autofill_profile_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69fc00a560dad8d56f49d051764134a427595045 commit 69fc00a560dad8d56f49d051764134a427595045 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Jul 04 13:47:12 2018 [Autofill profile] Implement remote changes for the USS bridge This CL completes full functionality for the sync bridge for autofill_profile model type. The CL only converts applicable unit-tests from AutofillProfileSyncableServiceTest. Tests corresponding to ProfileSyncServiceAutofillTest will come in a later CL. Bug: 836718 Change-Id: I5cf596e117d74c85d2ac40a356b0beaab98e1a1f Reviewed-on: https://chromium-review.googlesource.com/1100762 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#572552} [modify] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/autofill_profile.h [modify] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/autofill_profile_sync_util.cc [modify] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/autofill_profile_sync_util.h [modify] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/autofill_profile_sync_util_unittest.cc [modify] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/webdata/autofill_profile_sync_bridge.cc [modify] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/webdata/autofill_profile_sync_bridge.h [modify] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/webdata/autofill_profile_sync_bridge_unittest.cc [add] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/webdata/autofill_profile_sync_difference_tracker.cc [add] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/webdata/autofill_profile_sync_difference_tracker.h [add] https://crrev.com/69fc00a560dad8d56f49d051764134a427595045/components/autofill/core/browser/webdata/autofill_profile_sync_difference_tracker_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d2b56d415390e16176357a002f2f49389361974 commit 7d2b56d415390e16176357a002f2f49389361974 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Jul 04 20:48:24 2018 [Autofill profile] Integrate USS bridge behind a feature toggle This CL adds a new feature toggle that enables the new USS implementation of autofill profile sync bridge. Initially, this is set to disabled by default for users and also disabled for trybots. When we get complete test coverage, we enable this feature for trybots. Bug: 836718 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaa9893f6780e0cbcdb54365b18baf88b398b8a9c Reviewed-on: https://chromium-review.googlesource.com/1114968 Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#572650} [modify] https://crrev.com/7d2b56d415390e16176357a002f2f49389361974/chrome/browser/sync/chrome_sync_client.cc [modify] https://crrev.com/7d2b56d415390e16176357a002f2f49389361974/components/browser_sync/profile_sync_components_factory_impl.cc [modify] https://crrev.com/7d2b56d415390e16176357a002f2f49389361974/components/sync/driver/sync_driver_switches.cc [modify] https://crrev.com/7d2b56d415390e16176357a002f2f49389361974/components/sync/driver/sync_driver_switches.h [modify] https://crrev.com/7d2b56d415390e16176357a002f2f49389361974/components/webdata_services/web_data_service_wrapper.cc [modify] https://crrev.com/7d2b56d415390e16176357a002f2f49389361974/ios/chrome/browser/sync/ios_chrome_sync_client.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6d973811cf224014cdd9f57606ef00b5abf225a commit a6d973811cf224014cdd9f57606ef00b5abf225a Author: Jan Krcal <jkrcal@chromium.org> Date: Mon Jul 09 06:57:32 2018 [Autofill Profile] Convert a test from ProfileSyncServiceAutofillTest This CL adds one test for AutofillProfileSyncBridge. After the change, all the functionality tested for the directory implementation in ProfileSyncServiceAutofillTest is now also tested for the USS implementation in AutofillProfileSyncBridge. Bug: 836718 Change-Id: I65fa3d0bd5d6e9139111d8c825fff86bf7c26ace Reviewed-on: https://chromium-review.googlesource.com/1123836 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573235} [modify] https://crrev.com/a6d973811cf224014cdd9f57606ef00b5abf225a/components/autofill/core/browser/webdata/autofill_profile_sync_bridge_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d46aa32b88c06ba76517c63eb96db3ff922988cd commit d46aa32b88c06ba76517c63eb96db3ff922988cd Author: Jan Krcal <jkrcal@chromium.org> Date: Mon Jul 09 07:33:10 2018 [Autofill profile] Integration tests run on both implementation This CL parametrizes integration and perf tests for autofill profile sync to run them on both the sync directory implementation as well as on the USS implementation. For both tests, the CL splits the test fixtures to have a separate one for autofill_profile (that we want to parametrize) and for autocomplete (that we do not want to parametrize). Bug: 836718 Change-Id: Ib9a7450e04cbcb440a061adf313168434be9baa9 Reviewed-on: https://chromium-review.googlesource.com/1114970 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#573239} [modify] https://crrev.com/d46aa32b88c06ba76517c63eb96db3ff922988cd/chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc [modify] https://crrev.com/d46aa32b88c06ba76517c63eb96db3ff922988cd/chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ff23f7c07e239035061f0830a18665adccb63d6 commit 2ff23f7c07e239035061f0830a18665adccb63d6 Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Sep 04 16:16:13 2018 [Autofill profile sync] Create an about:flag for the USS implementation Bug: 836718 Change-Id: I97c423d880509bdc27893ef85e7402e7c58bb16d Reviewed-on: https://chromium-review.googlesource.com/1203655 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#588532} [modify] https://crrev.com/2ff23f7c07e239035061f0830a18665adccb63d6/chrome/browser/about_flags.cc [modify] https://crrev.com/2ff23f7c07e239035061f0830a18665adccb63d6/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/2ff23f7c07e239035061f0830a18665adccb63d6/chrome/browser/flag_descriptions.h [modify] https://crrev.com/2ff23f7c07e239035061f0830a18665adccb63d6/tools/metrics/histograms/enums.xml
Comment 1 by bugdroid1@chromium.org
, May 28 2018