Thanks for the report.

+Hwi who might know who to route this to. Otherwise hopefully the Localization component will work some magic.

+srahim@ - could you advise on the correct route for this localization bug? Thanks!


+austinknight as fyi

Hi,

We appreciate for reporting this bug, but may we request for an actual screenshot of this issue?

Regards!

Find the requested screen shot enclosed.

Deleted: Screenshot 2018-04-30 at 22.09.07.png 78.2 KB

	Screenshot 2018-04-30 at 22.09.07.png 78.2 KB View Download

mencinares@: TC ID for the string is: 5975464174231733181
I think we may need a cleanup; a quick checks shows at least one other language where the string may be mistranslated (JA). 

alancutter@, could we update the message description for the string? It uses the gerund and that may be why the translators mistranslated the string as a gerund. Proposed:

<if expr="use_titlecase">
        <message name="IDS_INSTALL_TO_OS_LAUNCH_SURFACE" desc="In Title Case: Menu item that lets the user install a web app to the operating system.">
          Install <ph name="APP">$1<ex>Gmail</ex></ph>...
        </message>
      </if>
      <if expr="not use_titlecase">
        <message name="IDS_INSTALL_TO_OS_LAUNCH_SURFACE" desc="Menu item that lets the user install a web app to the operating system.">
          Install <ph name="APP">$1<ex>Gmail</ex></ph>...
        </message>
      </if>

(Internal TC link: https://tc.corp.google.com/btviewer/messagedetail?project=ChromeClient&msgId=5975464174231733181)

 

Hi,

Thanks for attaching the screenshot file. I have forwarded this issue to the locale POC for TC editing. I'll update you once it is done.

b/79089831

Regards!

Hi All,

This has been fixed. 
Feel free to reopen if needed.

Regards!

The wrong German grammar is fixed, but along with that the ellipsis "…" at the end of the menu item has been lost.

While in English it's still "Install <app name>…" the German translation is now just "<app name> installieren".

As the menu item brings up an additional dialog those three dots are necessary to keep the UI consistent.

Deleted: Screenshot 2018-05-31 at 08.20.56.png 13.3 KB

	Screenshot 2018-05-31 at 08.20.56.png 13.3 KB View Download

Can someone with the necessary privileges reopen this issue?

See my previous comment …

Hi,

The language POC already corrected the incorrect translation as you've requested.
That should be the least thing that they can do in localization.

The 3 dot menu might be an Engineering case.



@Mellie, can you please look into this? The TC has been fixed already by the language POC.


Regards!

Thanks Marvin for the heads-up - is the EN source in TC including the 3 dots? If that's the case, as mentioned by Norbert, we might have to fix that on our side.
If not, that might be an Eng case as you mentioned - thanks for checking!

Hi Mellie,

This is a functional as confirmed. To whom should we assign this to get it fix?

Regards!

Hi Mellie,

I just wanted to follow-up the concern from comment#17

Thanks!

+desktop PWA folks.

The English source for this string contains the "...":
https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?q=IDS_INSTALL_TO_OS_LAUNCH_SURFACE&sq=package:chromium&l=1979&dr=C

I suspect it was accidentally omitted in the German translation though I'm not sure where to look to verify this.

I'm following this up. Message ID is 5975464174231733181.

#23 is this fixed? The link I gave in #7 still shows the string has not been updated. And the internal bug is still open.

Marking as unfixed. Set it back to Fixed if I'm mistaken.

This string is now fixed downstream in the TC console. German string is now "APP installieren..."

Assuming this propagates upwards, closing as Fixed.