New issue
Advanced search Search tips

Issue 836700 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Reenable test partnercustomizations.PartnerHomepageUnitTest#testProviderNotFromSystemPackage

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 25 2018

Issue description

"org.chromium.chrome.browser.partnercustomizations.PartnerHomepageUnitTest#testProviderNotFromSystemPackage" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 59 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNydQsSBUZsYWtlImpvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIucGFydG5lcmN1c3RvbWl6YXRpb25zLlBhcnRuZXJIb21lcGFnZVVuaXRUZXN0I3Rlc3RQcm92aWRlck5vdEZyb21TeXN0ZW1QYWNrYWdlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by rakina@chromium.org, Apr 25 2018

Components: UI>Browser>Mobile
Labels: -Sheriff-Chromium OS-Android
Owner: wychen@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4bd4e9a9716d126b95a8cb8c6a025417d15e491

commit a4bd4e9a9716d126b95a8cb8c6a025417d15e491
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Wed Apr 25 09:06:14 2018

Disable flaky PartnerHomepageUnitTest#testProviderNotFromSystemPackage

TBR=wychen@chromium.org

Bug: 836700
Change-Id: I6c72f9404a3373030a65a4acb31597fb70cb0974
Reviewed-on: https://chromium-review.googlesource.com/1027550
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553491}
[modify] https://crrev.com/a4bd4e9a9716d126b95a8cb8c6a025417d15e491/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageUnitTest.java

Comment 3 by donnd@google.com, Apr 25 2018

Cc: wychen@chromium.org
 Issue 836463  has been merged into this issue.

Comment 4 by donnd@google.com, Apr 25 2018

Labels: -Pri-1 Pri-3
Status: Assigned (was: Untriaged)
Summary: Reenable test partnercustomizations.PartnerHomepageUnitTest#testProviderNotFromSystemPackage (was: "org.chromium.chrome.browser.partnercustomizations.PartnerHomepageUnitTest#testProviderNotFromSystemPackage" is flaky)
wychen@, please reassign if needed.

Log shows this failure, and PartnerHomepageUnitTest.java:131 seems to correspond to

        Assert.assertFalse(PartnerBrowserCustomizations.isHomepageProviderAvailableAndEnabled());

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertFalse(Assert.java:64)
	at org.junit.Assert.assertFalse(Assert.java:74)
	at org.chromium.chrome.browser.partnercustomizations.PartnerHomepageUnitTest.testProviderNotFromSystemPackage(PartnerHomepageUnitTest.java:131)
	at java.lang.reflect.Method.invokeNative(Method.java)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.chromium.chrome.browser.partnercustomizations.BasePartnerBrowserCustomizationUnitTestRule$2.evaluate(BasePartnerBrowserCustomizationUnitTestRule.java:61)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:201)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:43)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:183)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:120)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Sign in to add a comment