New issue
Advanced search Search tips

Issue 836665 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::ScrollManager::LogicalScroll

Project Member Reported by ClusterFuzz, Apr 25 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5805499468218368

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  blink::ScrollManager::LogicalScroll
  blink::KeyboardEventManager::DefaultKeyboardEventHandler
  blink::Node::DefaultEventHandler
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=553301:553306

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5805499468218368

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 25 2018

Components: Blink>DOM
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 25 2018

Labels: Test-Predator-Auto-Owner
Owner: bokan@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/eebeab8487b2fb74cf048e5e24cf5678856cf44e (Scroll documentElement using LayoutView natively).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by bokan@chromium.org, Apr 25 2018

Cc: bokan@chromium.org
 Issue 836709  has been merged into this issue.
Project Member

Comment 4 by ClusterFuzz, Apr 25 2018

Labels: OS-Chrome

Comment 5 by bokan@chromium.org, Apr 25 2018

 Issue 836713  has been merged into this issue.

Comment 6 by bokan@chromium.org, Apr 25 2018

 Issue 836686  has been merged into this issue.
Project Member

Comment 7 by ClusterFuzz, Apr 25 2018

Labels: OS-Windows

Comment 8 by bokan@chromium.org, Apr 26 2018

Issue 837188 has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/244cafbc1ec65b1b6a43e28526df47d6c6316e3e

commit 244cafbc1ec65b1b6a43e28526df47d6c6316e3e
Author: David Bokan <bokan@chromium.org>
Date: Thu Apr 26 18:28:52 2018

Fix nullptr crash in keyboard scrolling

This CL fixes the crash by ensuring that any nodes added to the scroll
chain are valid, meaning they have a LayoutBox and a ScrollableArea.

Bug:  836665 
Change-Id: Ifc45a02c618f558d55b3e08ca98a8386987371eb
Reviewed-on: https://chromium-review.googlesource.com/1027906
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554089}
[modify] https://crrev.com/244cafbc1ec65b1b6a43e28526df47d6c6316e3e/third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-customization/touch-scroll-customization.html
[add] https://crrev.com/244cafbc1ec65b1b6a43e28526df47d6c6316e3e/third_party/WebKit/LayoutTests/fast/scrolling/keyboard-scroll-before-layout.html
[modify] https://crrev.com/244cafbc1ec65b1b6a43e28526df47d6c6316e3e/third_party/blink/renderer/core/input/scroll_manager.cc

Comment 10 by bokan@chromium.org, Apr 26 2018

Status: Fixed (was: Assigned)
Project Member

Comment 11 by ClusterFuzz, Apr 27 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5183885093371904 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by ClusterFuzz, Apr 27 2018

ClusterFuzz has detected this issue as fixed in range 554088:554097.

Detailed report: https://clusterfuzz.com/testcase?key=5805499468218368

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  blink::ScrollManager::LogicalScroll
  blink::KeyboardEventManager::DefaultKeyboardEventHandler
  blink::Node::DefaultEventHandler
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=553301:553306
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=554088:554097

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5805499468218368

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment