Issue 836641 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	yhirano@chromium.org
Closed:	Apr 2018
Components:	Blink>Network>FetchAPI
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug

Some security checks are ignored for keepalive requests

Project Member Reported by yhirano@chromium.org, Apr 25 2018

Issue description

Because we're uring DetachableResourceHandler which ignores cancel requests from renderer. We should stop doing that.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e18e29e7739143de7e17fd99f60882319dd3824

commit 3e18e29e7739143de7e17fd99f60882319dd3824
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Apr 25 07:59:59 2018

Do not use DetachableResourceHandle for keepalive requests

We don't need it for keepalive requests any more, and
DetachableResourceHandler ignores cancel requests from renderer, which
is bad.

Change-Id: Iada35d44e2290760ed7b293cdd3dd7280e69edea
Bug:  836641 
Reviewed-on: https://chromium-review.googlesource.com/1026333
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553480}
[modify] https://crrev.com/3e18e29e7739143de7e17fd99f60882319dd3824/content/browser/loader/resource_dispatcher_host_impl.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08d9e1d29b685f8bc5da44d14727751d3f29f7be

commit 08d9e1d29b685f8bc5da44d14727751d3f29f7be
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Apr 25 13:05:03 2018

Keep DocumentThreadableLoader for keepalive requests

...in order to make the logic work after frame detach.
This CL also removes Resource::SetDetachable which is no longer needed.

Bug:  836641 
Change-Id: I6ebc978021cafa9a6337afab5de29532fc28c4c1
Reviewed-on: https://chromium-review.googlesource.com/1027210
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553526}
[modify] https://crrev.com/08d9e1d29b685f8bc5da44d14727751d3f29f7be/third_party/blink/renderer/core/loader/document_threadable_loader.cc
[modify] https://crrev.com/08d9e1d29b685f8bc5da44d14727751d3f29f7be/third_party/blink/renderer/core/loader/document_threadable_loader.h
[modify] https://crrev.com/08d9e1d29b685f8bc5da44d14727751d3f29f7be/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/08d9e1d29b685f8bc5da44d14727751d3f29f7be/third_party/blink/renderer/platform/loader/fetch/resource.h