New issue
Advanced search Search tips

Issue 836634 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

ASSERT: 0 <= y && y < 1

Project Member Reported by ClusterFuzz, Apr 25 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5191539463290880

Fuzzer: libFuzzer_color_transform_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  0 <= y && y < 1
  approx_pow_
  apply_transfer_function_
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=552556:552566

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5191539463290880

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 25 2018

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 25 2018

Cc: brianosman@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Enable skcms in Skia by brianosman@google.com - https://chromium.googlesource.com/chromium/src/+/a3796c2471b11c81c8b532d66388c1b5ea708c07

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Cc: -brianosman@google.com mtklein@chromium.org
Owner: brianosman@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skcms/+/289a2a73aa2642075105c699bac996cb34c65661

commit 289a2a73aa2642075105c699bac996cb34c65661
Author: Brian Osman <brianosman@google.com>
Date: Wed Apr 25 14:15:11 2018

Reject parametric curves with negative A, C, D, or G

Skia had even more validation, and our inversion code does some
additional checking, but for something that's used a a source, this is
the minimum to make sense (and not trigger asserts in our approximate
pow implementation).

Bug:  chromium:836634 
Change-Id: I7984aa7c6fa372f3010eb404bb917a9d8a804f1f
Reviewed-on: https://skia-review.googlesource.com/123623
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>

[add] https://crrev.com/289a2a73aa2642075105c699bac996cb34c65661/profiles/fuzz/negative_g_para.icc.txt
[modify] https://crrev.com/289a2a73aa2642075105c699bac996cb34c65661/src/TransferFunction.c
[modify] https://crrev.com/289a2a73aa2642075105c699bac996cb34c65661/src/TransferFunction.h
[modify] https://crrev.com/289a2a73aa2642075105c699bac996cb34c65661/src/ICCProfile.c
[add] https://crrev.com/289a2a73aa2642075105c699bac996cb34c65661/profiles/fuzz/negative_g_para.icc
[modify] https://crrev.com/289a2a73aa2642075105c699bac996cb34c65661/tests.c

Status: Fixed (was: Assigned)
Project Member

Comment 6 by ClusterFuzz, Apr 26 2018

ClusterFuzz has detected this issue as fixed in range 553655:553672.

Detailed report: https://clusterfuzz.com/testcase?key=5191539463290880

Fuzzer: libFuzzer_color_transform_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  0 <= y && y < 1
  approx_pow_
  apply_transfer_function_
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=552556:552566
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=553655:553672

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5191539463290880

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Apr 26 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5191539463290880 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment