Currently there is no test coverage for |PopupTouchHandleDrawable| [1], since we still have few bugs about selection/insertion handles in WebView, adding tests would be good to prevent future bugs. amaralp@ also pointed out that aura handles scrolling from native side [2], |SelectionPopupControllerImpl| handles focus [3], we agreed that it should be possible to simplify |PopupTouchHandleDrawable| by moving these logic outside. [1] https://cs.chromium.org/chromium/src/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java?q=PopupTouchHandleDrawable&sq=package:chromium&dr=CSs&l=47 [2] https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc?type=cs&q=SetTemporarilyHidden&sq=package:chromium&l=162 [3] https://cs.chromium.org/chromium/src/content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java?type=cs&q=SetTextHandlesTemporarilyHidden&sq=package:chromium&l=1187
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ee0391693f4aa448833d50e2c61c8d86f884441 commit 6ee0391693f4aa448833d50e2c61c8d86f884441 Author: Shimi Zhang <ctzsm@chromium.org> Date: Fri Jun 01 16:37:01 2018 aw: Remove |PositionObserver| interface There is no need to keep this interface as we could use its only implementation |ViewPositionObserver| directly. Bug: 836558 Change-Id: Ic580a25e75d3d944495260a2590f579a4de8038c Reviewed-on: https://chromium-review.googlesource.com/1081852 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#563675} [modify] https://crrev.com/6ee0391693f4aa448833d50e2c61c8d86f884441/android_webview/BUILD.gn [modify] https://crrev.com/6ee0391693f4aa448833d50e2c61c8d86f884441/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java [delete] https://crrev.com/bdb4a42cda67aad4c162352f9d51325d4e48be7d/android_webview/java/src/org/chromium/android_webview/PositionObserver.java [modify] https://crrev.com/6ee0391693f4aa448833d50e2c61c8d86f884441/android_webview/java/src/org/chromium/android_webview/ViewPositionObserver.java
Comment 1 by bugdroid1@chromium.org
, Jun 1 2018