New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836553 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

Use same GL thread for VRShellGL and ARCoreGL

Project Member Reported by lincolnfrog@chromium.org, Apr 25 2018

Issue description

We currently would spin up two separate GL threads if we were running GVR and AR simultaneously. The GL threads should be shared between these systems.
 
Cc: mthiesse@chromium.org billorr@chromium.org
Components: Internals>VR
Labels: Proj-XR-AR OS-Android
Cc: vollick@chromium.org
I'm not entirely convinced that sharing the GL thread would be the right approach here.

However, this would be relatively simple if we went with my previous suggestion of having a provider per session type, so we can easily spin up both a VR presentation provider, and an AR provider, and just bind the AR provider to GVR's GL thread rather than the AR-specific GL thread. Unless I missed a bunch of discussion, there's still a lot we'd have to figure out... like will rendering work similarly to AR magic window? Do we pre-populate the submitted frame with stereo camera data and run the page's GL on top?
Cc: -mthiesse@chromium.org klausw@chromium.org offenwanger@chromium.org
Owner: mthiesse@chromium.org
Assigning to mthiesse to determine whether this is a good idea. Note that we are refactoring the device code ( issue 842025 ).
Status: WontFix (was: Assigned)
I think sharing GL threads would be a bad idea. Both ArCore->Update() and GVR's swap_chain_.AcquireFrame() block. Trying to do any sort of scheduling using these two APIs on the same thread would probably be a total nightmare.

Also hopefully devices that can take advantage of GVR and ArCore simultaneously are powerful enough to have multi-threaded processors and we should take advantage of that.
Components: Internals>XR
Components: Blink>WebXR

Sign in to add a comment