New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 836551 link

Starred by 2 users
Status: Assigned
Owner:
█ dburger@chromium.org
Last visit 20 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove waterfall.py and related constants for dead waterfalls.

Project Member Reported by dgarr...@chromium.org, Apr 25 2018 
lib/const/waterfall.py has constants representing a number of waterfalls that no longer exist.

We should remove the dead waterfalls, however, this is tricky because there are a large number of non-trivial uses of these constants spread out through the code, especially WATERFALL_TRYBOT.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c02c1a5c5d1b3f6785180c6ee860902c8dda1418

commit c02c1a5c5d1b3f6785180c6ee860902c8dda1418
Author: Don Garrett <dgarrett@google.com>
Date: Fri Oct 19 22:07:42 2018

waterfalls: Remove constants for dead waterfalls.

Remove the constants associated with the chromiumos.tryserver,
chromiumos.chromium, and chromeos.chrome waterfalls. None of these
waterfalls have been running in a while.

Also, update all of the assorted code that used those constants,
generally by swithing them to the "SWARMING" waterfall.

BUG=chromium:836551
TEST=run_tests

Change-Id: I0b3595794a7795803557c98247069b94446f8e9e
Reviewed-on: https://chromium-review.googlesource.com/1286483
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/c02c1a5c5d1b3f6785180c6ee860902c8dda1418/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/c02c1a5c5d1b3f6785180c6ee860902c8dda1418/lib/clactions_unittest.py
[modify] https://crrev.com/c02c1a5c5d1b3f6785180c6ee860902c8dda1418/lib/const/waterfall.py
[modify] https://crrev.com/c02c1a5c5d1b3f6785180c6ee860902c8dda1418/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/c02c1a5c5d1b3f6785180c6ee860902c8dda1418/cbuildbot/cbuildbot_run_unittest.py
[modify] https://crrev.com/c02c1a5c5d1b3f6785180c6ee860902c8dda1418/cbuildbot/cbuildbot_run.py
[modify] https://crrev.com/c02c1a5c5d1b3f6785180c6ee860902c8dda1418/lib/cidb_integration_test.py

Comment 3 by dgarr...@chromium.org, Nov 14

Owner: dburger@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f227055565884dc43e0496ffc48a985726e24393

commit f227055565884dc43e0496ffc48a985726e24393
Author: David Burger <dburger@chromium.org>
Date: Thu Nov 15 10:16:34 2018

Remove waterfall parameter from InsertBuild method

Part of reducing the waterfall concept and the usage of
the constants out of waterfall.py - remove waterfall as
a parameter from the cidb InsertBuild call as all builds
are now swarming builds and the waterfall column is left
blank.

TEST=lib/cidb_integration_test --debug --no-wipe
TEST=chromite/run_tests
BUG=836551

Change-Id: Ie537ce3a6cd96ddf4d79fd8bddad20e97b4df259
Reviewed-on: https://chromium-review.googlesource.com/1336004
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/lib/clactions_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/lib/cidb_integration_test.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/lib/cidb.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/cbuildbot/relevant_changes_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/cbuildbot/validation_pool_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/lib/hwtest_results_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/cbuildbot/builders/generic_builders_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/scripts/summarize_build_stats_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/cbuildbot/stages/test_stages_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/lib/fake_cidb.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/lib/builder_status_lib_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/cbuildbot/stages/generic_stages_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/cbuildbot/stages/report_stages.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/lib/clactions_metrics_unittest.py
[modify] https://crrev.com/f227055565884dc43e0496ffc48a985726e24393/cbuildbot/stages/handle_changes_stages_unittest.py
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a0d56b9237b01b5422c392806e068ad52b997d71

commit a0d56b9237b01b5422c392806e068ad52b997d71
Author: Alex Zamorzaev <zamorzaev@chromium.org>
Date: Tue Nov 20 07:43:54 2018

Revert "Remove waterfall parameter from InsertBuild method"

This reverts commit f227055565884dc43e0496ffc48a985726e24393.

Reason for revert: breaks chromeos-infra-unittests-pre-cq

BUG= chromium:906295 
TEST=None

Original change's description:
> Remove waterfall parameter from InsertBuild method
>
> Part of reducing the waterfall concept and the usage of
> the constants out of waterfall.py - remove waterfall as
> a parameter from the cidb InsertBuild call as all builds
> are now swarming builds and the waterfall column is left
> blank.
>
> TEST=lib/cidb_integration_test --debug --no-wipe
> TEST=chromite/run_tests
> BUG=836551
>
> Change-Id: Ie537ce3a6cd96ddf4d79fd8bddad20e97b4df259
> Reviewed-on: https://chromium-review.googlesource.com/1336004
> Commit-Ready: David Burger <dburger@chromium.org>
> Tested-by: David Burger <dburger@chromium.org>
> Reviewed-by: Don Garrett <dgarrett@chromium.org>

Change-Id: I068c2f06a4a628bac101752196d5ea9f797ac5eb
Reviewed-on: https://chromium-review.googlesource.com/1341120
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org>

[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/clactions_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/cidb_integration_test.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/cidb.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/relevant_changes_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/validation_pool_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/hwtest_results_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/builders/generic_builders_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/scripts/summarize_build_stats_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/test_stages_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/fake_cidb.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/builder_status_lib_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/generic_stages_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/report_stages.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/clactions_metrics_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/handle_changes_stages_unittest.py
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/ci_results_archiver/+/910adbbd96f1fd4097fe729d0314729ed01d2289

commit 910adbbd96f1fd4097fe729d0314729ed01d2289
Author: David Burger <dburger@chromium.org>
Date: Fri Nov 30 00:08:59 2018

Remove waterfall parameter from InsertBuild calls in tests

Per the change in http://crrev.com/c/1347298 remove the waterfall
parameter from calls to InsertBuild.

TEST=cros tryjob -g "1347298 1347299 1347393 1347392 1347391" chromeos-infra-unittests-pre-cq
BUG=chromium:836551
CQ-DEPEND=CL:1347298

Change-Id: I1c1c5e2a27e034496c798e48164b4f8d98834700
Reviewed-on: https://chromium-review.googlesource.com/1347299
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/910adbbd96f1fd4097fe729d0314729ed01d2289/ci_results_archiver/importers/cidb_build_importer_unittest.py
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/cee2171438c9939fa021194b0955a2cf61d3c2c4

commit cee2171438c9939fa021194b0955a2cf61d3c2c4
Author: David Burger <dburger@chromium.org>
Date: Fri Nov 30 00:08:58 2018

Remove waterfall parameter from InsertBuild calls in tests

Per the change in http://crrev.com/c/1347298 remove the waterfall
parameter from calls to InsertBuild.

TEST=cros tryjob -g "1347298 1347299 1347393 1347392 1347391" chromeos-infra-unittests-pre-cq
BUG=chromium:836551
CQ-DEPEND=CL:1347298

Change-Id: I2e6604272d0ef949b23151edf97de41e9733fc58
Reviewed-on: https://chromium-review.googlesource.com/1347393
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/cee2171438c9939fa021194b0955a2cf61d3c2c4/cl_status_viewer_server/cl_status_server_unittest.py
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/371477ff5e56f7364795685517acfa630958c0c9

commit 371477ff5e56f7364795685517acfa630958c0c9
Author: David Burger <dburger@chromium.org>
Date: Fri Nov 30 00:08:59 2018

Remove waterfall parameter from InsertBuild method

Part of reducing the waterfall concept and the usage of
the constants out of waterfall.py - remove waterfall as
a parameter from the cidb InsertBuild call as all builds
are now swarming builds and the waterfall column is left
blank.

TEST=lib/cidb_integration_test --debug --no-wipe
TEST=chromite/run_tests
BUG=chromium:836551
CQ-DEPEND=CL:1347299
CQ-DEPEND=CL:1347393
CQ-DEPEND=CL:1347392
CQ-DEPEND=CL:1347391

Change-Id: I3ebd86305afccbfbd6f677d78a5a24915f9e9eb4
Reviewed-on: https://chromium-review.googlesource.com/1347298
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: David Burger <dburger@chromium.org>

[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/lib/clactions_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/lib/cidb_integration_test.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/lib/cidb.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/cbuildbot/relevant_changes_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/cbuildbot/validation_pool_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/lib/hwtest_results_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/cbuildbot/builders/generic_builders_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/scripts/summarize_build_stats_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/cbuildbot/stages/test_stages_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/lib/fake_cidb.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/lib/builder_status_lib_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/cbuildbot/stages/generic_stages_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/cbuildbot/stages/report_stages.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/lib/clactions_metrics_unittest.py
[modify] https://crrev.com/371477ff5e56f7364795685517acfa630958c0c9/cbuildbot/stages/handle_changes_stages_unittest.py
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/bad_cl_detector/+/56ec0b899621c5e58670e3efeafa99143ae9881a

commit 56ec0b899621c5e58670e3efeafa99143ae9881a
Author: David Burger <dburger@chromium.org>
Date: Fri Nov 30 00:08:59 2018

Remove waterfall parameter from InsertBuild calls in tests

Per the change in http://crrev.com/c/1347298 remove the waterfall
parameter from calls to InsertBuild.

TEST=cros tryjob -g "1347298 1347299 1347393 1347392 1347391" chromeos-infra-unittests-pre-cq
BUG=chromium:836551
CQ-DEPEND=CL:1347298

Change-Id: I95b21f53bd43da87f15812e04f012e02b506d8f2
Reviewed-on: https://chromium-review.googlesource.com/1347391
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/56ec0b899621c5e58670e3efeafa99143ae9881a/lib/fetch_data_engine_test.py
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/439eba782bde9d318d74d5924a304b245842160b

commit 439eba782bde9d318d74d5924a304b245842160b
Author: David Burger <dburger@chromium.org>
Date: Fri Nov 30 00:08:59 2018

Remove waterfall parameter from InsertBuild calls in tests

Per the change in http://crrev.com/c/1347298 remove the waterfall
parameter from calls to InsertBuild.

TEST=cros tryjob -g "1347298 1347299 1347393 1347392 1347391" chromeos-infra-unittests-pre-cq
BUG=chromium:836551
CQ-DEPEND=CL:1347298

Change-Id: Idcb9ffb27c5466158820624e0c95e651a4c74f55
Reviewed-on: https://chromium-review.googlesource.com/1347392
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/439eba782bde9d318d74d5924a304b245842160b/exonerator/innocent_cls_cq_test.py
[modify] https://crrev.com/439eba782bde9d318d74d5924a304b245842160b/exonerator/innocent_cls_precq_test.py
[modify] https://crrev.com/439eba782bde9d318d74d5924a304b245842160b/main_test.py
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d5cded1697ed1bb40a203e069875e3449778db4f

commit d5cded1697ed1bb40a203e069875e3449778db4f
Author: David Burger <dburger@chromium.org>
Date: Sat Dec 01 23:44:23 2018

Stop generating URLs per their "waterfall"

Stop generating dashboard URLs per their "waterfall" since waterfall
no longer exists as a concept for ToT builds that are now on swarming.
The main change here is expecting builds to have a buildbucket_id and
when they do not (local tryjob only?) generate a URL with "fake_bb_id"
where the buildbucket_id would have been.

TEST=chromite/run_tests
BUG=chromium:836551

Change-Id: I53ae1930b9f8bae1a21cf458aa92f9a672d9305b
Reviewed-on: https://chromium-review.googlesource.com/1337430
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>

[modify] https://crrev.com/d5cded1697ed1bb40a203e069875e3449778db4f/cbuildbot/validation_pool.py
[modify] https://crrev.com/d5cded1697ed1bb40a203e069875e3449778db4f/cbuildbot/validation_pool_unittest.py
[modify] https://crrev.com/d5cded1697ed1bb40a203e069875e3449778db4f/lib/const/waterfall.py
[modify] https://crrev.com/d5cded1697ed1bb40a203e069875e3449778db4f/cbuildbot/cbuildbot_run_unittest.py
[modify] https://crrev.com/d5cded1697ed1bb40a203e069875e3449778db4f/lib/tree_status.py
[modify] https://crrev.com/d5cded1697ed1bb40a203e069875e3449778db4f/cbuildbot/stages/generic_stages_unittest.py
[modify] https://crrev.com/d5cded1697ed1bb40a203e069875e3449778db4f/cbuildbot/cbuildbot_run.py
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6c3c3ca3c7c184e9e3ea25707f1b7bcb765ed244

commit 6c3c3ca3c7c184e9e3ea25707f1b7bcb765ed244
Author: David Burger <dburger@chromium.org>
Date: Tue Dec 04 04:32:00 2018

Remove now unused lib/const/waterfall.py constants

Trim back the contents of lib/const/waterfall.py per
other recent waterfall constant code reductions -
removing all now unused constants from the file.

TEST=./run_tests
BUG=chromium:836551
Change-Id: I152582e0763982f973b92533effd21d7b804e374
Reviewed-on: https://chromium-review.googlesource.com/1359017
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/6c3c3ca3c7c184e9e3ea25707f1b7bcb765ed244/lib/const/waterfall.py
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1b63735bf490b1c2d5a3e990dd2059b4ff76d3f3

commit 1b63735bf490b1c2d5a3e990dd2059b4ff76d3f3
Author: David Burger <dburger@chromium.org>
Date: Mon Dec 17 00:26:19 2018

Remove unused waterfall WATERFALL_RELEASE and related code

Remove the no longer relevant at ToT waterfall.WATERFALL_RELEASE constant and the
related code. The 'pre_flight_branch' derived configs are now all scheduled via luci
scheduler thus the simplifications around the construction of the RequestBuild in
scheduler_stages.py. That is, only the internal swarming bucket, and no specific
luci_builder override, are required.

BUG=chromium:836551
TEST=./config/chromeos_config_unittest -u
TEST=./run_tests

Change-Id: Ide0c5a51f95e365f97a4155e394b7958e91ca06b
Reviewed-on: https://chromium-review.googlesource.com/1376671
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/1b63735bf490b1c2d5a3e990dd2059b4ff76d3f3/config/chromeos_config.py
[modify] https://crrev.com/1b63735bf490b1c2d5a3e990dd2059b4ff76d3f3/cbuildbot/stages/scheduler_stages.py
[modify] https://crrev.com/1b63735bf490b1c2d5a3e990dd2059b4ff76d3f3/lib/const/waterfall.py
[modify] https://crrev.com/1b63735bf490b1c2d5a3e990dd2059b4ff76d3f3/cbuildbot/stages/scheduler_stages_unittest.py
[modify] https://crrev.com/1b63735bf490b1c2d5a3e990dd2059b4ff76d3f3/config/config_dump.json
[modify] https://crrev.com/1b63735bf490b1c2d5a3e990dd2059b4ff76d3f3/lib/buildbucket_lib.py
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d3b34642b60cf688e1ae18dcca4a4a155501aadf

commit d3b34642b60cf688e1ae18dcca4a4a155501aadf
Author: David Burger <dburger@chromium.org>
Date: Wed Dec 19 05:33:23 2018

Remove unused active_waterfall value from config

Remove the now unused active_waterfall value from the config_lib dict
and thus remove it from the materialized config_dump.json.

BUG=chromium:836551
TEST=./config/chromeos_config_unittest -u
TEST=./run_tests

Change-Id: I82fc117915b33f719ff0d3c9feede07e2ec30054
Reviewed-on: https://chromium-review.googlesource.com/1380631
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: David Burger <dburger@chromium.org>

[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/config/chromeos_config.py
[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/lib/const/waterfall.py
[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/cbuildbot/stages/scheduler_stages_unittest.py
[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/lib/config_lib.py
[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/cbuildbot/validation_pool_unittest.py
[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/config/config_dump.json
[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/config/chromeos_config_unittest.py
[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/cbuildbot/build_status_unittest.py
[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/cbuildbot/stages/generic_stages_unittest.py
[modify] https://crrev.com/d3b34642b60cf688e1ae18dcca4a4a155501aadf/lib/config_lib_unittest.py
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/68aea51103a9cb4e036a6bb574d28e02f3a4acad

commit 68aea51103a9cb4e036a6bb574d28e02f3a4acad
Author: David Burger <dburger@chromium.org>
Date: Thu Dec 20 18:03:49 2018

Remove unused buildbot-master-name metadata dict setting

Remove the unused setting of the metadata dict value under the key
buildbot-master-name. This also opens up the removal of some of the
waterfall.py constant use for dead waterfalls as mentioned in the
associated bug.

TEST=./run_tests
BUG=chromium:836551

Change-Id: Ia4e4615bcb9abb54ef3297d9015b7219c7076c23
Reviewed-on: https://chromium-review.googlesource.com/1382936
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: David Burger <dburger@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/68aea51103a9cb4e036a6bb574d28e02f3a4acad/cbuildbot/stages/report_stages.py
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/61c192b19b7974f3ced48ec339cd0bdea81702a7

commit 61c192b19b7974f3ced48ec339cd0bdea81702a7
Author: David Burger <dburger@chromium.org>
Date: Fri Dec 28 14:04:41 2018

Remove buildbot-url metadata and render logdog log links

Remove the setting of the unused "buildbot-url" metadata value and
associated fallout. Namely, link generation to logs switches to pointing
at logdog instead of deprecated buildbot URLs.

Note that as for the removal of the setting of "buildbot-master-name"
metadata in process in https://crrev.com/c/1382936, this value is
presumed to be unused as a metadata value by GE legoland as it does not
exist in their metadata POJO schema in:

http://google3/java/com/google/chrome/crosbuilds/pipeline/gae/server/ingesters/schemas/BuildMetadata.java?l=1&rcl=192651642

TEST=./run_tests
BUG=chromium:836551

Change-Id: I39f6674cfca2f3a87a979a3529dc980d1286e896
Reviewed-on: https://chromium-review.googlesource.com/1387169
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/61c192b19b7974f3ced48ec339cd0bdea81702a7/cbuildbot/cbuildbot_run.py
[modify] https://crrev.com/61c192b19b7974f3ced48ec339cd0bdea81702a7/lib/tree_status.py
[modify] https://crrev.com/61c192b19b7974f3ced48ec339cd0bdea81702a7/lib/const/waterfall.py
[modify] https://crrev.com/61c192b19b7974f3ced48ec339cd0bdea81702a7/cbuildbot/stages/generic_stages_unittest.py
[modify] https://crrev.com/61c192b19b7974f3ced48ec339cd0bdea81702a7/cbuildbot/stages/report_stages.py
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1716f486f900a76ef3a77d5ef75726d9aef05581

commit 1716f486f900a76ef3a77d5ef75726d9aef05581
Author: David Burger <dburger@chromium.org>
Date: Mon Dec 31 05:47:24 2018

Remove deprecated waterfall.py constants file and associated fallout

Remove the constants holding file waterfall.py which is mainly unused -
one constant still used is moved to the only file that used that value.

TEST=./run_tests
BUG=chromium:836551

Change-Id: I8271bed6abde1387ff4f7b5cf23b2a686b8ae515
Reviewed-on: https://chromium-review.googlesource.com/1392009
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/1716f486f900a76ef3a77d5ef75726d9aef05581/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/1716f486f900a76ef3a77d5ef75726d9aef05581/lib/failure_message_lib_unittest.py
[delete] https://crrev.com/6d9d70995ed555b666dc77c94119b9d62e802a83/lib/const/waterfall.py
[modify] https://crrev.com/1716f486f900a76ef3a77d5ef75726d9aef05581/lib/som.py
[modify] https://crrev.com/1716f486f900a76ef3a77d5ef75726d9aef05581/lib/constants.py
[modify] https://crrev.com/1716f486f900a76ef3a77d5ef75726d9aef05581/lib/failure_message_lib.py
[modify] https://crrev.com/1716f486f900a76ef3a77d5ef75726d9aef05581/lib/failures_lib.py
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/534e18423b9c54ff34676bc6cbfd8edc0ef6653b

commit 534e18423b9c54ff34676bc6cbfd8edc0ef6653b
Author: David Burger <dburger@chromium.org>
Date: Wed Jan 02 21:29:48 2019

Removal of out of date active_waterfall comments in chromeos_config.py

Removal of a couple of out of date active_waterfall comments in
chromeos_config.py. active_waterfall no longer exists as a configuration
value as of
https://chromium.git.corp.google.com/chromiumos/chromite/+/d3b34642b60cf688e1ae18dcca4a4a155501aadf
thus active_waterfall is now an invalid config value.

BUG=chromium:836551
TEST=./run_tests

Change-Id: If7799a8372efc0c102ef55ea085ae855680ded33
Reviewed-on: https://chromium-review.googlesource.com/1393487
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/534e18423b9c54ff34676bc6cbfd8edc0ef6653b/config/chromeos_config.py
►

Sign in to add a comment