New issue
Advanced search Search tips

Issue 836549 link

Starred by 3 users
Status: Started
Owner:
lethalantidote@chromium.org
Cc:
lpalmaro@chromium.org
dmazz...@chromium.org
steimel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 764263
issue 836031
issue 817592


Participants' hotlists:
media-controls-a11y

Show other hotlists

Other hotlists containing this issue:
Modern-Media-Controls
media-controls-a11y


Sign in to add a comment

Media Controls: accessibility: improve verbalisation

Project Member Reported by mlamouri@chromium.org, Apr 25 2018 
Media controls verbalisation is essentially correct but quite redundant. We should improve it. I suggest that we should drop all the code in modules/accessibility/ for media controls and instead use aria attributes on the anonymous shadow dom. It will give us more control.

Comment 1 by mlamouri@chromium.org, Apr 27 2018

Blocking: 817592

Comment 2 by lethalantidote@chromium.org, Sep 27

Blocking: 836031
Owner: lethalantidote@chromium.org

Comment 3 by lethalantidote@chromium.org, Nov 8

Status: Started (was: Available)

Comment 4 by lethalantidote@chromium.org, Nov 12

Blocking: 764263
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c13ccee25976d63d861d4e0385f846dba9affd9

commit 6c13ccee25976d63d861d4e0385f846dba9affd9
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Fri Jan 04 23:42:57 2019

Updates caption button to use aria attributes.

This CL changes the caption button to use by aria attributes instead of
explicitly creating accessibility nodes. It also eliminates some of the
duplicate information heard in TalkBack.

Bug: 836549
Change-Id: If22a232bc67d2e64148b2cfa5ff48da9bd33e855
Reviewed-on: https://chromium-review.googlesource.com/c/1375396
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620108}
[modify] https://crrev.com/6c13ccee25976d63d861d4e0385f846dba9affd9/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/6c13ccee25976d63d861d4e0385f846dba9affd9/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/6c13ccee25976d63d861d4e0385f846dba9affd9/third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
[modify] https://crrev.com/6c13ccee25976d63d861d4e0385f846dba9affd9/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
[modify] https://crrev.com/6c13ccee25976d63d861d4e0385f846dba9affd9/third_party/blink/renderer/modules/media_controls/elements/media_control_toggle_closed_captions_button_element.cc
[modify] https://crrev.com/6c13ccee25976d63d861d4e0385f846dba9affd9/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
[add] https://crrev.com/6c13ccee25976d63d861d4e0385f846dba9affd9/third_party/blink/web_tests/media/controls/accessibility-caption-button.html
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f7e5ce754f58f5fb3f02e748e6ae45dcffbb33a

commit 3f7e5ce754f58f5fb3f02e748e6ae45dcffbb33a
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Jan 10 01:55:45 2019

Adds aria attributes directly to fullscreen button.

This CL changes the fullscreen button to use by aria attributes instead of
explicitly creating accessibility nodes.

Bug: 836549
Change-Id: I147d629445aff9f76cd0346d8dee2c47b79a6f30
Reviewed-on: https://chromium-review.googlesource.com/c/1392488
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621414}
[modify] https://crrev.com/3f7e5ce754f58f5fb3f02e748e6ae45dcffbb33a/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/3f7e5ce754f58f5fb3f02e748e6ae45dcffbb33a/third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
[modify] https://crrev.com/3f7e5ce754f58f5fb3f02e748e6ae45dcffbb33a/third_party/blink/renderer/modules/media_controls/elements/media_control_fullscreen_button_element.cc
[modify] https://crrev.com/3f7e5ce754f58f5fb3f02e748e6ae45dcffbb33a/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
[add] https://crrev.com/3f7e5ce754f58f5fb3f02e748e6ae45dcffbb33a/third_party/blink/web_tests/media/controls/accessibility-fullscreen-button.html
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8bca58a70e4758539e3151146e84e9bb318ca1b

commit c8bca58a70e4758539e3151146e84e9bb318ca1b
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Jan 10 08:54:23 2019

Adds aria attributes directly to download button.

This CL changes the download button to use by aria attributes instead of
explicitly creating accessibility nodes.

Bug: 836549
Change-Id: I862fe03106ab523fd1f0fce5920aa3e6fad52265
Reviewed-on: https://chromium-review.googlesource.com/c/1391865
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621509}
[modify] https://crrev.com/c8bca58a70e4758539e3151146e84e9bb318ca1b/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/c8bca58a70e4758539e3151146e84e9bb318ca1b/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.cc
[modify] https://crrev.com/c8bca58a70e4758539e3151146e84e9bb318ca1b/third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
[modify] https://crrev.com/c8bca58a70e4758539e3151146e84e9bb318ca1b/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element_test.cc
[add] https://crrev.com/c8bca58a70e4758539e3151146e84e9bb318ca1b/third_party/blink/web_tests/media/controls/accessibility-download-button.html
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47920dc0ecc0d598c85769035a01eb10fb8c764e

commit 47920dc0ecc0d598c85769035a01eb10fb8c764e
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Fri Jan 11 01:14:33 2019

Adds aria attributes directly to mute button

This CL changes the mute button to use by aria attributes instead of
explicitly creating accessibility nodes.

Bug: 836549
Change-Id: I717bc083e34cebe4d6a9810ba6045649f0f42835
Reviewed-on: https://chromium-review.googlesource.com/c/1392490
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621843}
[modify] https://crrev.com/47920dc0ecc0d598c85769035a01eb10fb8c764e/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/47920dc0ecc0d598c85769035a01eb10fb8c764e/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.cc
[modify] https://crrev.com/47920dc0ecc0d598c85769035a01eb10fb8c764e/third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
[modify] https://crrev.com/47920dc0ecc0d598c85769035a01eb10fb8c764e/third_party/blink/renderer/modules/media_controls/elements/media_control_fullscreen_button_element.cc
[modify] https://crrev.com/47920dc0ecc0d598c85769035a01eb10fb8c764e/third_party/blink/renderer/modules/media_controls/elements/media_control_mute_button_element.cc
[modify] https://crrev.com/47920dc0ecc0d598c85769035a01eb10fb8c764e/third_party/blink/renderer/modules/media_controls/elements/media_control_toggle_closed_captions_button_element.cc
[add] https://crrev.com/47920dc0ecc0d598c85769035a01eb10fb8c764e/third_party/blink/web_tests/media/controls/accessibility-mute-button.html
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/515532174f49a484b81c4c5eea7f1af13c99cd7e

commit 515532174f49a484b81c4c5eea7f1af13c99cd7e
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Fri Jan 11 07:20:45 2019

Adds aria attributes directly to play button

This CL changes the play button to use by aria attributes instead of
explicitly creating accessibility nodes.

Bug: 836549
Change-Id: I08d2b5fd59424388d93ec485a4e3fd7fa7e98e9e
Reviewed-on: https://chromium-review.googlesource.com/c/1394714
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621933}
[modify] https://crrev.com/515532174f49a484b81c4c5eea7f1af13c99cd7e/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/515532174f49a484b81c4c5eea7f1af13c99cd7e/third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
[modify] https://crrev.com/515532174f49a484b81c4c5eea7f1af13c99cd7e/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
[modify] https://crrev.com/515532174f49a484b81c4c5eea7f1af13c99cd7e/third_party/blink/renderer/modules/media_controls/elements/media_control_picture_in_picture_button_element.cc
[modify] https://crrev.com/515532174f49a484b81c4c5eea7f1af13c99cd7e/third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.cc
[add] https://crrev.com/515532174f49a484b81c4c5eea7f1af13c99cd7e/third_party/blink/web_tests/media/controls/accessibility-play-button.html
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/364558ac95b388e2e51be4fa56ab91cfe556ab0e

commit 364558ac95b388e2e51be4fa56ab91cfe556ab0e
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Tue Jan 15 03:20:53 2019

Updates captions menu to use aria attributes.

This CL adds aria attributes to the closed captions menu. Previously there was very little
screenreader functionality for this menu. Now users will be able to know what menu they
are in, which button closes the menu, and be able to select each option while obtaining
relative positioning information for each.

Bug: 836549
Change-Id: Ib8177d9d1d1f559939333a246aff23a345c110eb
Reviewed-on: https://chromium-review.googlesource.com/c/1379178
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622708}
[modify] https://crrev.com/364558ac95b388e2e51be4fa56ab91cfe556ab0e/content/app/strings/content_strings.grd
[modify] https://crrev.com/364558ac95b388e2e51be4fa56ab91cfe556ab0e/content/child/blink_platform_impl.cc
[modify] https://crrev.com/364558ac95b388e2e51be4fa56ab91cfe556ab0e/third_party/blink/public/platform/web_localized_string.h
[modify] https://crrev.com/364558ac95b388e2e51be4fa56ab91cfe556ab0e/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify] https://crrev.com/364558ac95b388e2e51be4fa56ab91cfe556ab0e/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify] https://crrev.com/364558ac95b388e2e51be4fa56ab91cfe556ab0e/third_party/blink/renderer/modules/media_controls/elements/media_control_text_track_list_element.cc
[modify] https://crrev.com/364558ac95b388e2e51be4fa56ab91cfe556ab0e/third_party/blink/renderer/modules/media_controls/elements/media_control_toggle_closed_captions_button_element.cc
[modify] https://crrev.com/364558ac95b388e2e51be4fa56ab91cfe556ab0e/third_party/blink/web_tests/media/controls/accessibility-caption-button.html
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 19 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61348b6f02c3a00699cc39b0a85005fc876fcf7f

commit 61348b6f02c3a00699cc39b0a85005fc876fcf7f
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Sat Jan 19 01:18:27 2019

Updates time values to use aria attributes.

This CL changes the TimeRemaining and TimeElapsed values to use aria
attributes directly instead of explicitly creating accessibility nodes.

Bug: 836549
Change-Id: I7036d9e0a2b8f956f3c88bc9e838e2001830400b
Reviewed-on: https://chromium-review.googlesource.com/c/1393843
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624397}
[modify] https://crrev.com/61348b6f02c3a00699cc39b0a85005fc876fcf7f/content/app/strings/content_strings.grd
[modify] https://crrev.com/61348b6f02c3a00699cc39b0a85005fc876fcf7f/content/test/data/accessibility/html/audio-expected-auralinux.txt
[modify] https://crrev.com/61348b6f02c3a00699cc39b0a85005fc876fcf7f/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/61348b6f02c3a00699cc39b0a85005fc876fcf7f/third_party/blink/renderer/modules/media_controls/elements/media_control_current_time_display_element.cc
[modify] https://crrev.com/61348b6f02c3a00699cc39b0a85005fc876fcf7f/third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
[modify] https://crrev.com/61348b6f02c3a00699cc39b0a85005fc876fcf7f/third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.cc
[modify] https://crrev.com/61348b6f02c3a00699cc39b0a85005fc876fcf7f/third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.cc
[modify] https://crrev.com/61348b6f02c3a00699cc39b0a85005fc876fcf7f/third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.h
[add] https://crrev.com/61348b6f02c3a00699cc39b0a85005fc876fcf7f/third_party/blink/web_tests/media/controls/accessibility-time-element.html
[modify] https://crrev.com/61348b6f02c3a00699cc39b0a85005fc876fcf7f/third_party/blink/web_tests/media/media-controls.js
Project Member

Comment 12 by bugdroid1@chromium.org, Yesterday (37 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa

commit 35bd215f5821e246dbcfa69ea0cc00903fc9c6fa
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Jan 21 23:27:45 2019

Revert "Updates time values to use aria attributes."

This reverts commit 61348b6f02c3a00699cc39b0a85005fc876fcf7f.

Reason for revert: crbug.com/923887 causing flakiness in
DumpAccessibilityTreeTest.AccessibilityAudio

Original change's description:
> Updates time values to use aria attributes.
> 
> This CL changes the TimeRemaining and TimeElapsed values to use aria
> attributes directly instead of explicitly creating accessibility nodes.
> 
> Bug: 836549
> Change-Id: I7036d9e0a2b8f956f3c88bc9e838e2001830400b
> Reviewed-on: https://chromium-review.googlesource.com/c/1393843
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#624397}

TBR=dmazzoni@chromium.org,alexmos@chromium.org,lethalantidote@chromium.org,steimel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 836549, 923887
Change-Id: Ia9e8cf1717de8e27e3708767f00c329d74bcc239
Reviewed-on: https://chromium-review.googlesource.com/c/1426162
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624691}
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/content/app/strings/content_strings.grd
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/content/test/data/accessibility/html/audio-expected-auralinux.txt
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/media_controls/elements/media_control_current_time_display_element.cc
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.cc
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.cc
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.h
[delete] https://crrev.com/45ce00a7dc3fb08046922af7d626464fe0dc0932/third_party/blink/web_tests/media/controls/accessibility-time-element.html
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/web_tests/media/media-controls.js
►

Sign in to add a comment