Refactor ARCoreDevice's usage of MailboxToSurfaceBridge to make initialization and threads cleaner |
|||||||||||
Issue descriptionWe need to change MailboxToSurfaceBridge / ARCore's usage of it in order to clean things up. This task includes refactoring ARCoreDevice into two classes - one that implements the ARCoreDriverAPI and lives on the GL thread and the other that handles calls to/from blink and lives on the UI thread. This will make the usage of threads clearer and hopefully clean up the code substantially - needing less callbacks etc. klausw@ and lincolnfrog@ have plans for this: The current usage in WebVR requires setting a surface on it before creating the context provider. I'm in favor of refactoring this, i.e. by adding multiple constructors, or by splitting into a context-establishing class that passes a freshly created method-providing class to OnMailboxBridge ready.
,
Apr 25 2018
,
Apr 26 2018
We should be able to eliminate mailbox_bridge_, which only exists to hold onto the object until an initialization callback is called.
,
Apr 27 2018
Specifically, it'd be nice to not have two separate paths and member variables in the same class: 1. CreateAndBindContextProvider / on_context_bound_ 2. CreateUnboundContextProvider / BindContextProviderToCurrentThread/ on_context_provider_ready_
,
Apr 27 2018
Rename DestroyContext() for more accuracy
,
Apr 28 2018
See the two comment threads at https://crrev.com/c/1005627/19/chrome/browser/android/vr/arcore_device/arcore_device.cc#65.
,
Jul 4
,
Jul 11
,
Jul 11
,
Jul 11
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
,
Sep 4
,
Jan 9
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by lincolnfrog@chromium.org
, Apr 25 2018