See if FlushPendingWork in LayerTreeResourceProvider::PrepareSendToParent is necessary |
|
Issue descriptionIt's not needed for correctness (if we need to VerifySyncTokensCHROMIUM, it will flush if needed, and otherwise the OrderingBarriers and/or SyncTokens already needed/present are enough for synchronization). It does have a side effect of flushing prepaint work once a frame (in addition to the TileManager flushes), but it's not clear that it provides more benefits than the cost (the extra IPC).
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f7fef260cb30489018c513a827cd42556259c15 commit 2f7fef260cb30489018c513a827cd42556259c15 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Fri May 04 01:48:37 2018 Wait on compositor sync token after rescheduling cancelled raster task Raster tasks can be cancelled between being scheduled and running. When a resource is used for the first time, we create its texture and mailbox on the compositor context, and expect the worker context to wait on a sync token. If the task is cancelled before running, the sync token will be lost and never waited on. This CL stores the sync token in GpuBacking::returned_sync_token, and simplifies the code for passing the sync token to RasterBufferImpl. Test: RasterBufferProviderTest.WaitOnSyncTokenAfterReschedulingTask Bug: 836497 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4cf9be7909659a6a0bfdca44b9251539dd448d57 Reviewed-on: https://chromium-review.googlesource.com/1041142 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555956} [modify] https://crrev.com/2f7fef260cb30489018c513a827cd42556259c15/cc/raster/gpu_raster_buffer_provider.cc [modify] https://crrev.com/2f7fef260cb30489018c513a827cd42556259c15/cc/raster/gpu_raster_buffer_provider.h [modify] https://crrev.com/2f7fef260cb30489018c513a827cd42556259c15/cc/raster/one_copy_raster_buffer_provider.cc [modify] https://crrev.com/2f7fef260cb30489018c513a827cd42556259c15/cc/raster/one_copy_raster_buffer_provider.h [modify] https://crrev.com/2f7fef260cb30489018c513a827cd42556259c15/cc/raster/raster_buffer_provider_unittest.cc [modify] https://crrev.com/2f7fef260cb30489018c513a827cd42556259c15/cc/resources/resource_pool.h
,
May 7 2018
The above CL is for issue 836230 . |
|
►
Sign in to add a comment |
|
Comment 1 by piman@chromium.org
, May 2 2018