Support multiple AR sessions simultaneously |
|||||||||||||
Issue descriptionCurrently, only one AR XRSession is supported at a time. There are various tasks needed to support multiple AR iframes/tabs properly including: Some cleanup in xr_webgl_drawing_buffer.cc::OverwriteColorBufferFromMailboxTexture() and its usage: It would be cleaner to do this calculation in the calling code and just pass in the final size. if source < dest, should we clear, or are sites expected to clear themselves? if source != dest, do we need to make sure to update projection matrices? If so, it might be nice to pass in dest_size here and do that calculation in xr code so we know the right projection matrix. use ShrunkTo - copy_size = size_in.ShrunkTo(size_) to replace the two std::min lines Anchors need to be filtered by session so sessions can't see each other's anchors.
,
Apr 26 2018
,
Apr 26 2018
,
Apr 27 2018
We also need make the logic around calculating the image size more sophisticated to handle multiple sessions and potentially a mix of exclusive and non-exclusive sessions. See the image-size calculation in xr_frame_provider.cc::RequestFrame().
,
Apr 28 2018
In particular, there may be a race condition - see the discussion at https://chromium-review.googlesource.com/c/chromium/src/+/1005627/19/third_party/blink/renderer/modules/xr/xr_frame_provider.cc#210.
,
Apr 29 2018
This is something developers might do and could cause problems in the browser process, so we should fix this soon. We should probably file a separate issue here and/or against the explainer regarding anchors.
,
May 5 2018
As far as image sizes are concerned, we're currently rejecting zero-sized images where it's unclear if these would be valid according to the spec. Also, we're rejecting oversized images over an arbitrary threshold, this is intended to help avoid memory exhaustion or bugs related to integer overflow in size calculations. These limits should be revisited based on what the underlying libraries support.
,
May 28 2018
,
Jul 4
,
Jul 11
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
,
Aug 29
This works right now other than for Anchors, which don't exist yet.
,
Aug 29
Closing as a duplicate of 845704 since this works until we add Anchors. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by ddorwin@chromium.org
, Apr 25 2018