Safe Browsing metrics for when isVerifyAppsEnabled fails |
|||
Issue descriptionRight now, we log metrics for user opt-in/opt-out (which is based on SafetyNetClient#isVerifyAppsEnabled). However, our metrics do not distinguish between when the user has opted out vs. when isVerifyAppsEnabled fails (which we still treat as an opt-out). It would be good to expand "SafeBrowsing.WebView.UserOptIn" with an option like "UNABLE_TO_DETERMINE." The API doesn't document when it might fail, but williamluh@ says this can fail when the wrong version of Play is installed, so there's a chance this scenario happens in the wild. We should probably continue to treat this "UNABLE_TO_DETERMINE" scenario as a user opt-out. This bug only suggests differentiating in metrics.
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b430bcc16755a0f55fec69a41950dc8a805fb590 commit b430bcc16755a0f55fec69a41950dc8a805fb590 Author: Nate Fischer <ntfschr@chromium.org> Date: Wed Apr 25 23:25:16 2018 AW: expand user opt-in UMA metric for isVerifyAppsEnabled failures No change to production logic aside from metrics changes. This changes SafeBrowsing.WebView.UserOptIn into an enumerated histogram in order to capture when the underlying API for user consent (SafetyNetClient#isVerifyAppsEnabled) returns neither true nor false, but indicates a failure. Technically, this also covers the case where PlatformServiceBridge#canUseGms() returns false (we also invoke the callback with 'null'), however we don't log UMA metrics in this case anyway. This renames entries in enums.xml for clarity. Bug: 836461 Test: check that metric is logged under chrome://histograms/SafeBrowsing Change-Id: I570e88a66c5955026988ebe05ed6acc55685b0e2 Reviewed-on: https://chromium-review.googlesource.com/1027007 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553817} [modify] https://crrev.com/b430bcc16755a0f55fec69a41950dc8a805fb590/android_webview/java/src/org/chromium/android_webview/AwSafeBrowsingConfigHelper.java [modify] https://crrev.com/b430bcc16755a0f55fec69a41950dc8a805fb590/tools/metrics/histograms/enums.xml [modify] https://crrev.com/b430bcc16755a0f55fec69a41950dc8a805fb590/tools/metrics/histograms/histograms.xml
,
Apr 26 2018
,
May 3 2018
Please do add the manual verification steps if verifiable.Thanks
,
May 14 2018
No verification necessary for metrics, thanks |
|||
►
Sign in to add a comment |
|||
Comment 1 by ramon...@gmail.com
, Apr 24 2018