New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836459 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----
Proj-XR
Proj-XR-VR



Sign in to add a comment

[WebXR Permission indicators] permission toasts show 'Site can use your <feature>' msg even though they were blocked.

Project Member Reported by dbbrooks@chromium.org, Apr 24 2018

Issue description

Chrome Version: 67.0.3396.17
OS: Android O
Device: Pixel 2 XL

What steps will reproduce the problem?
(1)Clear all Chrome data. App Info >Storage >Manage Space >Clear all data.
(2) Grant Chrome all permissions. App Info > Permissions.
(3) Enable WebXR Device PI flag
(4) Go to https://immersive-web.github.io/webxr-samples/tests/permission-request.html and enter VR browsing (Place device in headset.)
(5) Using controller press "Enter VR" button to start presentation.
(6) Click on location icon and click "Allow" when prompted.
(7) Click on camera icon and click "Allow" when prompted.
(8) Press app button on controller to go to VR browsing mode.
(9) Open the Omnibox overflow menu and click the refresh button.
(10) Using controller press "Enter VR" button to start presentation.
(11) After a few seconds, press and hold app button until you see the permissions toasts appear. 
(See screenshot #1 here.) Both camera and location display the "Site can use your <feature>" toasts. 
(12) Press app button on controller to go to VR browsing mode.
(13) Open the Omnibox overflow menu and click on the "New incognito tab" button.
(14) Go to https://immersive-web.github.io/webxr-samples/tests/permission-request.html
(15) Using controller press "Enter VR" button to start presentation.
(16) After a few seconds, press and hold app button until you see the permissions toasts appear. 
(See screenshot #1 here.) Both camera and location display the "Site can use your <feature>" toasts. 
(17) Using controller, select the location icon and click "Block" on the following prompt.
(18) Using controller, select the microphone icon and click "Block" on the following prompt.
(19) Press and hold app button until you see the permissions toasts appear.
<-- BUG -->(See screenshot #2 here.) Both camera and location still display the same "Site can use your <feature>" toasts. 


What is the expected result? I'd expect there to be a message like "Background tab can use your <feature>".

What happens instead? Even after blocking the permissions through the UI on the incognito tab, the "Site can use your <feature>" message still appears.

 
Screenshot_1.png
582 KB View Download
Screenshot_2.png
600 KB View Download
Owner: vollick@chromium.org
Status: Assigned (was: Untriaged)
Over to Ian who implemented this. Feel free to redirect.
Cc: vollick@chromium.org
Owner: asimjour@chromium.org
Amir, can you PTAL?
Components: Internals>XR
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21d34562409c4cf7b232aa4921118117d4e9eab9

commit 21d34562409c4cf7b232aa4921118117d4e9eab9
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Wed Jul 04 22:05:40 2018

VR: Use local profile for page_info

This only changes the output when the user is browsing off the record.

Bug:  836459 
Change-Id: Ic922cd8d971629bfeb1cc066ce77aa616f14ee57
Reviewed-on: https://chromium-review.googlesource.com/1126453
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572663}
[modify] https://crrev.com/21d34562409c4cf7b232aa4921118117d4e9eab9/chrome/browser/android/vr/vr_shell.cc

Status: Fixed (was: Assigned)

Sign in to add a comment