New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836449 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 847992
issue 814898



Sign in to add a comment

session restore doesn't restore windows correctly with multi displays

Project Member Reported by osh...@chromium.org, Apr 24 2018

Issue description

Repro step:

1) Create and plac two browser windows, one in internal display, another in external display.
2) Log out
3) Log in

Expected:
 two windows should be restored in original position in each displays

Actual:
 two windows are restored in one display.

warx@ can you check if 67 has this issue first?
 
Is this just  issue 834775 ? We are not currently loading DisplayPrefs correctly on startup in 68 (due to https://chromium-review.googlesource.com/c/chromium/src/+/1003379)

I am investigating fixes, hoping to avoid another revert.

Comment 2 by warx@chromium.org, Apr 25 2018

Re #0 and #1, this bug also happens on m67: 67.0.3396.16, so it is not a regression from  issue 834775 .
Cc: msw@chromium.org
OK, so something different, oh joy :)

+msw@ just in case this is mustash related.

Comment 4 by msw@chromium.org, Apr 25 2018

Blocking: 814898
Cc: warx@chromium.org sky@chromium.org est...@chromium.org
Components: Internals>Services>WindowService
Labels: -Pri-1 Pri-2
Owner: msw@chromium.org
Yeah, this only seems to repro if #mus is enabled in about:flags.
Evan, could this be related to Mus' general window positioning?

Otherwise, maybe the external display is being destroyed before closing the window or not initialized before we recreate the window, so it's placed on the internal display as a fallback.

Either way, we're putting the current window service incarnation on hold for now.
This shouldn't reach any release channels (it's only on for local dev builds).
We can reduce priority here for now, and circle back later.

Comment 5 by osh...@chromium.org, Apr 25 2018

Is mus enabled on tot + dev build?


Comment 6 by msw@chromium.org, Apr 25 2018

Yes

Comment 8 by msw@chromium.org, May 14 2018

Blocking: 837684
The new window service as a library will need to solve this before launching.

Comment 9 by ovanieva@google.com, May 14 2018

msw@ who is working on new window service as a library?

Comment 10 by msw@chromium.org, May 14 2018

sky@ is leading the effort with support from jamescook@, estade@, stevenjb@, and myself.

Comment 11 by sky@chromium.org, May 30 2018

Blocking: -837684 847992
This isn't a blocker for 837684, but definitely is something we need to resolve before the browser can convert to WindowService. 847992 is likely a better bug to have this blocking.
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/215736ef840b1d6fb28e57a10fcd38ebc2a617ec

commit 215736ef840b1d6fb28e57a10fcd38ebc2a617ec
Author: Evan Stade <estade@chromium.org>
Date: Tue Sep 04 21:40:12 2018

Mash: place windows on correct displays during session restore.

Bug: 836449
Change-Id: Ic69bffc92dc7a033ae970e81399f16dd0cd64260
Reviewed-on: https://chromium-review.googlesource.com/1205010
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588645}
[modify] https://crrev.com/215736ef840b1d6fb28e57a10fcd38ebc2a617ec/ash/wm/top_level_window_factory.cc

Sign in to add a comment