TwoClientBookmarksSyncTest.FirstClientEnablesEncryptionWithPassSecondChanges is crashing |
|||
Issue descriptionhttps://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=sync_integration_tests&tests=TwoClientBookmarksSyncTest.FirstClientEnablesEncryptionWithPassSecondChanges https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2Flinux-chromeos-rel%2F7221%2F%2B%2Frecipes%2Fsteps%2Fsync_integration_tests%2F0%2Flogs%2FTwoClientBookmarksSyncTest.FirstClientEnablesEncryptionWithPassSecondChanges%2F0 [ RUN ] TwoClientBookmarksSyncTest.FirstClientEnablesEncryptionWithPassSecondChanges [22578:22578:0424/135728.428612:31557259866:WARNING:loopback_server.cc(638)] Loopback sync persistent state file does not exist. [22578:22578:0424/135728.518035:WARNING:chrome_browser_main_chromeos.cc(640)] Running as stub user with profile dir: test-user [22578:22578:0424/135728.569706:WARNING:statistics_provider.cc(330)] Statistics loaded after waiting 0ms. [22578:22603:0424/135728.594545:ERROR:account_manager.cc(37)] Failed to read tokens file [22578:22578:0424/135728.601968:WARNING:user_session_manager.cc(1086)] Attempting to save user password for non enterprise user. [22578:22578:0424/135728.688058:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [22578:22578:0424/135728.689135:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [22578:22578:0424/135728.689699:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [22578:22578:0424/135728.689729:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [22578:22603:0424/135728.760616:ERROR:account_manager.cc(37)] Failed to read tokens file [22578:22578:0424/135728.763535:WARNING:user_session_manager.cc(1086)] Attempting to save user password for non enterprise user. [22578:22606:0424/135728.825092:ERROR:account_manager.cc(37)] Failed to read tokens file [22578:22578:0424/135728.828667:WARNING:user_session_manager.cc(1086)] Attempting to save user password for non enterprise user. [22578:22604:0424/135728.875394:ERROR:account_manager.cc(37)] Failed to read tokens file [22578:22578:0424/135728.878225:WARNING:user_session_manager.cc(1086)] Attempting to save user password for non enterprise user. [22578:22675:0424/135728.947487:WARNING:sync_encryption_handler_impl.cc(970)] Nigori had empty encryption keybag. [22578:22675:0424/135728.947722:WARNING:sync_encryption_handler_impl.cc(970)] Nigori had empty encryption keybag. [22578:22578:0424/135728.950587:ERROR:chrome_signin_client.cc(179)] Device ID is not set for user. [22578:22675:0424/135728.951697:WARNING:sync_encryption_handler_impl.cc(346)] Ignoring new implicit passphrase. Keystore migration already performed. [22578:22578:0424/135728.984654:ERROR:chrome_signin_client.cc(179)] Device ID is not set for user. [22578:22677:0424/135728.985819:WARNING:sync_encryption_handler_impl.cc(346)] Ignoring new implicit passphrase. Keystore migration already performed. [22578:22578:0424/135729.259205:ERROR:bookmarks_helper.cc(384)] Cannot compare folder with bookmark [22578:22578:0424/135729.259223:ERROR:bookmarks_helper.cc(426)] Models do not match. [22578:22578:0424/135729.259228:ERROR:bookmarks_helper.cc(822)] Model 1 does not match the verifier. [22578:22578:0424/135729.269719:ERROR:bookmarks_helper.cc(384)] Cannot compare folder with bookmark [22578:22578:0424/135729.270545:ERROR:bookmarks_helper.cc(426)] Models do not match. [22578:22578:0424/135729.270561:ERROR:bookmarks_helper.cc(822)] Model 1 does not match the verifier. [22578:22578:0424/135729.818022:ERROR:data_type_manager_impl.cc(36)] Bookmarks cryptographer error was encountered: [22578:22578:0424/135729.818062:ERROR:data_type_manager_impl.cc(36)] Preferences cryptographer error was encountered: [22578:22578:0424/135729.818068:ERROR:data_type_manager_impl.cc(36)] Passwords cryptographer error was encountered: [22578:22578:0424/135729.818073:ERROR:data_type_manager_impl.cc(36)] Autofill Profiles cryptographer error was encountered: [22578:22578:0424/135729.818078:ERROR:data_type_manager_impl.cc(36)] Autofill cryptographer error was encountered: [22578:22578:0424/135729.818082:ERROR:data_type_manager_impl.cc(36)] Autofill Wallet Metadata cryptographer error was encountered: [22578:22578:0424/135729.818088:ERROR:data_type_manager_impl.cc(36)] Themes cryptographer error was encountered: [22578:22578:0424/135729.818098:ERROR:data_type_manager_impl.cc(36)] Typed URLs cryptographer error was encountered: [22578:22578:0424/135729.818103:ERROR:data_type_manager_impl.cc(36)] Extensions cryptographer error was encountered: [22578:22578:0424/135729.818108:ERROR:data_type_manager_impl.cc(36)] Search Engines cryptographer error was encountered: [22578:22578:0424/135729.818112:ERROR:data_type_manager_impl.cc(36)] Sessions cryptographer error was encountered: [22578:22578:0424/135729.818116:ERROR:data_type_manager_impl.cc(36)] Apps cryptographer error was encountered: [22578:22578:0424/135729.818121:ERROR:data_type_manager_impl.cc(36)] App settings cryptographer error was encountered: [22578:22578:0424/135729.818125:ERROR:data_type_manager_impl.cc(36)] Extension settings cryptographer error was encountered: [22578:22578:0424/135729.818130:ERROR:data_type_manager_impl.cc(36)] Dictionary cryptographer error was encountered: [22578:22578:0424/135729.818143:ERROR:data_type_manager_impl.cc(36)] Favicon Images cryptographer error was encountered: [22578:22578:0424/135729.818148:ERROR:data_type_manager_impl.cc(36)] Favicon Tracking cryptographer error was encountered: [22578:22578:0424/135729.818152:ERROR:data_type_manager_impl.cc(36)] App List cryptographer error was encountered: [22578:22578:0424/135729.818157:ERROR:data_type_manager_impl.cc(36)] Arc Package cryptographer error was encountered: [22578:22578:0424/135729.818161:ERROR:data_type_manager_impl.cc(36)] Printers cryptographer error was encountered: BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x00000259839c base::debug::StackTrace::StackTrace() #1 0x000005effdb5 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fa815fe0cb0 <unknown> #3 0x000000c37180 <unknown> #4 0x000005fc0618 syncer::ModelTypeRegistry::HasUnsyncedItemsForTest() #5 0x0000023f16e8 ProgressMarkerWatcher::UpdateHasLatestProgressMarkers() #6 0x0000023f182e ProgressMarkerWatcher::OnStateChanged() #7 0x000004540e81 browser_sync::ProfileSyncService::NotifySyncCycleCompleted() #8 0x000004541aa8 browser_sync::ProfileSyncService::OnSyncCycleCompleted() #9 0x000005faf196 syncer::SyncBackendHostImpl::HandleSyncCycleCompletedOnFrontendLoop() #10 0x00000251effc base::debug::TaskAnnotator::RunTask() #11 0x000002532ee7 base::MessageLoop::RunTask() #12 0x000002533398 base::MessageLoop::DoWork() #13 0x0000025a48d9 base::MessagePumpLibevent::Run() #14 0x00000254fed5 base::RunLoop::Run() #15 0x0000023f5f36 StatusChangeChecker::StartBlockingWait() #16 0x0000023f5e4b StatusChangeChecker::Wait() #17 0x0000023f0fb0 ProfileSyncServiceHarness::AwaitQuiescence() #18 0x0000023f0e7b ProfileSyncServiceHarness::AwaitMutualSyncCycleCompletion() #19 0x0000004a7a76 TwoClientBookmarksSyncTest_FirstClientEnablesEncryptionWithPassSecondChanges_Test::RunTestOnMainThread()
,
Apr 24 2018
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/664491ff6b00fa55596e793d0973c2f0232180ec commit 664491ff6b00fa55596e793d0973c2f0232180ec Author: Lei Zhang <thestig@chromium.org> Date: Tue Apr 24 21:50:16 2018 Disable a crashing TwoClientBookmarksSyncTest. BUG= 836426 TBR=skym@chromium.org NOTRY=true Change-Id: Ie9c07c1417ab693d517e1ac4ee3dc8082465a58a Reviewed-on: https://chromium-review.googlesource.com/1026790 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#553299} [modify] https://crrev.com/664491ff6b00fa55596e793d0973c2f0232180ec/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
,
Apr 25 2018
Issue 836660 has been merged into this issue.
,
Apr 25 2018
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/207d426e0e93a8396a7e94940aebce605bf1089f commit 207d426e0e93a8396a7e94940aebce605bf1089f Author: Mikel Astiz <mastiz@chromium.org> Date: Thu Apr 26 18:05:04 2018 Fix sync test flakiness due to checker races QuiesceStatusChangeChecker and UpdatedProgressMarkerChecker had known and well documented limitations leading to test flakiness, mainly due to HasUnsyncedItemsForTest() being run outside sync thread and hence potentially taking over queued (USS) or ongoing (directory) local changes (and returning false negatives). We solve this by making the function asynchronous and the actual implementation posting a task to the sync thread. This also acts as a logic barrier that provides better semantics to checkers (as newly documented). In line with this, we also report this bit (HasUnsyncedItems) as part of the sync cycle snapshot, because it's often sufficient to verify the value for the last sync cycle, and simple to reason about. Change-Id: I5db9ade11520394f801ab429457357f00ad132b0 Bug: 836289 , 836426 Change-Id: I5db9ade11520394f801ab429457357f00ad132b0 Reviewed-on: https://chromium-review.googlesource.com/1029853 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554080} [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/profile_sync_service_harness.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/profile_sync_service_harness.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/quiesce_status_change_checker.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/single_client_status_change_checker.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/status_change_checker.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/sync_auth_test.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/updated_progress_marker_checker.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/updated_progress_marker_checker.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/autofill/core/browser/test_sync_service.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/browser_sync/profile_sync_service_unittest.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/suggestions/suggestions_service_impl_unittest.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/driver/glue/sync_backend_host_core.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/driver/glue/sync_backend_host_core.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/driver/glue/sync_backend_host_impl.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/driver/glue/sync_backend_host_impl.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/driver/sync_service_utils_unittest.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/cycle/sync_cycle_snapshot.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/cycle/sync_cycle_snapshot.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/cycle/sync_cycle_snapshot_unittest.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/fake_sync_engine.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/fake_sync_engine.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/sync_engine.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine_impl/cycle/sync_cycle.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine_impl/js_sync_manager_observer_unittest.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine_impl/model_type_registry.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine_impl/model_type_registry.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine_impl/sync_manager_impl.cc
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c0ae29c8ce1ac95e228f9d319a55217bf2fc4dd commit 1c0ae29c8ce1ac95e228f9d319a55217bf2fc4dd Author: Mikel Astiz <mastiz@chromium.org> Date: Fri Apr 27 10:22:06 2018 Revert "Disable a crashing TwoClientBookmarksSyncTest." This reverts commit 664491ff6b00fa55596e793d0973c2f0232180ec. Reason for revert: the underlying issue is believed to be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/1029853 Original change's description: > Disable a crashing TwoClientBookmarksSyncTest. > > BUG= 836426 > TBR=skym@chromium.org > NOTRY=true > > Change-Id: Ie9c07c1417ab693d517e1ac4ee3dc8082465a58a > Reviewed-on: https://chromium-review.googlesource.com/1026790 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553299} TBR=thestig@chromium.org,skym@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836426 Change-Id: I53b2cac1ee6720cbbbd9d2650292cac6cc551bfe Reviewed-on: https://chromium-review.googlesource.com/1032411 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554350} [modify] https://crrev.com/1c0ae29c8ce1ac95e228f9d319a55217bf2fc4dd/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
,
Apr 27 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thestig@chromium.org
, Apr 24 2018