New issue
Advanced search Search tips

Issue 836424 link

Starred by 4 users
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: May 2018
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 821991



Sign in to add a comment

Hovered tabs should be drawn on top of inactive tabs in Material Refresh

Project Member Reported by pbos@chromium.org, Apr 24 2018 
Without the 1px dividers the current drawing order is really unintuitive, the new tabs look like speech bubbles.

We should in order:

* Draw inactive tab(s)
* Draw hovered tab(s)
* Draw active tab(s)
speechbubble.png
7.0 KB View Download

Comment 1 by kylixrd@chromium.org, Apr 26 2018

Status: Available (was: Untriaged)

Comment 2 by kylixrd@chromium.org, May 7 2018

Blocking: 821991
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89b341c5edc3af1ab9aa66581f05e12d3e4c6a1c

commit 89b341c5edc3af1ab9aa66581f05e12d3e4c6a1c
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue May 08 17:18:44 2018

Material Refresh - ensure the currently hovered tab is always painted on top of all the other inactive tabs, but not the active tab.

Paint the inactive tab which is hovered right before the active tab so it appears above the others but not the active tab.

Bug:  836424 
Change-Id: Ic21e72177de41f793425de48f231031efed136a8
Reviewed-on: https://chromium-review.googlesource.com/1048172
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556846}
[modify] https://crrev.com/89b341c5edc3af1ab9aa66581f05e12d3e4c6a1c/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/89b341c5edc3af1ab9aa66581f05e12d3e4c6a1c/chrome/browser/ui/views/tabs/tab_strip.h

Comment 4 by kylixrd@chromium.org, May 8 2018

Status: Fixed (was: Available)
►

Sign in to add a comment