New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836417 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 836413

Blocking:
issue 836319
issue 836419
issue 893267



Sign in to add a comment

Modify flag names in base_test_launcher so that they are the same among test harnesses

Project Member Reported by chanli@chromium.org, Apr 24 2018

Issue description

Background: https://bugs.chromium.org/p/chromium/issues/detail?id=836413

After we get consensus on what should be the names for the flags across all test harnesses, we should update the flag names in //base/test/launcher.
 

Comment 1 by chanli@chromium.org, Apr 24 2018

Blocking: 836419

Comment 2 by chanli@chromium.org, Apr 24 2018

Description: Show this description

Comment 3 by chanli@chromium.org, Apr 24 2018

Blocking: 836319

Comment 4 by chanli@chromium.org, Apr 24 2018

Cc: dpranke@chromium.org shenghua...@chromium.org kbr@chromium.org nednguyen@chromium.org
Owner: st...@chromium.org
Status: Assigned (was: Available)
Blocking: 893267
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64dcd46a5214226235b1184e79cf7a57045f2e52

commit 64dcd46a5214226235b1184e79cf7a57045f2e52
Author: Shuotao Gao <stgao@chromium.org>
Date: Tue Oct 16 19:06:28 2018

Add --isolated-script-test-* to gtest launcher

As part of the effort to make all test harness supported by Findit,
this CL adds four new flags that are unified across different test harness:
1. --isolated-script-test-filter=test1::test2::test3
2. --isolated-script-test-repeat=30
3. --isolated-script-test-launcher-retry-limit=0
4. --isolated-script-test-also-run-disabled-tests

For test filter, both ":" and "::" are supported.

Bug:  836417 
Change-Id: Ie931812ade9899a2b2ae1a97bdac215ed9e0ea73
Reviewed-on: https://chromium-review.googlesource.com/c/1272655
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600063}
[modify] https://crrev.com/64dcd46a5214226235b1184e79cf7a57045f2e52/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/64dcd46a5214226235b1184e79cf7a57045f2e52/base/test/launcher/test_launcher.h
[modify] https://crrev.com/64dcd46a5214226235b1184e79cf7a57045f2e52/base/test/test_switches.cc
[modify] https://crrev.com/64dcd46a5214226235b1184e79cf7a57045f2e52/base/test/test_switches.h
[modify] https://crrev.com/64dcd46a5214226235b1184e79cf7a57045f2e52/remoting/test/app_remoting_test_driver.cc
[modify] https://crrev.com/64dcd46a5214226235b1184e79cf7a57045f2e52/remoting/test/chromoting_test_driver.cc

Status: Fixed (was: Assigned)

Sign in to add a comment