New issue
Advanced search Search tips

Issue 836416 link

Starred by 3 users
Status: Fixed
Owner:
fdegans@chromium.org
Closed: May 2018
Cc:
sergeyu@chromium.org
w...@chromium.org
kmarshall@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 812974



Sign in to add a comment

Stop defining OS_POSIX for Fuchsia

Project Member Reported by fdegans@chromium.org, Apr 24 2018 
We want to stop defining OS_POSIX for Fuchsia.
A working CL is available here: https://chromium-review.googlesource.com/c/chromium/src/+/1020375

I am writing a document referencing how I believe we should handle platform switch conditions to unify them once and for all.

The plan to submit the change is similar to how the is_posix change in the build files was handled:
1. Submit as many changes as possible separately from the main CL
2. Switch OS_POSIX to be undefined for Fuchsia
3. Clean up, remove defined(OS_POSIX) && !defined(OS_FUCHSIA) in particular.

Comment 1 by fdegans@chromium.org, Apr 27 2018 

I added a section to the document, explaining the choices I believe we should be making in this case.
https://docs.google.com/document/d/13Ft6KsZ12C97QUdNn7lwCjLmX2WVJfnhkhyoTXiC9JI/edit#heading=h.ywiwq620es2s
plz like subscribe and comment

I'm starting to cut up the big change in smaller chunks that are still quite big.
Project Member

Comment 2 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91fa35058875ed706548b9ee1c549ea235b8aaf2

commit 91fa35058875ed706548b9ee1c549ea235b8aaf2
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Mon May 07 19:33:48 2018

Fuchsia: Prepare for OS_POSIX removal in content/

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug:  836416 
Change-Id: I6a1be5e8a6824dd4442e8f1beb54b2c23bc78b6c
Reviewed-on: https://chromium-review.googlesource.com/1033330
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556530}
[modify] https://crrev.com/91fa35058875ed706548b9ee1c549ea235b8aaf2/content/app/content_main_runner.cc
[modify] https://crrev.com/91fa35058875ed706548b9ee1c549ea235b8aaf2/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/91fa35058875ed706548b9ee1c549ea235b8aaf2/content/browser/download/save_package.cc
[modify] https://crrev.com/91fa35058875ed706548b9ee1c549ea235b8aaf2/content/browser/download/save_package_unittest.cc
[modify] https://crrev.com/91fa35058875ed706548b9ee1c549ea235b8aaf2/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/91fa35058875ed706548b9ee1c549ea235b8aaf2/content/child/blink_platform_impl.cc
[modify] https://crrev.com/91fa35058875ed706548b9ee1c549ea235b8aaf2/content/common/user_agent.cc
[modify] https://crrev.com/91fa35058875ed706548b9ee1c549ea235b8aaf2/content/renderer/render_view_impl.h
Project Member

Comment 3 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbce434f4ac21d4f326f7cc67cf09aa5481f7932

commit cbce434f4ac21d4f326f7cc67cf09aa5481f7932
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Mon May 07 20:02:09 2018

Fuchsia: Prepare for OS_POSIX removal in ipc/

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug:  836416 
Change-Id: I360f993c9848e78ac550b4793e8724061239d604
Reviewed-on: https://chromium-review.googlesource.com/1033956
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556540}
[modify] https://crrev.com/cbce434f4ac21d4f326f7cc67cf09aa5481f7932/ipc/ipc_message_attachment_set.h
[modify] https://crrev.com/cbce434f4ac21d4f326f7cc67cf09aa5481f7932/ipc/ipc_message_utils.cc
[modify] https://crrev.com/cbce434f4ac21d4f326f7cc67cf09aa5481f7932/ipc/ipc_message_utils.h
[modify] https://crrev.com/cbce434f4ac21d4f326f7cc67cf09aa5481f7932/ipc/ipc_platform_file.cc
[modify] https://crrev.com/cbce434f4ac21d4f326f7cc67cf09aa5481f7932/ipc/ipc_platform_file.h
Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/571f573076431cc3c8c13da2d9b37841aee2d783

commit 571f573076431cc3c8c13da2d9b37841aee2d783
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue May 08 03:57:46 2018

Fuchsia: Prepare for OS_POSIX removal in ui/

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug:  836416 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ife9b0b37224aa2f59cc1b907f340388b05c7c477
Reviewed-on: https://chromium-review.googlesource.com/1033996
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556683}
[modify] https://crrev.com/571f573076431cc3c8c13da2d9b37841aee2d783/ui/events/keycodes/keyboard_codes.h
[modify] https://crrev.com/571f573076431cc3c8c13da2d9b37841aee2d783/ui/gfx/gpu_fence_handle.h
[modify] https://crrev.com/571f573076431cc3c8c13da2d9b37841aee2d783/ui/gfx/text_elider.cc
[modify] https://crrev.com/571f573076431cc3c8c13da2d9b37841aee2d783/ui/gl/gl_fence_android_native_fence_sync.cc
Project Member

Comment 5 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3fe6c15f1a461a699321b7f008daf526976351e

commit e3fe6c15f1a461a699321b7f008daf526976351e
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue May 08 18:09:47 2018

Fuchsia: Prepare for OS_POSIX removal in mojo/

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug:  836416 
Change-Id: If44f30dd222572fea1c030a804507f67a1b54e17
Reviewed-on: https://chromium-review.googlesource.com/1033967
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556878}
[modify] https://crrev.com/e3fe6c15f1a461a699321b7f008daf526976351e/chrome/browser/notifications/notification_platform_bridge_mac.mm
[modify] https://crrev.com/e3fe6c15f1a461a699321b7f008daf526976351e/mojo/edk/BUILD.gn
[modify] https://crrev.com/e3fe6c15f1a461a699321b7f008daf526976351e/mojo/edk/embedder/named_platform_handle.h
[add] https://crrev.com/e3fe6c15f1a461a699321b7f008daf526976351e/mojo/edk/embedder/named_platform_handle_posix.h
[add] https://crrev.com/e3fe6c15f1a461a699321b7f008daf526976351e/mojo/edk/embedder/named_platform_handle_win.h
[modify] https://crrev.com/e3fe6c15f1a461a699321b7f008daf526976351e/mojo/edk/embedder/platform_handle.cc
[modify] https://crrev.com/e3fe6c15f1a461a699321b7f008daf526976351e/mojo/edk/embedder/platform_handle.h
[modify] https://crrev.com/e3fe6c15f1a461a699321b7f008daf526976351e/mojo/edk/system/platform_wrapper_unittest.cc
[modify] https://crrev.com/e3fe6c15f1a461a699321b7f008daf526976351e/mojo/public/cpp/system/platform_handle.h
Project Member

Comment 7 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de47372cbcfae05df70938a248b04ce62c94379

commit 7de47372cbcfae05df70938a248b04ce62c94379
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue May 08 20:23:47 2018

Fuchsia: Prepare for OS_POSIX removal in net/

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug:  836416 
Change-Id: Iaedf38b0b5d82121b28b1603233f43553bc5fdf0
Reviewed-on: https://chromium-review.googlesource.com/1033578
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556947}
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/base/file_stream_context.h
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/base/filename_util.cc
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/base/filename_util_internal.cc
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/base/filename_util_unittest.cc
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/base/iovec.h
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/base/sockaddr_storage.h
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/base/sys_addrinfo.h
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/disk_cache/cache_util.cc
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/http/http_auth_preferences.cc
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/http/http_auth_preferences.h
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/quic/platform/impl/quic_ip_address_impl.cc
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/socket/socket_descriptor.cc
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/socket/socket_descriptor.h
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/socket/socket_options.cc
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/socket/tcp_socket.h
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/socket/udp_socket.h
[modify] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/net/url_request/url_request_file_dir_job.cc
Project Member

Comment 8 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe8dfb391b68ce00b3c6e85d4677c07b08bd91e5

commit fe8dfb391b68ce00b3c6e85d4677c07b08bd91e5
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue May 08 20:41:50 2018

Fuchsia: Prepare for OS_POSIX removal in storage/

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug:  836416 
Change-Id: I45af4ff9525a3129c077101ad4e365c79490299e
Reviewed-on: https://chromium-review.googlesource.com/1033969
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556950}
[modify] https://crrev.com/fe8dfb391b68ce00b3c6e85d4677c07b08bd91e5/storage/browser/database/vfs_backend.cc
[modify] https://crrev.com/fe8dfb391b68ce00b3c6e85d4677c07b08bd91e5/storage/common/fileapi/file_system_util.cc
Project Member

Comment 9 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e85048b74396aa02db8f0f5b1acf74f2fd3393e6

commit e85048b74396aa02db8f0f5b1acf74f2fd3393e6
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Wed May 09 19:35:06 2018

Fuchsia: Prepare for OS_POSIX removal in components/

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug:  836416 
Change-Id: Ie49af916b267bc49d4385bf2a1eeadaed860fa16
Reviewed-on: https://chromium-review.googlesource.com/1033954
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557279}
[modify] https://crrev.com/e85048b74396aa02db8f0f5b1acf74f2fd3393e6/components/services/filesystem/util.cc
[modify] https://crrev.com/e85048b74396aa02db8f0f5b1acf74f2fd3393e6/components/url_formatter/url_fixer.cc
Project Member

Comment 10 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/306871de3e87f2d1844952ee730112e1fdabbae4

commit 306871de3e87f2d1844952ee730112e1fdabbae4
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Wed May 16 19:38:39 2018

Fuchsia: Prepare for OS_POSIX removal in base/

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug:  836416 
Change-Id: I3a8e6393d0a9981aa890fb6d8c302ed8d2bdd69d
Reviewed-on: https://chromium-review.googlesource.com/1031099
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559230}
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/allocator/partition_allocator/address_space_randomization.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/allocator/partition_allocator/address_space_randomization.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/allocator/partition_allocator/page_allocator.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/allocator/partition_allocator/spin_lock.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/base_paths.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/command_line.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/command_line.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/command_line_unittest.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/environment.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/environment.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/file.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/file.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/file_enumerator.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/file_path.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/file_path.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/file_path_unittest.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/file_util.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/file_util_unittest.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/platform_file.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/scoped_file.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/files/scoped_file.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/format_macros.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/i18n/file_util_icu.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/logging.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/logging.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/memory/shared_memory.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/memory/shared_memory_handle.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/message_loop/message_loop_current.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/message_loop/message_loop_current.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/metrics/persistent_memory_allocator.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/native_library.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/native_library_unittest.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/process/launch.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/process/process_iterator.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/process/process_util_unittest.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/strings/safe_sprintf.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/strings/string_util.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/sync_socket.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/synchronization/condition_variable.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/synchronization/lock.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/synchronization/lock_impl.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/synchronization/waitable_event.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/threading/platform_thread.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/threading/thread_local_storage.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/threading/thread_local_storage.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/time/pr_time_unittest.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/time/time.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/time/time_unittest.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/trace_event/process_memory_dump.cc
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/trace_event/process_memory_dump.h
[modify] https://crrev.com/306871de3e87f2d1844952ee730112e1fdabbae4/base/trace_event/process_memory_dump_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f86c118d322a2ad437157a71cef8fc43a17d01

commit 90f86c118d322a2ad437157a71cef8fc43a17d01
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri May 18 20:34:17 2018

Fuchsia: Stop setting OS_POSIX

Bug:  836416 
Change-Id: Ib59796358ff2109ec0b55686974a84980e18254e
Reviewed-on: https://chromium-review.googlesource.com/1020375
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560013}
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/base/debug/activity_tracker.cc
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/base/files/file_util.h
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/base/files/file_util_unittest.cc
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/base/memory/shared_memory.h
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/base/memory/shared_memory_handle.h
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/base/process/launch.h
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/base/process/process_iterator.cc
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/base/process/process_unittest.cc
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/base/process/process_util_unittest.cc
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/base/strings/stringprintf_unittest.cc
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/build/build_config.h
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/net/disk_cache/blockfile/rankings.cc
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/sql/connection.cc
[modify] https://crrev.com/90f86c118d322a2ad437157a71cef8fc43a17d01/third_party/leveldatabase/env_chromium.cc
Project Member

Comment 12 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd1301fffdda4fcb3117379788f767b0c42e85d1

commit bd1301fffdda4fcb3117379788f767b0c42e85d1
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri May 18 21:00:09 2018

Revert "Fuchsia: Stop setting OS_POSIX"

This reverts commit 90f86c118d322a2ad437157a71cef8fc43a17d01.

Reason for revert: Broke builders
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio/14741
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64%20Cast%20Audio/14712

Original change's description:
> Fuchsia: Stop setting OS_POSIX
> 
> Bug:  836416 
> Change-Id: Ib59796358ff2109ec0b55686974a84980e18254e
> Reviewed-on: https://chromium-review.googlesource.com/1020375
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Matt Mueller <mattm@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560013}

TBR=kinuko@chromium.org,thakis@chromium.org,mattm@chromium.org,fdegans@chromium.org,scottmg@chromium.org,pwnall@chromium.org

Change-Id: I6f8a28690dddefe8acf99220646def362bdc9bc8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  836416 
Reviewed-on: https://chromium-review.googlesource.com/1066332
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560031}
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/base/debug/activity_tracker.cc
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/base/files/file_util.h
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/base/files/file_util_unittest.cc
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/base/memory/shared_memory.h
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/base/memory/shared_memory_handle.h
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/base/process/launch.h
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/base/process/process_iterator.cc
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/base/process/process_unittest.cc
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/base/process/process_util_unittest.cc
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/base/strings/stringprintf_unittest.cc
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/build/build_config.h
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/net/disk_cache/blockfile/rankings.cc
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/sql/connection.cc
[modify] https://crrev.com/bd1301fffdda4fcb3117379788f767b0c42e85d1/third_party/leveldatabase/env_chromium.cc
Project Member

Comment 13 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65421f69a6e0e69991c3d6521f98efa8647b547f

commit 65421f69a6e0e69991c3d6521f98efa8647b547f
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue May 22 23:16:18 2018

Reland "Fuchsia: Stop setting OS_POSIX"

This is a reland of 90f86c118d322a2ad437157a71cef8fc43a17d01

Original change's description:
> Fuchsia: Stop setting OS_POSIX
>
> Bug:  836416 
> Change-Id: Ib59796358ff2109ec0b55686974a84980e18254e
> Reviewed-on: https://chromium-review.googlesource.com/1020375
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Matt Mueller <mattm@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560013}

Bug:  836416 
Change-Id: I43f34aa644e51d231c7c131b4be364b6ccee2d38
Reviewed-on: https://chromium-review.googlesource.com/1066711
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560828}
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/base/debug/activity_tracker.cc
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/base/files/file_util.h
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/base/files/file_util_unittest.cc
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/base/memory/shared_memory.h
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/base/memory/shared_memory_handle.h
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/base/process/launch.h
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/base/process/process_iterator.cc
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/base/process/process_unittest.cc
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/base/process/process_util_unittest.cc
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/base/strings/stringprintf_unittest.cc
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/build/build_config.h
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/content/public/browser/content_browser_client.h
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/net/disk_cache/blockfile/rankings.cc
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/sql/connection.cc
[modify] https://crrev.com/65421f69a6e0e69991c3d6521f98efa8647b547f/third_party/leveldatabase/env_chromium.cc

Comment 15 by fdegans@chromium.org, May 24 2018

Status: Fixed (was: Started)
Cautiously closing as fixed.
Project Member

Comment 16 by bugdroid1@chromium.org, May 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/166efcbb58097fcc891e130dec92a2850e815a76

commit 166efcbb58097fcc891e130dec92a2850e815a76
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Sat May 26 00:47:23 2018

[Fuchsia] Fix command line initialization in service_manager

CommandLine was initialized only with OS_POSIX, which is no longer
defined on Fuchsia.

Bug:  836416 
Change-Id: I3a6a631827a7646ad89055d8e1d100ab043f9f81
Reviewed-on: https://chromium-review.googlesource.com/1073658
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562086}
[modify] https://crrev.com/166efcbb58097fcc891e130dec92a2850e815a76/content/app/content_main.cc
[modify] https://crrev.com/166efcbb58097fcc891e130dec92a2850e815a76/services/service_manager/embedder/main.cc
[modify] https://crrev.com/166efcbb58097fcc891e130dec92a2850e815a76/services/service_manager/embedder/main.h
►

Sign in to add a comment