New issue
Advanced search Search tips

Issue 836410 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on:
issue 846618

Blocking:
issue 833000



Sign in to add a comment

Finalise the list of task types

Project Member Reported by altimin@chromium.org, Apr 24 2018

Issue description

We need to create a clear set of task types (e.g. remove UnspecedTimer and Unthrottled) and write a clear set of guidelines on how to choose an appropriate one and when to add a new one.
 
Blocking: 833000
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8c7d0e14f6a34635445a895524834a062bbd725

commit f8c7d0e14f6a34635445a895524834a062bbd725
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Apr 26 03:34:35 2018

scheduler: Introduce kInternalDefault by renaming kUnspecedTimer

According to the task type usage guideline, we use kInternalDefault for
internal and default behavior tasks. This CL introduces kInternalDefault
by renaming kUnspecedTimer.

Doc: https://docs.google.com/document/d/1k7EEHQUEujgQ7BAhbmNdeaddwfJPWp7qjLy8mnVTQ9Y/edit

Bug: 836410
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id3d1aec136c6c30c632b87d58a13b8de76738653
Reviewed-on: https://chromium-review.googlesource.com/1027572
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553900}
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/public/platform/task_type.h
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/css/css_selector_watch.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/editing/finder/text_finder.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/editing/spellcheck/idle_spell_check_callback.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/editing/spellcheck/spell_check_requester.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/frame/platform_event_controller.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/html/forms/external_popup_menu.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/html/imports/html_import_tree_root.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/loader/interactive_detector.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/page/validation_message_client_impl.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/paint/first_meaningful_paint_detector.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/workers/dedicated_worker_object_proxy.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/workers/parent_execution_context_task_runners.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/workers/shared_worker_reporting_proxy.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/workers/threaded_object_proxy_base.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/modules/time_zone_monitor/time_zone_monitor_client.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/f8c7d0e14f6a34635445a895524834a062bbd725/tools/metrics/histograms/enums.xml

Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/987d16655a5821b9a841532c255ecb425333596f

commit 987d16655a5821b9a841532c255ecb425333596f
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed May 09 06:11:19 2018

scheduler: Replace kInternalAccessibility with kInternalDefault and deprectate kInternalAccessibility

Following the guideline https://bit.ly/2vMAsQ4, we determined to use
kInternalDefault as long as the tasks can run in the default way, that
might be throttled or paused. This CL deprecates kInternalAccessibility
whose task runner is a default task runner.

Bug: 836410
Change-Id: Icaa3532e3ef2563b8baa6436566cc5f1ac036b86
Reviewed-on: https://chromium-review.googlesource.com/1032318
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557109}
[modify] https://crrev.com/987d16655a5821b9a841532c255ecb425333596f/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/987d16655a5821b9a841532c255ecb425333596f/third_party/blink/public/platform/task_type.h
[modify] https://crrev.com/987d16655a5821b9a841532c255ecb425333596f/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/987d16655a5821b9a841532c255ecb425333596f/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc
[modify] https://crrev.com/987d16655a5821b9a841532c255ecb425333596f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/987d16655a5821b9a841532c255ecb425333596f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc

Project Member

Comment 6 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5ec9dde2be3999c4783f0ba2955abf320b0c26f

commit f5ec9dde2be3999c4783f0ba2955abf320b0c26f
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon May 14 05:42:40 2018

Replace kInternalAnimation with kInternalDefault

kInternalAnimation was introduced by replacing kUnspecedTimer, which is
now kInternalDefault [1]. As we defined the task type guideline [2],
the default behavior task runners should use kInternalDefault.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1009448
[2] https://bit.ly/2vMAsQ4,

BUG: 836410
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib5788929dce6331fc8deee8d93df9b351f6d83ca
Reviewed-on: https://chromium-review.googlesource.com/1055353
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558203}
[modify] https://crrev.com/f5ec9dde2be3999c4783f0ba2955abf320b0c26f/third_party/blink/public/platform/task_type.h
[modify] https://crrev.com/f5ec9dde2be3999c4783f0ba2955abf320b0c26f/third_party/blink/renderer/core/animation/document_timeline.h
[modify] https://crrev.com/f5ec9dde2be3999c4783f0ba2955abf320b0c26f/third_party/blink/renderer/core/animation/pending_animations.h
[modify] https://crrev.com/f5ec9dde2be3999c4783f0ba2955abf320b0c26f/third_party/blink/renderer/core/editing/frame_caret.cc
[modify] https://crrev.com/f5ec9dde2be3999c4783f0ba2955abf320b0c26f/third_party/blink/renderer/core/html/forms/spin_button_element.cc
[modify] https://crrev.com/f5ec9dde2be3999c4783f0ba2955abf320b0c26f/third_party/blink/renderer/core/layout/layout_progress.cc
[modify] https://crrev.com/f5ec9dde2be3999c4783f0ba2955abf320b0c26f/third_party/blink/renderer/core/svg/animation/smil_time_container.cc
[modify] https://crrev.com/f5ec9dde2be3999c4783f0ba2955abf320b0c26f/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc
[modify] https://crrev.com/f5ec9dde2be3999c4783f0ba2955abf320b0c26f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/f5ec9dde2be3999c4783f0ba2955abf320b0c26f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc

Project Member

Comment 7 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba6b00e58711c91b470cf2083b963e7413f2ed87

commit ba6b00e58711c91b470cf2083b963e7413f2ed87
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon May 14 06:34:27 2018

Replace TaskType::kUnthrottled with kInternalDefault in WebGL classes

The task runner is used at HandlePendingEventsAndPromises, and I think
an unthorttled task runner is not necessary here.

WebGLSync:
The unthrottled task runenr was introduced at https://chromium-review.googlesource.com/c/chromium/src/+/906402

WebGLQuery and WebGLTimerQueryExt:
The unthrottled task runner was introduced at https://codereview.chromium.org/2341043002

We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading
and replace them with appropriate kInternal* task types.

Task type guideline: https://bit.ly/2vMAsQ4

Bug: 836410
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2cc48425aaef973432f8bdee6fbb111b0e9a9188
Reviewed-on: https://chromium-review.googlesource.com/1055369
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558214}
[modify] https://crrev.com/ba6b00e58711c91b470cf2083b963e7413f2ed87/third_party/blink/renderer/modules/webgl/webgl_query.cc
[modify] https://crrev.com/ba6b00e58711c91b470cf2083b963e7413f2ed87/third_party/blink/renderer/modules/webgl/webgl_sync.cc
[modify] https://crrev.com/ba6b00e58711c91b470cf2083b963e7413f2ed87/third_party/blink/renderer/modules/webgl/webgl_timer_query_ext.cc

Project Member

Comment 8 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbad4647e80e0dc7d43ddc48284e997a96bc608d

commit cbad4647e80e0dc7d43ddc48284e997a96bc608d
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon May 14 09:43:44 2018

Replace TaskType::kUnthrottled with kInternalDefault in FontFaceSet

The task runner is used at HandlePendingEventsAndPromises, and I think
an unthorttled task runner is not necessary here.

Note that the original task runner before kUnthrottled was the default
timer task runner, which has gone. Related CLs:
- https://chromium-review.googlesource.com/c/chromium/src/+/822931
  Use the content's kUnthrottled task runner instead of the default
  timer task runner for FontFaceSet.
- https://chromium-review.googlesource.com/c/chromium/src/+/928186
  Remove the defualt timer task runner.

We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading
and replace them with appropriate kInternal* task types.

Task type guideline: https://bit.ly/2vMAsQ4

Bug: 836410
Change-Id: I40fb6bd63ee657b68d86f952d6517254ffbf4b51
Reviewed-on: https://chromium-review.googlesource.com/1055031
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558239}
[modify] https://crrev.com/cbad4647e80e0dc7d43ddc48284e997a96bc608d/third_party/blink/renderer/core/css/font_face_set.h

Project Member

Comment 9 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b

commit b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon May 14 12:47:51 2018

Replace TaskType::kUnthrottled with kInternalMedia where media is related

We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading
and replace them with appropriate kInternal* task types.

Task type guideline: https://bit.ly/2vMAsQ4

Bug: 836410
Change-Id: Iefcfd45fd251b0931d958b6b9d77a69d42930b1e
Reviewed-on: https://chromium-review.googlesource.com/1002793
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558273}
[modify] https://crrev.com/b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b/content/renderer/media/renderer_webmediaplayer_delegate.cc
[modify] https://crrev.com/b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b/third_party/blink/public/platform/task_type.h
[modify] https://crrev.com/b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b/third_party/blink/renderer/core/html/media/media_custom_controls_fullscreen_detector.cc
[modify] https://crrev.com/b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b/third_party/blink/renderer/core/html/media/media_remoting_interstitial.cc
[modify] https://crrev.com/b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc
[modify] https://crrev.com/b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b/third_party/blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc
[modify] https://crrev.com/b5a26ee1d117a1d085ee2890dfa37efcd9d5a28b/third_party/blink/renderer/modules/mediacapturefromelement/timed_canvas_draw_listener.cc

Project Member

Comment 10 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3828edc3f8a43876d3e5a8636b663e85981609b7

commit 3828edc3f8a43876d3e5a8636b663e85981609b7
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed May 16 06:28:20 2018

Replace TaskType::kUnthrottled with kInternalMedia where media is related

This CL is a following up for https://chromium-review.googlesource.com/c/chromium/src/+/1002793

We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading
and replace them with appropriate kInternal* task types.

Task type guideline: https://bit.ly/2vMAsQ4

Bug: 836410
Change-Id: If02ca728501a6c40e379963e88c6c41f599a5b0c
Reviewed-on: https://chromium-review.googlesource.com/1059089
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558995}
[modify] https://crrev.com/3828edc3f8a43876d3e5a8636b663e85981609b7/third_party/blink/renderer/core/workers/parent_execution_context_task_runners.cc
[modify] https://crrev.com/3828edc3f8a43876d3e5a8636b663e85981609b7/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/3828edc3f8a43876d3e5a8636b663e85981609b7/third_party/blink/renderer/modules/webaudio/audio_worklet_object_proxy.cc
[modify] https://crrev.com/3828edc3f8a43876d3e5a8636b663e85981609b7/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc

Project Member

Comment 11 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c69a66e35d46d9681fc8eff8756e90ea6c15f022

commit c69a66e35d46d9681fc8eff8756e90ea6c15f022
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu May 17 05:50:44 2018

Replace TaskType::kUnthrottled with kInternalDefault in BrowserPlugin

The task runner is used at UpdateInternalInstanceId and DeleteSoon, and
I think unthorttled task runner is not necessary here.

Note that the original task runner before kUnthrottled was
ThreadTaskRunnerHandle::Get().

We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading
and replace them with appropriate kInternal* task types.

Task type guideline: https://bit.ly/2vMAsQ4

Bug: 836410
Change-Id: I11679337908b6c64f3f6604639f2aed3b7c60ab0
Reviewed-on: https://chromium-review.googlesource.com/1055367
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559430}
[modify] https://crrev.com/c69a66e35d46d9681fc8eff8756e90ea6c15f022/content/renderer/browser_plugin/browser_plugin.cc

Project Member

Comment 12 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62f9db5525d2a0bea3d883a2c555d4365b191073

commit 62f9db5525d2a0bea3d883a2c555d4365b191073
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu May 17 08:22:32 2018

Replace kUnthrottled with kInternalLoading where network is related

This is a part of effort to eliminate kUnthrottled task type usages.

Note that the task runner was originally kUnspecedTimer (=
kInternalDefault) and changed to kUnthrottled at https://chromium-review.googlesource.com/c/chromium/src/+/664094

We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading
and replace them with appropriate kInternal* task types.

Task type guideline: https://bit.ly/2vMAsQ4

Bug: 836410
Change-Id: I9bd31b6f1100de6bbd5b0b69487b7f85d341ae2e
Reviewed-on: https://chromium-review.googlesource.com/1056902
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559455}
[modify] https://crrev.com/62f9db5525d2a0bea3d883a2c555d4365b191073/third_party/blink/renderer/core/loader/idleness_detector.cc

Project Member

Comment 13 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/715544288ce910f6b2f3c0721d4b672a752585ba

commit 715544288ce910f6b2f3c0721d4b672a752585ba
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue May 22 10:45:50 2018

Replace TaskType::kUnthrottled with kInternalDOM in IntersectionObserverController

We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading
and replace them with appropriate kInternal* task types.

Task type guideline: https://bit.ly/2vMAsQ4

Bug: 836410
Change-Id: I52d2611a768666de1e5adaea7e5cf93fe9d087ba
Reviewed-on: https://chromium-review.googlesource.com/1055143
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560527}
[modify] https://crrev.com/715544288ce910f6b2f3c0721d4b672a752585ba/third_party/blink/public/platform/task_type.h
[modify] https://crrev.com/715544288ce910f6b2f3c0721d4b672a752585ba/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.cc
[modify] https://crrev.com/715544288ce910f6b2f3c0721d4b672a752585ba/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc
[modify] https://crrev.com/715544288ce910f6b2f3c0721d4b672a752585ba/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/715544288ce910f6b2f3c0721d4b672a752585ba/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/715544288ce910f6b2f3c0721d4b672a752585ba/tools/metrics/histograms/enums.xml

Blockedon: 846618
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0

commit aa6f05dff4a1cfc932f4edf6f052b12722db7bb0
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Jun 08 11:51:35 2018

Remove TaskType::kUnthrottled

Now LocalDOMWindow::event_queue_ is no longer used by IndexedDB, the
task type doesn't have to be 'kUnthrottled'. This was the last one usage
of kUnthrottled and we can remove this now.

Bug: 836410,  846618 
Change-Id: Ifb5913d93a36cc6f8a5f645c6ecbf0016e424ad4
Reviewed-on: https://chromium-review.googlesource.com/1092225
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565611}
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/public/platform/task_type.h
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/renderer/core/workers/parent_execution_context_task_runners.cc
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler.cc

Sign in to add a comment