New issue
Advanced search Search tips

Issue 836400 link

Starred by 2 users
Status: Fixed
Owner:
kkhorimoto@chromium.org
Closed: May 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-04-25
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 835044



Sign in to add a comment

[iOS] Fullscreen Experiment: Use safe area to update viewport of browser container view.

Project Member Reported by kkhorimoto@chromium.org, Apr 24 2018 
The current implementation resizes the entire WKWebView, leading to slow rendering.  Another experiment behind the #fullscreen-content-inset flag implements this using the WKScrollView |contentInset| property.

Another option on iOS11+ is to leverage UIViewController's |additionalSafeAreaInsets|, as WKWebView should respect the safe area guide when choosing the viewport.

Comment 1 by kkhorimoto@chromium.org, Apr 24 2018

Blocking: 835044
Labels: MS-Fullscreen
NextAction: 2018-04-25

Comment 2 by monor...@bugs.chromium.org, Apr 25 2018 

The NextAction date has arrived: 2018-04-25
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e470d005b3a4934ae3332afe67163c9593ab2855

commit e470d005b3a4934ae3332afe67163c9593ab2855
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Thu Apr 26 01:11:47 2018

[iOS] Create BrowserContainerCoordinator.

This coordinator manages the BrowserContainerViewController, which
displays the main web page content view.  This is in preparation for
a new fullscreen implementation experiment where the container will
conform to FullscreenUIElement.  The coordinator can setup and tear
down FullscreenUIUpdaters for the BrowserContainerViewController upon
starting/stopping.

Bug:  836400 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4054c279dcabe2a8f88ebb769ae40d1d15f07b67
Reviewed-on: https://chromium-review.googlesource.com/1026564
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553864}
[modify] https://crrev.com/e470d005b3a4934ae3332afe67163c9593ab2855/ios/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/e470d005b3a4934ae3332afe67163c9593ab2855/ios/chrome/browser/ui/browser_container/BUILD.gn
[add] https://crrev.com/e470d005b3a4934ae3332afe67163c9593ab2855/ios/chrome/browser/ui/browser_container/OWNERS
[add] https://crrev.com/e470d005b3a4934ae3332afe67163c9593ab2855/ios/chrome/browser/ui/browser_container/browser_container_coordinator.h
[add] https://crrev.com/e470d005b3a4934ae3332afe67163c9593ab2855/ios/chrome/browser/ui/browser_container/browser_container_coordinator.mm
[rename] https://crrev.com/e470d005b3a4934ae3332afe67163c9593ab2855/ios/chrome/browser/ui/browser_container/browser_container_view_controller.h
[rename] https://crrev.com/e470d005b3a4934ae3332afe67163c9593ab2855/ios/chrome/browser/ui/browser_container/browser_container_view_controller.mm
[rename] https://crrev.com/e470d005b3a4934ae3332afe67163c9593ab2855/ios/chrome/browser/ui/browser_container/browser_container_view_controller_unittest.mm
[modify] https://crrev.com/e470d005b3a4934ae3332afe67163c9593ab2855/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/e470d005b3a4934ae3332afe67163c9593ab2855/ios/chrome/test/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc33af3eed5e3afffdb260c117b3bdb8bccd2c75

commit dc33af3eed5e3afffdb260c117b3bdb8bccd2c75
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Tue May 01 01:39:14 2018

[iOS] Create a multi-choice command line switch for FS experiments.

This CL changes the content inset experiment to one value in a 3-choice
experiment configured via command line switches.  The default option
updates the WKWebView's frame, and the third option is for a safe area
based approach.

Bug:  836400 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3ed07def98e96ab01bff7547bc244d6bb963bf58
Reviewed-on: https://chromium-review.googlesource.com/1026791
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554960}
[modify] https://crrev.com/dc33af3eed5e3afffdb260c117b3bdb8bccd2c75/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/dc33af3eed5e3afffdb260c117b3bdb8bccd2c75/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/dc33af3eed5e3afffdb260c117b3bdb8bccd2c75/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/dc33af3eed5e3afffdb260c117b3bdb8bccd2c75/ios/chrome/browser/ui/fullscreen/BUILD.gn
[modify] https://crrev.com/dc33af3eed5e3afffdb260c117b3bdb8bccd2c75/ios/chrome/browser/ui/fullscreen/fullscreen_features.h
[modify] https://crrev.com/dc33af3eed5e3afffdb260c117b3bdb8bccd2c75/ios/chrome/browser/ui/fullscreen/fullscreen_features.mm
[modify] https://crrev.com/dc33af3eed5e3afffdb260c117b3bdb8bccd2c75/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.mm

Comment 5 by kkhorimoto@chromium.org, May 9 2018

Labels: S-Fullscreen-Experiments
Status: Fixed (was: Started)
I finished implementing this, but it did not fix what we had intended.  However, some code from this experiment is being used in the hybrid experiment.

Comment 6 by kkhorimoto@chromium.org, May 23 2018

Status: Started (was: Fixed)
Marking as Started, as crrev.com/c/1066784 still needs to land.

Comment 7 by kkhorimoto@chromium.org, May 23 2018

Summary: [iOS] Fullscreen Experiment: Use safe area to update viewport of browser container view. (was: [iOS] Fullscreen Experiment: Create flag to test implementing web page content inset using safe area insets)

Comment 8 by kkhorimoto@chromium.org, May 30 2018

Status: Fixed (was: Started)
►

Sign in to add a comment