P2P Sharing of prefetched articles not working from the 3-dot DH item menu (airplane mode) |
|||
Issue descriptionDevice name: Pixel 2 Application version: Canary 68.0.3400.0 Operating system: Android 8.1.0; Pixel 2 Build/OPM2.171019.029 I was offline (airplane mode) and attempted to use P2P sharing of offline pages listed in the Downloads Home. It didn't work (as in nothing happened). If I opened the page and then selected sharing from there, it did work.
,
Apr 25 2018
,
Apr 25 2018
The bug is caused by the patch https://chromium-review.googlesource.com/c/chromium/src/+/1000552 which is landed after M67. For now we don't have plan to merge the above patch to M67 since most of times the user should have already requested file permission storage when doing something on Downloads home.
,
Apr 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9eef8dcbfa7450d1d5792e5611321208249494b9 commit 9eef8dcbfa7450d1d5792e5611321208249494b9 Author: Jian Li <jianli@chromium.org> Date: Sat Apr 28 00:27:05 2018 Check if storage permission is granted before requesting it In DownloadController.requestFileAccess, we should check if storage permission is already granted before requesting it. Bug: 836397 Change-Id: Idadcdfc3b055696b8f7194e5d63bdee54a8d4959 Reviewed-on: https://chromium-review.googlesource.com/1029116 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#554579} [modify] https://crrev.com/9eef8dcbfa7450d1d5792e5611321208249494b9/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java
,
Apr 28 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by petewil@chromium.org
, Apr 25 2018Labels: -Pri-3 Pri-2