New issue
Advanced search Search tips

Issue 836397 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

P2P Sharing of prefetched articles not working from the 3-dot DH item menu (airplane mode)

Project Member Reported by carlosk@chromium.org, Apr 24 2018

Issue description

Device name: Pixel 2
Application version: Canary 68.0.3400.0
Operating system: Android 8.1.0; Pixel 2 Build/OPM2.171019.029

I was offline (airplane mode) and attempted to use P2P sharing of offline pages listed in the Downloads Home. It didn't work (as in nothing happened). If I opened the page and then selected sharing from there, it did work.
 
Cc: jianli@chromium.org
Labels: -Pri-3 Pri-2
I tested this with Dev and Canary, it is broken in Canary, but working in Dev, so we likely broke this in the last few days.  Not only does the "..." menu fail, but it also fails to share from the share icon in the top toolbar when an item is selected.

Jian, this may be related to a recent fix, can you take a look?

Comment 2 by jianli@chromium.org, Apr 25 2018

Owner: jianli@chromium.org
Status: Started (was: Untriaged)

Comment 3 by jianli@chromium.org, Apr 25 2018

The bug is caused by the patch https://chromium-review.googlesource.com/c/chromium/src/+/1000552 which is landed after M67.

For now we don't have plan to merge the above patch to M67 since most of times the user should have already requested file permission storage when doing something on Downloads home.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eef8dcbfa7450d1d5792e5611321208249494b9

commit 9eef8dcbfa7450d1d5792e5611321208249494b9
Author: Jian Li <jianli@chromium.org>
Date: Sat Apr 28 00:27:05 2018

Check if storage permission is granted before requesting it

In DownloadController.requestFileAccess, we should check if storage
permission is already granted before requesting it.

Bug:  836397 
Change-Id: Idadcdfc3b055696b8f7194e5d63bdee54a8d4959
Reviewed-on: https://chromium-review.googlesource.com/1029116
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554579}
[modify] https://crrev.com/9eef8dcbfa7450d1d5792e5611321208249494b9/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java

Comment 5 by jianli@chromium.org, Apr 28 2018

Status: Fixed (was: Started)

Sign in to add a comment