Spec at https://docs.google.com/presentation/d/1kXbnGrFln4CapA0bavU5zjZLALqeD4aQikVVKSJ0zFg/edit#slide=id.g364d7f9db1_0_8 (visible by @google accounts). Note that MD History uses its own, non-paper checkbox. It would be ideal for us to converge into one checkbox without regressing MD history performance if possible.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0269bc118f3131166d0673bdcac2039c7e801fcc commit 0269bc118f3131166d0673bdcac2039c7e801fcc Author: Scott Chen <scottchen@chromium.org> Date: Tue May 01 02:30:31 2018 WebUI[MD-refresh]: wrap history checkbox in an element This CL replaces history checkbox with the new cr-checkbox. This CL is intended to create a centralized checkbox element that eventually will replace all paper-checkbox as well, so we can style it in a single place for MD refresh. page-load speed is measured before and after this change, and no difference is observed. Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If0cabc2261597beefd502507729a26c73e721669 Reviewed-on: https://chromium-review.googlesource.com/1029183 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554977} [modify] https://crrev.com/0269bc118f3131166d0673bdcac2039c7e801fcc/chrome/browser/resources/md_history/history_item.html [modify] https://crrev.com/0269bc118f3131166d0673bdcac2039c7e801fcc/chrome/browser/resources/md_history/history_item.js [modify] https://crrev.com/0269bc118f3131166d0673bdcac2039c7e801fcc/chrome/browser/resources/md_history/lazy_load.html [add] https://crrev.com/0269bc118f3131166d0673bdcac2039c7e801fcc/chrome/test/data/webui/cr_elements/cr_checkbox_test.js [modify] https://crrev.com/0269bc118f3131166d0673bdcac2039c7e801fcc/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js [add] https://crrev.com/0269bc118f3131166d0673bdcac2039c7e801fcc/ui/webui/resources/cr_elements/cr_checkbox/BUILD.gn [add] https://crrev.com/0269bc118f3131166d0673bdcac2039c7e801fcc/ui/webui/resources/cr_elements/cr_checkbox/compiled_resources2.gyp [add] https://crrev.com/0269bc118f3131166d0673bdcac2039c7e801fcc/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html [add] https://crrev.com/0269bc118f3131166d0673bdcac2039c7e801fcc/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.js [modify] https://crrev.com/0269bc118f3131166d0673bdcac2039c7e801fcc/ui/webui/resources/cr_elements_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60e415ebada6e68f282b74dfcd6cb08d48d709f4 commit 60e415ebada6e68f282b74dfcd6cb08d48d709f4 Author: Scott Chen <scottchen@chromium.org> Date: Thu May 03 00:03:05 2018 WebUI[MD refresh]: add label to md-refreshed cr-checkbox. this CL adds styling to make cr-checkbox looks like the md-refresh mock. Also added a slot to cr-checkbox for allowing labels. Also replaced one checkbox in reset-profile-dialog as a pilot demo. There will be a follow-up CL to replace all paper-checkbox to cr-checkbox. Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia55925bc91c95407abe5b775758f1b9b4ef97b05 Reviewed-on: https://chromium-review.googlesource.com/1033346 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#555617} [modify] https://crrev.com/60e415ebada6e68f282b74dfcd6cb08d48d709f4/chrome/browser/resources/md_history/history_item.html [modify] https://crrev.com/60e415ebada6e68f282b74dfcd6cb08d48d709f4/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html [modify] https://crrev.com/60e415ebada6e68f282b74dfcd6cb08d48d709f4/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js [modify] https://crrev.com/60e415ebada6e68f282b74dfcd6cb08d48d709f4/chrome/test/data/webui/cr_elements/cr_checkbox_test.js [modify] https://crrev.com/60e415ebada6e68f282b74dfcd6cb08d48d709f4/chrome/test/data/webui/settings/reset_page_test.js [modify] https://crrev.com/60e415ebada6e68f282b74dfcd6cb08d48d709f4/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html [modify] https://crrev.com/60e415ebada6e68f282b74dfcd6cb08d48d709f4/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.js [modify] https://crrev.com/60e415ebada6e68f282b74dfcd6cb08d48d709f4/ui/webui/resources/cr_elements/paper_button_style_css.html [modify] https://crrev.com/60e415ebada6e68f282b74dfcd6cb08d48d709f4/ui/webui/resources/cr_elements/shared_vars_css.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6c77b80cd3c75616f92685141e6739877e31c93 commit e6c77b80cd3c75616f92685141e6739877e31c93 Author: Scott Chen <scottchen@chromium.org> Date: Fri May 04 00:09:34 2018 WebUI: allow setting paper-ripple's opacity. Bug: 836391 , 832184 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1ae3418e5b153a89b6d6bd5169365cc50bab7a15 Reviewed-on: https://chromium-review.googlesource.com/1040273 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555919} [modify] https://crrev.com/e6c77b80cd3c75616f92685141e6739877e31c93/third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple.html [modify] https://crrev.com/e6c77b80cd3c75616f92685141e6739877e31c93/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c66ff270ccd4f9da64df108f8d1be21c7291d229 commit c66ff270ccd4f9da64df108f8d1be21c7291d229 Author: Scott Chen <scottchen@chromium.org> Date: Tue May 08 00:17:26 2018 WebUI[MD-refresh]: change cr-checkbox ripple color Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I844b84c905601490519d943158a17bc79c2ac446 Reviewed-on: https://chromium-review.googlesource.com/1048177 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556618} [modify] https://crrev.com/c66ff270ccd4f9da64df108f8d1be21c7291d229/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html [modify] https://crrev.com/c66ff270ccd4f9da64df108f8d1be21c7291d229/ui/webui/resources/cr_elements/shared_vars_css.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ad171e960ab24624597dfebe08fbee78f153317 commit 5ad171e960ab24624597dfebe08fbee78f153317 Author: Scott Chen <scottchen@chromium.org> Date: Tue May 08 20:29:17 2018 WebUI[MD-refresh]: migrate from paper-checkbox to cr-checkbox Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9a62435e04983cbd28df474c20162423ac75df54 Reviewed-on: https://chromium-review.googlesource.com/1036785 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556948} [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/arc_support/main.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/emulator/audio_settings.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/emulator/battery_settings.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/emulator/shared_styles.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/login/arc_terms_of_service.css [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/login/arc_terms_of_service.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/login/oobe_eula.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/login/oobe_hid_detection.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/login/oobe_reset.css [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/login/oobe_reset.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/login/recommend_apps.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/login/sync_consent.css [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/login/sync_consent.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/md_extensions/kiosk_dialog.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/md_extensions/kiosk_dialog.js [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/md_user_manager/create_profile.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/media_router/elements/route_controls/BUILD.gn [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/media_router/elements/route_controls/route_controls.css [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/media_router/elements/route_controls/route_controls.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/media_router/elements/route_controls/route_controls.js [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/controls/important_site_checkbox.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/controls/settings_checkbox.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/languages_page/BUILD.gn [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/languages_page/add_languages_dialog.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/languages_page/add_languages_dialog.js [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/languages_page/manage_input_methods_page.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/languages_page/manage_input_methods_page.js [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/browser/resources/settings/site_settings/add_site_dialog.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/test/data/webui/cr_elements/cr_lazy_render_tests.js [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/chrome/test/data/webui/extensions/extension_kiosk_mode_test.js [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/ui/file_manager/gallery/gallery.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/ui/file_manager/gallery/js/BUILD.gn [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/ui/file_manager/gallery/js/slide_mode.js [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/ui/webui/resources/cr_components/certificate_manager/ca_trust_edit_dialog.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html [delete] https://crrev.com/7de47372cbcfae05df70938a248b04ce62c94379/ui/webui/resources/cr_elements/paper_checkbox_style_css.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/ui/webui/resources/cr_elements/paper_input_style_css.html [modify] https://crrev.com/5ad171e960ab24624597dfebe08fbee78f153317/ui/webui/resources/cr_elements_resources.grdp
Issue 690370 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c64093e03e3dba84fd85e03a75be0338b3f3f5b5 commit c64093e03e3dba84fd85e03a75be0338b3f3f5b5 Author: Scott Chen <scottchen@chromium.org> Date: Thu May 10 22:26:30 2018 WebUI Polymer: Remove paper-checkbox from third_party/polymer. Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I27a757241ae2b8b44453b9acb1000fe8d9ddb69d Reviewed-on: https://chromium-review.googlesource.com/1054217 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557702} [modify] https://crrev.com/c64093e03e3dba84fd85e03a75be0338b3f3f5b5/third_party/polymer/v1_0/bower.json [delete] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/third_party/polymer/v1_0/components-chromium/paper-checkbox/BUILD.gn [delete] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/third_party/polymer/v1_0/components-chromium/paper-checkbox/bower.json [delete] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/third_party/polymer/v1_0/components-chromium/paper-checkbox/compiled_resources2.gyp [delete] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/third_party/polymer/v1_0/components-chromium/paper-checkbox/paper-checkbox-extracted.js [delete] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/third_party/polymer/v1_0/components-chromium/paper-checkbox/paper-checkbox.html [modify] https://crrev.com/c64093e03e3dba84fd85e03a75be0338b3f3f5b5/third_party/polymer/v1_0/components_summary.txt [modify] https://crrev.com/c64093e03e3dba84fd85e03a75be0338b3f3f5b5/ui/webui/resources/polymer_resources.grdp
Tested the issue using #68.0.3427.0 on Mac 10.13.3, Linux Debian Rodete and Win 10 as per the steps mentioned in issue 690370 . @scottchen: Please find the screencast and confirm about the fix. Thanks!!
Comment 1 by bugdroid1@chromium.org
, May 1 2018